From: Felipe Balbi <me-uiRdBs8odbtmTBlB0Cgj/Q@public.gmane.org>
To: Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
Cc: Wang Hui <Hui.Wang-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B
Date: Mon, 15 Mar 2010 18:10:25 +0200 [thread overview]
Message-ID: <20100315161024.GC3879@gandalf> (raw)
In-Reply-To: <4B9E187E.6090802-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
On Mon, Mar 15, 2010 at 02:22:38PM +0300, Sergei Shtylyov wrote:
> The whole musb_platform_set_mode() seems to be implemented
> incorrectly on OMAPs -- it shouldn't touch the DevCtl.Session bit. This
correct. It should be changing the id pin rules just like in tusb6010.c
> function should control the ID pin override instead -- if the controller
> supports it. SRP must be initiated thru other means, i.e. 'srp' file in
> sysfs.
via musb_gadget_wakeup()
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-15 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 10:23 [PATCH 1/2] USB: musb: add two states to handle vbus error Wang Hui
[not found] ` <1268648622-28529-1-git-send-email-Hui.Wang-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-15 10:23 ` [PATCH 2/2] USB: musb: omap2430: add mode change from A to B Wang Hui
[not found] ` <1268648622-28529-2-git-send-email-Hui.Wang-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-15 11:22 ` Sergei Shtylyov
[not found] ` <4B9E187E.6090802-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-03-15 16:10 ` Felipe Balbi [this message]
2010-03-16 10:13 ` wanghui
[not found] ` <4B9F59DE.4070807-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2010-03-16 14:46 ` Felipe Balbi
2010-07-22 15:16 ` Kan-Ru Chen
[not found] ` <877hknwnrb.fsf-ONHucydYG54+Yz5RL6G0bA@public.gmane.org>
2010-07-22 16:40 ` Felipe Balbi
2010-07-23 4:38 ` Kan-Ru Chen
2010-03-16 10:49 ` [PATCH 1/2] USB: musb: add two states to handle vbus error wanghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315161024.GC3879@gandalf \
--to=me-uirdbs8odbtmtblb0cgj/q@public.gmane.org \
--cc=Hui.Wang-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
--cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox