From: Samuel Ortiz <sameo@linux.intel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "Olaya, Margarita" <magi.olaya@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCHv2 1/2] OMAP4: PMIC: Rename twl6030_codec as twl6040_codec
Date: Thu, 18 Mar 2010 17:38:30 +0100 [thread overview]
Message-ID: <20100318163829.GD3106@sortiz.org> (raw)
In-Reply-To: <20100318121020.GI3080@opensource.wolfsonmicro.com>
On Thu, Mar 18, 2010 at 12:10:21PM +0000, Mark Brown wrote:
> On Wed, Mar 17, 2010 at 05:42:29PM -0500, Olaya, Margarita wrote:
> > Correction for chips:
> > twl6030 is Phoenix Power chip
> > twl6040 is Phoenix Audio chip
>
> > Signed-off-by: Margarita Olaya Cabrera <magi.olaya@ti.com>
>
> Samuel, are you OK with doing this via the ASoC tree?
If that's more convenient to you, then go for it, with my:
Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Cheers,
Samuel.
> > ---
> > drivers/mfd/twl-core.c | 4 ++--
> > include/linux/i2c/twl.h | 6 +++---
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
> > index 562cd49..720e099 100644
> > --- a/drivers/mfd/twl-core.c
> > +++ b/drivers/mfd/twl-core.c
> > @@ -109,7 +109,7 @@
> > #endif
> >
> > #if defined(CONFIG_TWL4030_CODEC) || defined(CONFIG_TWL4030_CODEC_MODULE) ||\
> > - defined(CONFIG_SND_SOC_TWL6030) || defined(CONFIG_SND_SOC_TWL6030_MODULE)
> > + defined(CONFIG_SND_SOC_TWL6040) || defined(CONFIG_SND_SOC_TWL6040_MODULE)
> > #define twl_has_codec() true
> > #else
> > #define twl_has_codec() false
> > @@ -708,7 +708,7 @@ add_children(struct twl4030_platform_data *pdata, unsigned long features)
> > /* Phoenix*/
> > if (twl_has_codec() && pdata->codec && twl_class_is_6030()) {
> > sub_chip_id = twl_map[TWL_MODULE_AUDIO_VOICE].sid;
> > - child = add_child(sub_chip_id, "twl6030_codec",
> > + child = add_child(sub_chip_id, "twl6040_codec",
> > pdata->codec, sizeof(*pdata->codec),
> > false, 0, 0);
> > if (IS_ERR(child))
> > diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
> > index fb6784e..ebd90ce 100644
> > --- a/include/linux/i2c/twl.h
> > +++ b/include/linux/i2c/twl.h
> > @@ -569,9 +569,9 @@ struct twl4030_codec_data {
> > struct twl4030_codec_audio_data *audio;
> > struct twl4030_codec_vibra_data *vibra;
> >
> > - /* twl6030 */
> > - int audpwron_gpio; /* audio power-on gpio */
> > - int naudint_irq; /* audio interrupt */
> > + /* twl6040 */
> > + int audpwron_gpio; /* audio power-on gpio */
> > + int naudint_irq; /* audio interrupt */
> > };
> >
> > struct twl4030_platform_data {
> > --
> > 1.6.1.3
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-03-18 16:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 22:42 [PATCHv2 1/2] OMAP4: PMIC: Rename twl6030_codec as twl6040_codec Olaya, Margarita
2010-03-18 8:43 ` [alsa-devel] " Liam Girdwood
2010-03-18 12:10 ` Mark Brown
2010-03-18 16:38 ` Samuel Ortiz [this message]
2010-03-18 17:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100318163829.GD3106@sortiz.org \
--to=sameo@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=magi.olaya@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox