public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Olaya, Margarita" <magi.olaya@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCHv6 2/2][RESEND] ASoC: TWL6040: Add twl6040 codec driver
Date: Thu, 18 Mar 2010 18:16:23 +0000	[thread overview]
Message-ID: <20100318181623.GG6142@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1889FA7136B567478A67D4B0F85B0CCE662AC7F1@dlee06.ent.ti.com>

On Thu, Mar 18, 2010 at 12:59:49PM -0500, Olaya, Margarita wrote:
> From: Misael Lopez Cruz <x0052729@ti.com>
> 
> Initial version of TWL6040 codec driver.
> 
> The TWL6040 codec uses a proprietary PDM-based digital audio interface.
> Audio paths supported are:

I'm getting exactly the same results trying to apply this.  It looks
like there's some MUA corruption going on here, the start of the
Makefile diff is:

--- a/sound/soc/codecs/Makefile
+++ b/sound/soc/codecs/Makefile
@@ -22,6 +22,7 @@ snd-soc-tlv320aic26-objs :=3D tlv320aic26.o
 snd-soc-tlv320aic3x-objs :=3D tlv320aic3x.o
 snd-soc-tlv320dac33-objs :=3D tlv320dac33.o
 snd-soc-twl4030-objs :=3D twl4030.o
+snd-soc-twl6040-objs :=3D twl6040.o
 snd-soc-uda134x-objs :=3D uda134x.o
 snd-soc-uda1380-objs :=3D uda1380.o
 snd-soc-wm8350-objs :=3D wm8350.o
@@ -85,6 +86,7 @@ obj-$(CONFIG_SND_SOC_TLV320AIC26)     +=3D snd-soc-tlv320=
aic26.o
 obj-$(CONFIG_SND_SOC_TLV320AIC3X)      +=3D snd-soc-tlv320aic3x.o
 obj-$(CONFIG_SND_SOC_TLV320DAC33)      +=3D snd-soc-tlv320dac33.o
 obj-$(CONFIG_SND_SOC_TWL4030)  +=3D snd-soc-twl4030.o

The quoted printable encoding should be fine but note that the 'aic26.o'
has been word wrapped onto a new line, which is why patch says the diff
is corrupted.  The same word wrapping issue is occurring in other places
in the diff such as:

+       /* allow registers to be accessed by i2c */
+       twl6040_write(codec, TWL6040_REG_ACCCTL, cache[TWL6040_REG_ACCCTL])=
;

Looks like MUA trouble.  From the message headers it looks like you
might be using Outlook or something, I'm not sure what to suggest for
that - enough folks at TI are submitting patches that something must've
been worked out for your mail system.

If you can't work out a solution for sending things in-line0 then
sending the patch as an attachment should resolve the issue.

  reply	other threads:[~2010-03-18 18:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-18 17:59 [PATCHv6 2/2][RESEND] ASoC: TWL6040: Add twl6040 codec driver Olaya, Margarita
2010-03-18 18:16 ` Mark Brown [this message]
2010-03-18 18:28   ` Kevin Hilman
2010-03-18 20:37     ` Olaya, Margarita
2010-03-18 18:38   ` Olaya, Margarita
2010-03-19 11:27     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100318181623.GG6142@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=magi.olaya@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox