From: Felipe Balbi <felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
To: ext Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
Cc: "Balbi Felipe (Nokia-D/Helsinki)"
<felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>,
Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>,
Linux USB Mailing List
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux OMAP Mailing List
<linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [patch-2.6.35 09/11] usb: musb: Makefile: remove unexistent config option
Date: Thu, 25 Mar 2010 08:38:12 +0200 [thread overview]
Message-ID: <20100325063812.GN29419@nokia.com> (raw)
In-Reply-To: <4BAA28D8.70705-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
On Wed, Mar 24, 2010 at 03:59:36PM +0100, ext Sergei Shtylyov wrote:
>Felipe Balbi wrote:
>
>> Remove the unexistent CONFIG_USB_INVENTRA_MUSB_HAS_AHB_ID
>> option from our Makefile.
>>
>> Problem reported by Sergei Shtylyov <sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
>>
>> Signed-off-by: Felipe Balbi <felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
>> ---
>> drivers/usb/musb/Makefile | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/musb/Makefile b/drivers/usb/musb/Makefile
>> index a1677f9..4266d79 100644
>> --- a/drivers/usb/musb/Makefile
>> +++ b/drivers/usb/musb/Makefile
>> @@ -74,10 +74,6 @@ endif
>>
>> # FIXME remove all these extra "-DMUSB_* things, stick to CONFIG_*
>>
>> -ifeq ($(CONFIG_USB_INVENTRA_MUSB_HAS_AHB_ID),y)
>> - EXTRA_CFLAGS += -DMUSB_AHB_ID
>> -endif
>> -
>>
>
> You forgot to remove FIXME.
there's still -DDEBUG there. Maybe it doesn't really matter.
>
>WBR, Sergei
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-25 6:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 12:55 [patch-2.6.35 00/11] musb patches Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 01/11] usb: musb: debugfs: musb_exit_debugfs() can be called on probe Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 03/11] MUSB: OMAP: remove omap_vbus_power() Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 04/11] MUSB: Blackfin: remove bfin_vbus_power() Felipe Balbi
[not found] ` <1269435318-29153-5-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-03-24 14:21 ` Sergei Shtylyov
[not found] ` <1269435318-29153-1-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-03-24 12:55 ` [patch-2.6.35 02/11] USB: musb: support host/gadget role switching on Blackfin parts Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 05/11] MUSB: OMAP: make musb_platform_suspend() 'static' Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 06/11] MUSB: Blackfin: remove musb_platform_{suspend|resume}() Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 07/11] usb: musb: omap2430: remove unused define Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 09/11] usb: musb: Makefile: remove unexistent config option Felipe Balbi
[not found] ` <1269435318-29153-10-git-send-email-felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-03-24 14:24 ` Sergei Shtylyov
2010-03-24 14:59 ` Sergei Shtylyov
[not found] ` <4BAA28D8.70705-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-03-25 6:38 ` Felipe Balbi [this message]
[not found] ` <20100325063812.GN29419-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-03-25 9:53 ` Sergei Shtylyov
2010-03-24 12:55 ` [patch-2.6.35 08/11] usb: musb: omap2430.c: remove unnecessary includes Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 10/11] musb: Add extvbus in musb_board_data Felipe Balbi
2010-03-24 12:55 ` [patch-2.6.35 11/11] usb: musb: add ulpi access operations Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325063812.GN29419@nokia.com \
--to=felipe.balbi-xnzwkgviw5gavxtiumwx3w@public.gmane.org \
--cc=greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sshtylyov-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox