From: Jarkko Nikula <jhnikula@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC][PATCH] ASoC: OMAP: Fix capture pointer handling for OMAP1510 to work correctly with recent ALSA PCM code
Date: Mon, 29 Mar 2010 11:54:59 +0300 [thread overview]
Message-ID: <20100329115459.b44f0d1c.jhnikula@gmail.com> (raw)
In-Reply-To: <201003282229.32922.jkrzyszt@tis.icnet.pl>
On Sun, 28 Mar 2010 22:29:29 +0200
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> With recent (2.6.34) chnages in PCM handling, capture stopped working on my
> OMAP1510 based Amstrad Delta videophone.
>
> Using 2.6.34-rc2, I was able to correct the problem in 3 different ways:
>
> 1. reverting commit 7b3a177b0d4f92b3431b8dca777313a07533a710,
> 2. enabling additional jiffies check with
> echo 4 >/proc/asound/card0/pcm0c0/xrun_debug
> 3. applying the patch below.
>
> Since I wasn't able to reproduce the problem on my i686 PC, I guess the
> problem is probably machine specific.
>
> The patch reuses the method for software emulation of missing hardware
> pointer, already implemented for playback on OMAP1510. It's possible that
> event if a hardware pointer is available for capture on this machine, its
> behaviour may be not compatible with what upper layer expects.
>
> If you think the problem may be more general and should be solved differently,
> on a higher level, I can try to work more on it if you give me a hint.
>
I don't have anything against this patch as it makes the
playback/capture code uniform on 1510 but I don't understand why the
capture broke now if it was working before.
What I was thinking if there has been always some overruns which were
not detected on 2.6.34-rc anymore and that caused somehow the capture
not working on 1510. Could you try does a patch below have any effect?
http://mailman.alsa-project.org/pipermail/alsa-devel/2010-March/026487.html
--
Jarkko
next prev parent reply other threads:[~2010-03-29 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 20:29 [RFC][PATCH] ASoC: OMAP: Fix capture pointer handling for OMAP1510 to work correctly with recent ALSA PCM code Janusz Krzysztofik
2010-03-29 8:54 ` Jarkko Nikula [this message]
2010-03-29 12:14 ` Janusz Krzysztofik
2010-04-01 12:25 ` Mark Brown
2010-04-01 19:45 ` Janusz Krzysztofik
2010-04-02 8:10 ` Jarkko Nikula
2010-04-02 9:36 ` Mark Brown
2010-04-02 10:51 ` Janusz Krzysztofik
2010-04-02 16:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329115459.b44f0d1c.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox