From: Ralph Corderoy <ralph@inputplus.co.uk>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Tony Lindgren <tony@atomide.com>,
e3-hacking@earth.li, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC][PATCH v2 1/5] omap1: Amstrad Delta: add FIQ handler for serial keyboard port interrupt processing
Date: Wed, 31 Mar 2010 01:06:57 +0100 [thread overview]
Message-ID: <20100331000657.D97895225@blake.inputplus.co.uk> (raw)
In-Reply-To: <201003301708.41634.jkrzyszt@tis.icnet.pl>
Hi Janusz,
> And thanks for pushing me into reading the ARM Assembly Language book,
> so I would be able to do more than just understanding and copy-pasting
> the code ;).
It's a lovely instruction set compared to many others.
> > > +state:
> > > + ldr r10, [r9,#FIQ_STATE]
> > > + cmp r10, #0 @ are we expecting start bit?
> > > + bne data @ no - in data processing state
> >
> > Similarly, an `ldrs' here would make the cmp redundant.
>
> I'm not sure if the S suffix is also valid for memory transfer
> instructions
No, you're correct. Memory transfers can't do the "set ALU flags"
S-bit. Sorry to mislead.
Cheers,
Ralph.
next prev parent reply other threads:[~2010-03-31 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 14:19 [RFC][PATCH v2 0/5] omap1: Amstrad Delta: add support for external keyboard Janusz Krzysztofik
2010-03-29 14:24 ` [RFC][PATCH v2 1/5] omap1: Amstrad Delta: add FIQ handler for serial keyboard port interrupt processing Janusz Krzysztofik
[not found] ` <20100329183211.F105C493B@blake.inputplus.co.uk>
2010-03-30 15:08 ` [E3-hacking] " Janusz Krzysztofik
2010-03-31 0:06 ` Ralph Corderoy [this message]
2010-03-29 14:26 ` [RFC][PATCH v2 2/5] omap1: Amstrad Delta: add a handler for processing interrupts generated by the FIQ routine Janusz Krzysztofik
2010-03-29 14:28 ` [RFC][PATCH v2 3/5] omap1: Amstrad Delta: use FIQ for processing GPIO interrupts Janusz Krzysztofik
2010-03-29 14:30 ` [RFC][PATCH v2 4/5] input: serio: add support for Amstrad Delta serial keyboard port Janusz Krzysztofik
2010-03-30 6:56 ` Dmitry Torokhov
2010-03-30 10:23 ` Janusz Krzysztofik
2010-03-29 14:32 ` [RFC][PATCH v2 5/5] omap1: Amstrad Delta: modify defconfig for external keyboard support Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331000657.D97895225@blake.inputplus.co.uk \
--to=ralph@inputplus.co.uk \
--cc=e3-hacking@earth.li \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox