From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] OMAP3: mailbox initialization for all omap versions Date: Thu, 1 Apr 2010 02:52:04 -0700 Message-ID: <20100401095203.GL31200@atomide.com> References: <496565EC904933469F292DDA3F1663E602CADC372D@dlee06.ent.ti.com> <20100329.094017.112623699.Hiroshi.DOYU@nokia.com> <20100329070145.GF28825@nokia.com> <20100329.120856.59654379.Hiroshi.DOYU@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-01-ewr.mailhop.org ([204.13.248.71]:63395 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754792Ab0DAJuS (ORCPT ); Thu, 1 Apr 2010 05:50:18 -0400 Content-Disposition: inline In-Reply-To: <20100329.120856.59654379.Hiroshi.DOYU@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Hiroshi DOYU Cc: felipe.balbi@nokia.com, x0095840@ti.com, linux-omap@vger.kernel.org, ameya.palande@nokia.com, felipe.contreras@nokia.com * Hiroshi DOYU [100329 02:05]: > From: "Balbi Felipe (Nokia-D/Helsinki)" > Subject: Re: [PATCH] OMAP3: mailbox initialization for all omap versions > Date: Mon, 29 Mar 2010 09:01:45 +0200 > > > > in that case, wouldn't it be better to split that into > > arch/arm/omap1/mbox.c arch/arm/omap2/mbox24xx.c > > arch/arm/omap2/mbox34xx.c arch/arm/omap2/mbox44xx.c ?? > > > > that way we don't need ifdefs on the code and we will only compile what > > we really need. > > This is feasible. > But I'm not so sure whether adding 4 new files with around only 10 > lines code is acceptable or not. > > Tony, any comment on the above? > > Basically there could be the case we need all resources if we want to > support omap1, 2, 3 and 4 at the same time, and the appropriate one > will be chosen at run time by CPUID. I'm not sure how mature "omap > multi arch" support is practically, but it's better to keep it as much > as possbile. I like Felipe's suggestion of adding devices2420.c, devices34xx.c, devices44xx.c or similar. Then do the device init from those with a arch_initcall that returns immediately if not running on the right soc. Tony