From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Grazvydas Ignotas <notasas@gmail.com>
Cc: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
David Brownell <david-b@pacbell.net>,
Tony Lindgren <tony@atomide.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [RFC/PATCHv2 2/4] arm: omap: gpio: implement set_debounce method
Date: Thu, 1 Apr 2010 13:10:43 +0300 [thread overview]
Message-ID: <20100401101043.GI16297@nokia.com> (raw)
In-Reply-To: <i2i6ed0b2681004010237pf44f0f2ak992411ccae6f1b6d@mail.gmail.com>
On Thu, Apr 01, 2010 at 11:37:16AM +0200, ext Grazvydas Ignotas wrote:
>On Thu, Apr 1, 2010 at 12:32 PM, Felipe Balbi <felipe.balbi@nokia.com> wrote:
>> On Thu, Apr 01, 2010 at 11:29:16AM +0200, ext Grazvydas Ignotas wrote:
>>>
>>> Hmh, dbck is shared by the whole GPIO bank, so what happens if someone
>>> calls _set_gpio_debounce(bank, 1, 310) and then
>>> _set_gpio_debounce(bank, 2, 0)? This should leave debounce enabled for
>>> GPIO1, but you'll disable dbck on second call. GPIOs 0-31 share the
>>> same bank.
>>
>> but why would you call _set_gpio_debounce(bank, 2 0); without setting a real
>> debounce value before ?
>
>ok then you could call
> _set_gpio_debounce(bank, 1, 310);
> _set_gpio_debounce(bank, 2, 310);
> _set_gpio_debounce(bank, 2, 0);
>
>The problem here is that debounce is still active for GPIO1, but you
>disable dbck for the whole bank.
but then you enabled the clock twice. There's refcounting for the clock.
--
balbi
next prev parent reply other threads:[~2010-04-01 10:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 12:27 [RFC/PATCH 0/4] teach gpiolib about gpio debouncing Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 1/4] gpiolib: introduce set_debounce method Felipe Balbi
2010-03-31 13:46 ` Mark Brown
2010-03-31 14:50 ` Felipe Balbi
2010-03-31 14:59 ` Felipe Balbi
2010-03-31 15:04 ` Mark Brown
2010-03-31 15:06 ` Felipe Balbi
2010-03-31 15:11 ` Mark Brown
2010-03-31 15:11 ` Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 2/4] arm: omap: gpio: implement " Felipe Balbi
2010-03-31 12:56 ` Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 3/4] arm: omap: switch over to gpio_set_debounce Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 4/4] arm: omap: remove the unused omap_gpio_set_debounce methods Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 0/4] teach gpiolib about debouncing Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 1/4] gpiolib: introduce set_debounce method Felipe Balbi
2010-04-02 12:34 ` Mark Brown
2010-05-04 22:40 ` Tony Lindgren
2010-05-05 18:37 ` Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 2/4] arm: omap: gpio: implement " Felipe Balbi
2010-03-31 16:21 ` Mark Brown
2010-03-31 16:29 ` Felipe Balbi
2010-04-01 5:39 ` Felipe Balbi
2010-04-01 9:29 ` Grazvydas Ignotas
2010-04-01 9:32 ` Felipe Balbi
2010-04-01 9:37 ` Grazvydas Ignotas
2010-04-01 10:10 ` Felipe Balbi [this message]
2010-04-01 11:20 ` Grazvydas Ignotas
2010-04-01 13:11 ` Jani Nikula
2010-04-01 16:42 ` Felipe Balbi
2010-04-01 18:15 ` Mark Brown
2010-04-01 18:19 ` Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 3/4] arm: omap: switch over to gpio_set_debounce Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 4/4] arm: omap: remove the unused omap_gpio_set_debounce methods Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401101043.GI16297@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).