From: Felipe Balbi <felipe.balbi@nokia.com>
To: "Doyu Hiroshi (Nokia-D/Helsinki)" <hiroshi.doyu@nokia.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"x0095840@ti.com" <x0095840@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Palande Ameya (Nokia-D/Helsinki)" <ameya.palande@nokia.com>,
"Contreras Felipe (Nokia-D/Helsinki)"
<felipe.contreras@nokia.com>
Subject: Re: [PATCH] OMAP3: mailbox initialization for all omap versions
Date: Thu, 1 Apr 2010 14:36:53 +0300 [thread overview]
Message-ID: <20100401113653.GM16297@nokia.com> (raw)
In-Reply-To: <20100401.142629.226796472.Hiroshi.DOYU@nokia.com>
Hi,
On Thu, Apr 01, 2010 at 01:26:29PM +0200, Doyu Hiroshi (Nokia-D/Helsinki) wrote:
>+static int __init omap24xx_init_devices(void)
>+{
>+ if (!cpu_is_omap24xx())
>+ return;
return 0
here.
>+static int __init omap44xx_init_devices(void)
>+{
>+ if (!cpu_is_omap44xx())
>+ return;
return 0
here too :-)
other than that, to me it looks a lot cleaner. Then we can start moving
any other device registration that still lies in devices.c to the new
files
--
balbi
next prev parent reply other threads:[~2010-04-01 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 19:30 [PATCH] OMAP3: mailbox initialization for all omap versions Guzman Lugo, Fernando
2010-03-29 6:40 ` Hiroshi DOYU
2010-03-29 7:01 ` Felipe Balbi
2010-03-29 9:08 ` Hiroshi DOYU
2010-04-01 9:52 ` Tony Lindgren
2010-04-01 10:23 ` Hiroshi DOYU
2010-04-01 11:26 ` Hiroshi DOYU
2010-04-01 11:36 ` Felipe Balbi [this message]
2010-04-01 12:33 ` Paul Walmsley
2010-04-01 12:50 ` Tony Lindgren
2010-04-01 13:06 ` Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401113653.GM16297@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox