From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: Jani Nikula <ext-jani.1.nikula@nokia.com>,
felipe.balbi@nokia.com, ext Grazvydas Ignotas <notasas@gmail.com>,
David Brownell <david-b@pacbell.net>,
Tony Lindgren <tony@atomide.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [RFC/PATCHv2 2/4] arm: omap: gpio: implement set_debounce method
Date: Thu, 1 Apr 2010 19:15:08 +0100 [thread overview]
Message-ID: <20100401181508.GA26650@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20100401164249.GA3814@gandalf>
On Thu, Apr 01, 2010 at 07:42:50PM +0300, Felipe Balbi wrote:
> On Thu, Apr 01, 2010 at 04:11:27PM +0300, Jani Nikula wrote:
> > You might want to have a look at [1] on irq debouncing. The hardware
> > support for debouncing varies (bank/gpio restrictions, debounce
> > timeouts, no support at all, what else?) so how can the users of this
> > interface rely on debouncing? What are the guarantees? AFAICS e.g.
> > gpio-keys would have to do software debouncing anyway.
> I think we could provide a generic software debouncing mechanism, sure,
> but if the hardware supports it, why not using ?
I tend to agree here, especially for GPIOs on slow buses like I2C or
which may be used as wake sources. I guess ideally we want something
like the LEDs do with blinking where we use the hardware feature if
present and suitable but fall back on software emulation transparently
if it's not available or can't be configured appropriately.
next prev parent reply other threads:[~2010-04-01 18:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 12:27 [RFC/PATCH 0/4] teach gpiolib about gpio debouncing Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 1/4] gpiolib: introduce set_debounce method Felipe Balbi
2010-03-31 13:46 ` Mark Brown
2010-03-31 14:50 ` Felipe Balbi
2010-03-31 14:59 ` Felipe Balbi
2010-03-31 15:04 ` Mark Brown
2010-03-31 15:06 ` Felipe Balbi
2010-03-31 15:11 ` Mark Brown
2010-03-31 15:11 ` Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 2/4] arm: omap: gpio: implement " Felipe Balbi
2010-03-31 12:56 ` Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 3/4] arm: omap: switch over to gpio_set_debounce Felipe Balbi
2010-03-31 12:27 ` [RFC/PATCH 4/4] arm: omap: remove the unused omap_gpio_set_debounce methods Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 0/4] teach gpiolib about debouncing Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 1/4] gpiolib: introduce set_debounce method Felipe Balbi
2010-04-02 12:34 ` Mark Brown
2010-05-04 22:40 ` Tony Lindgren
2010-05-05 18:37 ` Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 2/4] arm: omap: gpio: implement " Felipe Balbi
2010-03-31 16:21 ` Mark Brown
2010-03-31 16:29 ` Felipe Balbi
2010-04-01 5:39 ` Felipe Balbi
2010-04-01 9:29 ` Grazvydas Ignotas
2010-04-01 9:32 ` Felipe Balbi
2010-04-01 9:37 ` Grazvydas Ignotas
2010-04-01 10:10 ` Felipe Balbi
2010-04-01 11:20 ` Grazvydas Ignotas
2010-04-01 13:11 ` Jani Nikula
2010-04-01 16:42 ` Felipe Balbi
2010-04-01 18:15 ` Mark Brown [this message]
2010-04-01 18:19 ` Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 3/4] arm: omap: switch over to gpio_set_debounce Felipe Balbi
2010-03-31 15:35 ` [RFC/PATCHv2 4/4] arm: omap: remove the unused omap_gpio_set_debounce methods Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100401181508.GA26650@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=david-b@pacbell.net \
--cc=ext-jani.1.nikula@nokia.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=notasas@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).