public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <me@felipebalbi.com>
To: Viral Mehta <Viral.Mehta@lntinfotech.com>
Cc: Felipe Balbi <me@felipebalbi.com>,
	"felipe.balbi@nokia.com" <felipe.balbi@nokia.com>,
	"Gadiyar, Anand" <gadiyar@ti.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: USB on omap2430
Date: Mon, 5 Apr 2010 19:41:25 +0300	[thread overview]
Message-ID: <20100405164125.GA17388@gandalf> (raw)
In-Reply-To: <70376CA23424B34D86F1C7DE6B9973430254343A36@VSHINMSMBX01.vshodc.lntinfotech.com>

Hi,

On Mon, Apr 05, 2010 at 07:32:06PM +0530, Viral Mehta wrote:
> >>  static void __exit isp_exit(void)
> >>  {
> >>
> >>
> >>
> >> After adding the above code, isp1301's probe is called but that fails
> >> before it does otg_set_transceiver()
> >> And I am debugging further on that path.
> 
> >ok, cool. When you get that done, please send a cleaned up
> >diff with your signed-off-by line so it can be integrated.
> 
> I continued debugging further. It fails during USB initialisation.
> More specifically, in omap_otg_init() function in arch/arm/plat-omap/usb.c
> It gives a crash dump on the first line itself
> syscon = omap_readl(OTG_SYSCON_1) & 0xffff;

without the crash itself, it's pretty difficult to help. It could even
be just a missing clk_enable(). Although I believe that code shouldn't
be running for 2430, only for 2420.

Can you try the patch below:

> Apart from that, can I submit the 3 patches that we discussed earlier ?
> (http://www.mail-archive.com/linux-omap@vger.kernel.org/msg25932.html)
> These will not make FS USB functional on OMAP2430 but these changes are anyway necessary.

clean those patches first. And I'd like someone else with the 2430sdp
board to test it before I add my SOB.

-- 
balbi

  reply	other threads:[~2010-04-05 16:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <70376CA23424B34D86F1C7DE6B997343017F5D5BE1@VSHINMSMBX01.vshodc.lntinfotech.com>
     [not found] ` <70376CA23424B34D86F1C7DE6B997343017F5D5BE1-fVvhrSDAkVjuuPCCJ6VnObSn4PsL5ZDKvpI+GvaZM4lBDgjK7y7TUQ@public.gmane.org>
2010-03-24  9:16   ` USB on omap2430 Gadiyar, Anand
     [not found]     ` <5A47E75E594F054BAF48C5E4FC4B92AB032221A9F3-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-03-24  9:36       ` Viral Mehta
     [not found]         ` <70376CA23424B34D86F1C7DE6B997343017F5D5BE3-fVvhrSDAkVjuuPCCJ6VnObSn4PsL5ZDKvpI+GvaZM4lBDgjK7y7TUQ@public.gmane.org>
2010-03-26 11:08           ` Viral Mehta
     [not found]             ` <70376CA23424B34D86F1C7DE6B997343017F5D5BE7-fVvhrSDAkVjuuPCCJ6VnObSn4PsL5ZDKvpI+GvaZM4lBDgjK7y7TUQ@public.gmane.org>
2010-03-26 17:44               ` Felipe Balbi
2010-03-29 20:34                 ` Felipe Balbi
     [not found]                 ` <3821c76c47d164935b857a29de6bb797-WEDJutINlwSqfKURHDCIgFDQ4js95KgL@public.gmane.org>
2010-03-30  4:37                   ` Viral Mehta
2010-03-30  5:04                     ` Felipe Balbi
2010-03-29 20:41               ` Felipe Balbi
2010-03-30  4:54                 ` Viral Mehta
     [not found]                   ` <70376CA23424B34D86F1C7DE6B997343023C4E201B-fVvhrSDAkVjuuPCCJ6VnObSn4PsL5ZDKvpI+GvaZM4lBDgjK7y7TUQ@public.gmane.org>
2010-03-30  5:03                     ` Felipe Balbi
     [not found]                       ` <3bd3371a3ea8aa8fb53b62dbe99169e0-WEDJutINlwSqfKURHDCIgFDQ4js95KgL@public.gmane.org>
2010-04-05 14:02                         ` Viral Mehta
2010-04-05 16:41                           ` Felipe Balbi [this message]
2010-04-05 16:49                             ` Felipe Balbi
2010-04-06  8:35                             ` Gadiyar, Anand
2010-04-05 14:01                 ` Viral Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100405164125.GA17388@gandalf \
    --to=me@felipebalbi.com \
    --cc=Viral.Mehta@lntinfotech.com \
    --cc=felipe.balbi@nokia.com \
    --cc=gadiyar@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox