RE: USB on omap2430

RE: USB on omap2430

[Gadiyar, Anand]

Viral Mehta wrote:
> 
> I am working on OMAP2430 and for me with linux2.6.33, USB is 
> simply not working. Board is not even able to boot if I just 
> enable Host Support.
> 

Maybe someone on the linux-omap list would be able to help with
this - so adding linux-omap to the cc.

Are you using the 2430SDP or some other board? I don't think
anyone has tried booting one of those with mainline kernels
in a long time. Does the default config for your board work?

Maybe we can help get this working. Can you enable CONFIG_DEBUG_LL
and CONFIG_EARLY_PRINTK in your build, then add "earlyprintk" to
your bootargs?

If there is a crash during boot-up, this will let us know.

Also, do you know which transceiver you have on the board?
(TWL4030 or ISP1504 or something else?)

> I am seeing some patches for OMAP2430 USB support since few days.
> Anyone really tested USB on OMAP2430 hardware? Or any idea 
> whether it will work with head of linus tree or anything like that ?
> 

I posted one such patch - to remove some pin muxing code that
was under a CONFIG_ARCH_OMAP2430 macro - this code should not
be in a generic driver. I did not test on an actual 2430 board
because I don't have one.

- Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: USB on omap2430

[Viral Mehta]

________________________________________
From: Gadiyar, Anand [gadiyar-l0cyMroinI0@public.gmane.org]
Sent: Wednesday, March 24, 2010 2:46 PM
To: Viral Mehta; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: USB on omap2430

Viral Mehta wrote:
>>
>> I am working on OMAP2430 and for me with linux2.6.33, USB is
>> simply not working. Board is not even able to boot if I just
>> enable Host Support.
>

> Maybe someone on the linux-omap list would be able to help with
> this - so adding linux-omap to the cc.

> Are you using the 2430SDP or some other board? I don't think
> anyone has tried booting one of those with mainline kernels
> in a long time. Does the default config for your board work?

I am using OMAP2430SDP (4.0.1).
I started with omap_2430sdp_defconfig
As a side note, USB works fine with 2.6.14-V3 kernel taken from linux.omap.com

>Maybe we can help get this working. Can you enable CONFIG_DEBUG_LL
>and CONFIG_EARLY_PRINTK in your build, then add "earlyprintk" to
>your bootargs?

>> If there is a crash during boot-up, this will let us know.
Ok, I will do that.

>Also, do you know which transceiver you have on the board?
>(TWL4030 or ISP1504 or something else?)
No.

>> I am seeing some patches for OMAP2430 USB support since few days.
>> Anyone really tested USB on OMAP2430 hardware? Or any idea
>> whether it will work with head of linus tree or anything like that ?
>>

>I posted one such patch - to remove some pin muxing code that
>was under a CONFIG_ARCH_OMAP2430 macro - this code should not
>be in a generic driver. I did not test on an actual 2430 board
>because I don't have one.

The only intention behind asking that question was to know whether I am missing any patch which should have been applied on top of the kernel that I am using. I am using 2.6.33 (linux-2.6.33.tar.bz2).

- Anand

______________________________________________________________________

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: USB on omap2430

[Viral Mehta]

Hi,

I enabled "earlyprintk" and I have copy+pasted crashdump at the end of the email.

It is not able to get "otg_get_transceiver()" since transceiver was never set.
OMAP2430 uses ISP1301 (grepped from SDP manual).
It is on I2C1 bus and address 0x2D if I read the manual correctly.

I think it was not initialised in platform_init.
arch/arm/mach-omap2/board-3430sdp.c
========= Present Code=========
static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = {
    {
        I2C_BOARD_INFO("twl4030", 0x48),
        .flags = I2C_CLIENT_WAKE,
        .irq = INT_24XX_SYS_NIRQ,
        .platform_data = &sdp2430_twldata,
    },
};
==========================
I think it needs to be modified something like this
=============
static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = {
    {
        I2C_BOARD_INFO("twl4030", 0x48),
        .flags = I2C_CLIENT_WAKE,
        .irq = INT_24XX_SYS_NIRQ,
        .platform_data = &sdp2430_twldata,
    },
};

static struct i2c_board_info __initdata sdp2430_i2c_1_boardinfo[] = {
    { /* for camera sensor */
        I2C_BOARD_INFO("ex3691", 0x48),
/*      .flags = I2C_CLIENT_WAKE,
        .irq = INT_24XX_SYS_NIRQ,
        .platform_data = &sdp2430_twldata,*/
    },
    {
      /* for camera transceiver */
        I2C_BOARD_INFO("isp1301_omap", 0x2D),
    },

};
==========================

I think we also need to make one change in ./arch/arm/mach-omap2/Kconfig
======== Present Code ========
config ARCH_OMAP2430
    bool "OMAP2430 support"
    depends on ARCH_OMAP24XX
=====================
This should be changed to
===============
config ARCH_OMAP2430
    bool "OMAP2430 support"
    depends on ARCH_OMAP24XX
    select ARCH_OMAP_OTG
====================

The changes are not in form of "git diff" since it had lots of my other debug prints.
But, I hope this makes sense. Do let me know your comments.
=========== Crash dump with earlyprintk=========
"Switching to clocksource gp timer
musb_hdrc: version 6.0, musb-dma, host, debug=0
HS USB OTG: no transceiver configured
musb_hdrc musb_hdrc: musb_init_controller failed with status -19
Unhandled fault: imprecise external abort (0xc06) at 0x00000000
Internal error: : c06 [#1] PREEMPT
last sysfs file:
Modules linked in:
CPU: 0    Not tainted  (2.6.33 #56)
PC is at musb_platform_suspend+0x20/0x88
LR is at musb_platform_suspend+0x1c/0x88
pc : [<c01e1d44>]    lr : [<c01e1d40>]    psr: a0000013
sp : c1c19e28  ip : 22222222  fp : c03a4b9c
r10: c03a4bc0  r9 : 00000000  r8 : c03bf7a8
r7 : c03c0dd0  r6 : 00000000  r5 : c1c5e8f8  r4 : c1c5e8f8
r3 : c03a4460  r2 : c1c59608  r1 : 480ac414  r0 : fa0ac414
Flags: NzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
Control: 00c5387d  Table: 80004000  DAC: 00000017
Process swapper (pid: 1, stack limit = 0xc1c18268)
Stack: (0xc1c19e28 to 0xc1c1a000)
9e20:                   c1c5e8f8 c01e1db8 00000000 c01e0da0 ffffffed c1c5e8f8
9e40: 00000000 c001a9d0 00000005 c1c19e8c c03af81c ffffffff c03a4bb8 0000005c
9e60: fa0ac000 00000008 c1c5ba80 00000002 c1c18000 c03e34a4 00000000 c01710d8
9e80: c1c19ed4 00000000 000080d0 c1c0e7a8 00000000 60000013 00000007 60000013
9ea0: c1c000c0 c03483b8 60000013 c1c2f158 c1c18000 00000008 c1c2f158 c1c2ff98
9ec0: 00000000 c02a9208 00000000 c1c19ef8 00000000 c00ef1a8 c1c19ef8 c00eed74
9ee0: c1c2f158 c1c2ff98 c1c19ef8 00000000 c1c2ff98 c00ef8d8 c1c59608 c03a4bc0
9f00: c03a4bf4 c03c0dd0 c03c0dd0 c03bf7a8 00000000 00000000 00000000 c01b5184
9f20: c03a4bc0 c01b4288 c03a4bc0 c03a4bf4 c03c0dd0 c03c0dd0 c03bf7a8 c01b4394
9f40: 00000000 c1c19f50 c01b4334 c01b376c c1c034d8 c1c63e30 c03c0dd0 00000001
9f60: c03c0dd0 c1c5a8a0 c0019e90 c01b3cd8 c02c1d7c c02c1d7c c1c19f70 00000001
9f80: c03c0dd0 c03cd040 c0019e90 00000001 00000000 c01b4744 00000001 c03c0dbc
9fa0: c03cd040 c0019e90 00000001 00000000 00000000 c01b5514 c0021528 00000000
9fc0: c03cd040 c002736c c0019e90 c0171c98 00000000 c002173c c0021528 00000000
9fe0: 00000000 00000000 00000000 c0008868 00000000 c0028ea8 000a050a 02050d09
[<c01e1d44>] (musb_platform_suspend+0x20/0x88) from [<c01e1db8>] (musb_platform_exit+0xc/0x20)
[<c01e1db8>] (musb_platform_exit+0xc/0x20) from [<c01e0da0>] (musb_free+0x80/0xb4)
[<c01e0da0>] (musb_free+0x80/0xb4) from [<c001a9d0>] (musb_probe+0x998/0xb5c)
[<c001a9d0>] (musb_probe+0x998/0xb5c) from [<c01b5184>] (platform_drv_probe+0x18/0x1c)
[<c01b5184>] (platform_drv_probe+0x18/0x1c) from [<c01b4288>] (driver_probe_device+0xa0/0x14c)
[<c01b4288>] (driver_probe_device+0xa0/0x14c) from [<c01b4394>] (__driver_attach+0x60/0x84)
[<c01b4394>] (__driver_attach+0x60/0x84) from [<c01b376c>] (bus_for_each_dev+0x44/0x78)
[<c01b376c>] (bus_for_each_dev+0x44/0x78) from [<c01b3cd8>] (bus_add_driver+0x9c/0x228)
[<c01b3cd8>] (bus_add_driver+0x9c/0x228) from [<c01b4744>] (driver_register+0xa8/0x130)
[<c01b4744>] (driver_register+0xa8/0x130) from [<c01b5514>] (platform_driver_probe+0x18/0x98)
[<c01b5514>] (platform_driver_probe+0x18/0x98) from [<c002736c>] (do_one_initcall+0x54/0x190)
[<c002736c>] (do_one_initcall+0x54/0x190) from [<c0008868>] (kernel_init+0xa0/0x120)
[<c0008868>] (kernel_init+0xa0/0x120) from [<c0028ea8>] (kernel_thread_exit+0x0/0x8)
Code: 0a000018 e59f0064 ebf961d8 e59f105c (e3800001)
---[ end trace 1b75b31a2719ed1c ]---
"
________________________________________
From: Viral Mehta
Sent: Wednesday, March 24, 2010 3:06 PM
To: Gadiyar, Anand; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: USB on omap2430

________________________________________
From: Gadiyar, Anand [gadiyar-l0cyMroinI0@public.gmane.org]
Sent: Wednesday, March 24, 2010 2:46 PM
To: Viral Mehta; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: USB on omap2430

Viral Mehta wrote:
>>
>> I am working on OMAP2430 and for me with linux2.6.33, USB is
>> simply not working. Board is not even able to boot if I just
>> enable Host Support.
>

> Maybe someone on the linux-omap list would be able to help with
> this - so adding linux-omap to the cc.

> Are you using the 2430SDP or some other board? I don't think
> anyone has tried booting one of those with mainline kernels
> in a long time. Does the default config for your board work?

I am using OMAP2430SDP (4.0.1).
I started with omap_2430sdp_defconfig
As a side note, USB works fine with 2.6.14-V3 kernel taken from linux.omap.com

>Maybe we can help get this working. Can you enable CONFIG_DEBUG_LL
>and CONFIG_EARLY_PRINTK in your build, then add "earlyprintk" to
>your bootargs?

>> If there is a crash during boot-up, this will let us know.
Ok, I will do that.

>Also, do you know which transceiver you have on the board?
>(TWL4030 or ISP1504 or something else?)
No.

>> I am seeing some patches for OMAP2430 USB support since few days.
>> Anyone really tested USB on OMAP2430 hardware? Or any idea
>> whether it will work with head of linus tree or anything like that ?
>>

>I posted one such patch - to remove some pin muxing code that
>was under a CONFIG_ARCH_OMAP2430 macro - this code should not
>be in a generic driver. I did not test on an actual 2430 board
>because I don't have one.

The only intention behind asking that question was to know whether I am missing any patch which should have been applied on top of the kernel that I am using. I am using 2.6.33 (linux-2.6.33.tar.bz2).

- Anand

______________________________________________________________________

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: USB on omap2430

[Felipe Balbi]

Hi,

On Fri, 26 Mar 2010 16:38:11 +0530, Viral Mehta
<Viral.Mehta-oonXi/34qI7c+919tysfdA@public.gmane.org> wrote:
> Hi,
> 
> I enabled "earlyprintk" and I have copy+pasted crashdump at the end of
the
> email.
> 
> It is not able to get "otg_get_transceiver()" since transceiver was
never
> set.
> OMAP2430 uses ISP1301 (grepped from SDP manual).
> It is on I2C1 bus and address 0x2D if I read the manual correctly.
> 
> I think it was not initialised in platform_init.
> arch/arm/mach-omap2/board-3430sdp.c
> ========= Present Code=========
> static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = {
>     {
>         I2C_BOARD_INFO("twl4030", 0x48),
>         .flags = I2C_CLIENT_WAKE,
>         .irq = INT_24XX_SYS_NIRQ,
>         .platform_data = &sdp2430_twldata,
>     },
> };
> ==========================
> I think it needs to be modified something like this
> =============
> static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = {
>     {
>         I2C_BOARD_INFO("twl4030", 0x48),
>         .flags = I2C_CLIENT_WAKE,
>         .irq = INT_24XX_SYS_NIRQ,
>         .platform_data = &sdp2430_twldata,
>     },
> };
> 
> static struct i2c_board_info __initdata sdp2430_i2c_1_boardinfo[] = {
>     { /* for camera sensor */
>         I2C_BOARD_INFO("ex3691", 0x48),
> /*      .flags = I2C_CLIENT_WAKE,
>         .irq = INT_24XX_SYS_NIRQ,
>         .platform_data = &sdp2430_twldata,*/
>     },
>     {
>       /* for camera transceiver */
>         I2C_BOARD_INFO("isp1301_omap", 0x2D),
>     },
> 
> };
> ==========================
> 
> I think we also need to make one change in ./arch/arm/mach-omap2/Kconfig
> ======== Present Code ========
> config ARCH_OMAP2430
>     bool "OMAP2430 support"
>     depends on ARCH_OMAP24XX
> =====================
> This should be changed to
> ===============
> config ARCH_OMAP2430
>     bool "OMAP2430 support"
>     depends on ARCH_OMAP24XX
>     select ARCH_OMAP_OTG
> ====================
> 
> The changes are not in form of "git diff" since it had lots of my other
> debug prints.
> But, I hope this makes sense. Do let me know your comments.
> =========== Crash dump with earlyprintk=========
> "Switching to clocksource gp timer
> musb_hdrc: version 6.0, musb-dma, host, debug=0
> HS USB OTG: no transceiver configured
> musb_hdrc musb_hdrc: musb_init_controller failed with status -19
> Unhandled fault: imprecise external abort (0xc06) at 0x00000000
> Internal error: : c06 [#1] PREEMPT
> last sysfs file:
> Modules linked in:
> CPU: 0    Not tainted  (2.6.33 #56)
> PC is at musb_platform_suspend+0x20/0x88
> LR is at musb_platform_suspend+0x1c/0x88
> pc : [<c01e1d44>]    lr : [<c01e1d40>]    psr: a0000013
> sp : c1c19e28  ip : 22222222  fp : c03a4b9c
> r10: c03a4bc0  r9 : 00000000  r8 : c03bf7a8
> r7 : c03c0dd0  r6 : 00000000  r5 : c1c5e8f8  r4 : c1c5e8f8
> r3 : c03a4460  r2 : c1c59608  r1 : 480ac414  r0 : fa0ac414
> Flags: NzCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
> Control: 00c5387d  Table: 80004000  DAC: 00000017
> Process swapper (pid: 1, stack limit = 0xc1c18268)
> Stack: (0xc1c19e28 to 0xc1c1a000)
> 9e20:                   c1c5e8f8 c01e1db8 00000000 c01e0da0 ffffffed
> c1c5e8f8
> 9e40: 00000000 c001a9d0 00000005 c1c19e8c c03af81c ffffffff c03a4bb8
> 0000005c
> 9e60: fa0ac000 00000008 c1c5ba80 00000002 c1c18000 c03e34a4 00000000
> c01710d8
> 9e80: c1c19ed4 00000000 000080d0 c1c0e7a8 00000000 60000013 00000007
> 60000013
> 9ea0: c1c000c0 c03483b8 60000013 c1c2f158 c1c18000 00000008 c1c2f158
> c1c2ff98
> 9ec0: 00000000 c02a9208 00000000 c1c19ef8 00000000 c00ef1a8 c1c19ef8
> c00eed74
> 9ee0: c1c2f158 c1c2ff98 c1c19ef8 00000000 c1c2ff98 c00ef8d8 c1c59608
> c03a4bc0
> 9f00: c03a4bf4 c03c0dd0 c03c0dd0 c03bf7a8 00000000 00000000 00000000
> c01b5184
> 9f20: c03a4bc0 c01b4288 c03a4bc0 c03a4bf4 c03c0dd0 c03c0dd0 c03bf7a8
> c01b4394
> 9f40: 00000000 c1c19f50 c01b4334 c01b376c c1c034d8 c1c63e30 c03c0dd0
> 00000001
> 9f60: c03c0dd0 c1c5a8a0 c0019e90 c01b3cd8 c02c1d7c c02c1d7c c1c19f70
> 00000001
> 9f80: c03c0dd0 c03cd040 c0019e90 00000001 00000000 c01b4744 00000001
> c03c0dbc
> 9fa0: c03cd040 c0019e90 00000001 00000000 00000000 c01b5514 c0021528
> 00000000
> 9fc0: c03cd040 c002736c c0019e90 c0171c98 00000000 c002173c c0021528
> 00000000
> 9fe0: 00000000 00000000 00000000 c0008868 00000000 c0028ea8 000a050a
> 02050d09
> [<c01e1d44>] (musb_platform_suspend+0x20/0x88) from [<c01e1db8>]
> (musb_platform_exit+0xc/0x20)

to me it sounds like you don't have a transceiver. Can you do the
following:

1. arm-linux-gdb vmlinux (with the same kernel image you reproduce the
crash)
2. (gdb) l *(musb_platform_suspend + 0x20)

it should show you the source code and the line number from
where the NULL pointer comes

ps: please read http://elinux.org/Netiquette

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: USB on omap2430

[Felipe Balbi]

Hi,

On Fri, Mar 26, 2010 at 06:44:16PM +0100, ext Felipe Balbi wrote:
>to me it sounds like you don't have a transceiver. Can you do the
>following:
>
>1. arm-linux-gdb vmlinux (with the same kernel image you reproduce the
>crash)
>2. (gdb) l *(musb_platform_suspend + 0x20)
>
>it should show you the source code and the line number from
>where the NULL pointer comes
>
>ps: please read http://elinux.org/Netiquette

any news on this ?

-- 
balbi

RE: USB on omap2430

[Viral Mehta]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1368 bytes --]


>
> to me it sounds like you don't have a transceiver. Can you do the
> following:

I thought when you said transceiver is not present, you meant that transceiver as
HW (or chip) is not present. So again I took 2.6.14-V3 kernel code from http://linux.omap.com
and tested that. With that kernel version USB works fine and thus transceiver is present.

>
> 1. arm-linux-gdb vmlinux (with the same kernel image you reproduce the
> crash)
> 2. (gdb) l *(musb_platform_suspend + 0x20)
>
> it should show you the source code and the line number from
> where the NULL pointer comes

I did that but uImage had not symbol information and thus it did not give exact information.
But, I was sure that "otg_get_transceiver()" was failed and had returned NULL.
And I was debugging further in that line.

>
> ps: please read http://elinux.org/Netiquette
>
> --
> balbi
>
> ______________________________________________________________________

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±ºÆâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&¢îý»\x05ËÛÔØï¦v¬Îf\x1dp)¹¹br	šê+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹\x1e®w¥¢¸?™¨è­Ú&¢)ߢ^[f

RE: USB on omap2430

[Felipe Balbi]

On Tue, 30 Mar 2010 10:07:30 +0530, Viral Mehta
<Viral.Mehta@lntinfotech.com> wrote:
>>
>> to me it sounds like you don't have a transceiver. Can you do the
>> following:
> 
> I thought when you said transceiver is not present, you meant that
> transceiver as
> HW (or chip) is not present. 

I meant the driver :-)

>> 1. arm-linux-gdb vmlinux (with the same kernel image you reproduce the
>> crash)
>> 2. (gdb) l *(musb_platform_suspend + 0x20)
>>
>> it should show you the source code and the line number from
>> where the NULL pointer comes
> 
> I did that but uImage had not symbol information and thus it did not
give
> exact information.

that's why I used vmlinux, see the command up there ?

-- 
balbi

Re: USB on omap2430

[Felipe Balbi]

Hi again,

On Fri, Mar 26, 2010 at 12:08:11PM +0100, ext Viral Mehta wrote:
>I enabled "earlyprintk" and I have copy+pasted crashdump at the end of the email.
>
>It is not able to get "otg_get_transceiver()" since transceiver was never set.
>OMAP2430 uses ISP1301 (grepped from SDP manual).
>It is on I2C1 bus and address 0x2D if I read the manual correctly.

isp1301 ?? there's a driver for that on drivers/usb/otg/isp1301_omap.c

enable that and check if it works. You should add something like the 
following to your board file:

diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
index 01d113f..910234d 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -172,6 +172,11 @@ static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = {
  		.irq = INT_24XX_SYS_NIRQ,
  		.platform_data = &sdp2430_twldata,
  	},
+	{
+		I2C_BOARD_INFO("isp1301-omap", 0x2d),
+		.flags = I2C_CLIENT_WAKE,
+		.irq = /* irq line here */,
+	},
  };
  
  static int __init omap2430_i2c_init(void)

I didn't even compile tested... you will probably need the schematics to 
figure out to which i2c bus isp1301 is connected.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: USB on omap2430

[Viral Mehta]

> >It is not able to get "otg_get_transceiver()" since transceiver was
> never set.
> >OMAP2430 uses ISP1301 (grepped from SDP manual).
> >It is on I2C1 bus and address 0x2D if I read the manual correctly.
>
> isp1301 ?? there's a driver for that on drivers/usb/otg/isp1301_omap.c
>
> enable that and check if it works. You should add something like the
> following to your board file:
>
> diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-
> omap2/board-2430sdp.c
> index 01d113f..910234d 100644
> --- a/arch/arm/mach-omap2/board-2430sdp.c
> +++ b/arch/arm/mach-omap2/board-2430sdp.c
> @@ -172,6 +172,11 @@ static struct i2c_board_info __initdata
> sdp2430_i2c_boardinfo[] = {
>               .irq = INT_24XX_SYS_NIRQ,
>               .platform_data = &sdp2430_twldata,
>       },
> +     {
> +             I2C_BOARD_INFO("isp1301-omap", 0x2d),
> +             .flags = I2C_CLIENT_WAKE,
> +             .irq = /* irq line here */,
> +     },
>   };
>

Yes, that's true.....
Here is a tested diff.

--- arch/arm/mach-omap2/board-2430sdp.org.c     2010-03-30 10:16:30.889813408 +0530
+++ arch/arm/mach-omap2/board-2430sdp.c 2010-03-26 16:13:56.043470674 +0530
@@ -174,7 +174,25 @@ static struct i2c_board_info __initdata
        },
 };

+static struct i2c_board_info __initdata sdp2430_i2c_1_boardinfo[] = {
+       {
+               I2C_BOARD_INFO("ex3691", 0x48),
+/*             .flags = I2C_CLIENT_WAKE,
+               .irq = INT_24XX_SYS_NIRQ,
+               .platform_data = &sdp2430_twldata,*/
+       },
+       {
+               I2C_BOARD_INFO("isp1301_omap", 0x2D),
+       },
+
+};
+
+
 static int __init omap2430_i2c_init(void)
+{
+       omap_register_i2c_bus(1, 400, sdp2430_i2c_1_boardinfo,
+                       ARRAY_SIZE(sdp2430_i2c_1_boardinfo));
+       printk("i2c bus 1 registerd \n");
        omap_register_i2c_bus(2, 2600, sdp2430_i2c_boardinfo,
                        ARRAY_SIZE(sdp2430_i2c_boardinfo));
        return 0;
--- ./drivers/usb/otg/isp1301_omap.org.c        2010-03-30 10:19:18.446765963 +0530
+++ ./drivers/usb/otg/isp1301_omap.c    2010-03-30 10:18:50.985767665 +0530
@@ -1659,7 +1659,8 @@ static int __init isp_init(void)
        printk("============ init ISP\n");
        return i2c_add_driver(&isp1301_driver);
 }
-module_init(isp_init);
+//module_init(isp_init);
+subsys_initcall(isp_init);

 static void __exit isp_exit(void)
 {



After adding the above code, isp1301's probe is called but that fails before it does otg_set_transceiver()
And I am debugging further on that path.

>   static int __init omap2430_i2c_init(void)
>
> I didn't even compile tested... you will probably need the schematics
> to
> figure out to which i2c bus isp1301 is connected.
>
> --
> balbi
>

Ps, and please bare with me for few things. The mail-server will again append that notice but should be ignored.
The whole problem is I don't have control over few things. I have to use outlook express only and things like that.
Probably will shift to my gmail address but till then I don't know but pardon me.

> ______________________________________________________________________

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________

RE: USB on omap2430

[Felipe Balbi]

Hi,

On Tue, 30 Mar 2010 10:24:32 +0530, Viral Mehta
> +static struct i2c_board_info __initdata sdp2430_i2c_1_boardinfo[] = {
> +       {
> +               I2C_BOARD_INFO("ex3691", 0x48),
> +/*             .flags = I2C_CLIENT_WAKE,
> +               .irq = INT_24XX_SYS_NIRQ,
> +               .platform_data = &sdp2430_twldata,*/
> +       },
> +       {
> +               I2C_BOARD_INFO("isp1301_omap", 0x2D),
> +       },

you should send only what relates to the isp1301 change :-)

>  static int __init omap2430_i2c_init(void)
> +{
> +       omap_register_i2c_bus(1, 400, sdp2430_i2c_1_boardinfo,
> +                       ARRAY_SIZE(sdp2430_i2c_1_boardinfo));
> +       printk("i2c bus 1 registerd \n");
>         omap_register_i2c_bus(2, 2600, sdp2430_i2c_boardinfo,
>                         ARRAY_SIZE(sdp2430_i2c_boardinfo));
>         return 0;
> --- ./drivers/usb/otg/isp1301_omap.org.c        2010-03-30
> 10:19:18.446765963 +0530
> +++ ./drivers/usb/otg/isp1301_omap.c    2010-03-30 10:18:50.985767665
+0530
> @@ -1659,7 +1659,8 @@ static int __init isp_init(void)
>         printk("============ init ISP\n");

remove the printks

>         return i2c_add_driver(&isp1301_driver);
>  }
> -module_init(isp_init);
> +//module_init(isp_init);
> +subsys_initcall(isp_init);

this should be one patch of its own.

>  static void __exit isp_exit(void)
>  {
> 
> 
> 
> After adding the above code, isp1301's probe is called but that fails
> before it does otg_set_transceiver()
> And I am debugging further on that path.

ok, cool. When you get that done, please send a cleaned up
diff with your signed-off-by line so it can be integrated.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: USB on omap2430

[Viral Mehta]

Hi,

>>  static void __exit isp_exit(void)
>>  {
>>
>>
>>
>> After adding the above code, isp1301's probe is called but that fails
>> before it does otg_set_transceiver()
>> And I am debugging further on that path.

>ok, cool. When you get that done, please send a cleaned up
>diff with your signed-off-by line so it can be integrated.

I continued debugging further. It fails during USB initialisation.
More specifically, in omap_otg_init() function in arch/arm/plat-omap/usb.c
It gives a crash dump on the first line itself
syscon = omap_readl(OTG_SYSCON_1) & 0xffff;

I feel like I need to make some board (OMAP2430) specific changes to this file.
I am not able to progress further. Any pointers will be appreciated.

Apart from that, can I submit the 3 patches that we discussed earlier ?
(http://www.mail-archive.com/linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg25932.html)
These will not make FS USB functional on OMAP2430 but these changes are anyway necessary.

--
Viral


http://www.mail-archive.com/linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg25932.html

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: USB on omap2430

[Felipe Balbi]

Hi,

On Mon, Apr 05, 2010 at 07:32:06PM +0530, Viral Mehta wrote:
> >>  static void __exit isp_exit(void)
> >>  {
> >>
> >>
> >>
> >> After adding the above code, isp1301's probe is called but that fails
> >> before it does otg_set_transceiver()
> >> And I am debugging further on that path.
> 
> >ok, cool. When you get that done, please send a cleaned up
> >diff with your signed-off-by line so it can be integrated.
> 
> I continued debugging further. It fails during USB initialisation.
> More specifically, in omap_otg_init() function in arch/arm/plat-omap/usb.c
> It gives a crash dump on the first line itself
> syscon = omap_readl(OTG_SYSCON_1) & 0xffff;

without the crash itself, it's pretty difficult to help. It could even
be just a missing clk_enable(). Although I believe that code shouldn't
be running for 2430, only for 2420.

Can you try the patch below:

> Apart from that, can I submit the 3 patches that we discussed earlier ?
> (http://www.mail-archive.com/linux-omap@vger.kernel.org/msg25932.html)
> These will not make FS USB functional on OMAP2430 but these changes are anyway necessary.

clean those patches first. And I'd like someone else with the 2430sdp
board to test it before I add my SOB.

-- 
balbi

Re: USB on omap2430

[Felipe Balbi]

On Mon, Apr 05, 2010 at 07:41:25PM +0300, Felipe Balbi wrote:
> Hi,
> 
> On Mon, Apr 05, 2010 at 07:32:06PM +0530, Viral Mehta wrote:
> > >>  static void __exit isp_exit(void)
> > >>  {
> > >>
> > >>
> > >>
> > >> After adding the above code, isp1301's probe is called but that fails
> > >> before it does otg_set_transceiver()
> > >> And I am debugging further on that path.
> > 
> > >ok, cool. When you get that done, please send a cleaned up
> > >diff with your signed-off-by line so it can be integrated.
> > 
> > I continued debugging further. It fails during USB initialisation.
> > More specifically, in omap_otg_init() function in arch/arm/plat-omap/usb.c
> > It gives a crash dump on the first line itself
> > syscon = omap_readl(OTG_SYSCON_1) & 0xffff;
> 
> without the crash itself, it's pretty difficult to help. It could even
> be just a missing clk_enable(). Although I believe that code shouldn't
> be running for 2430, only for 2420.
> 
> Can you try the patch below:

now with patch:

diff --git a/arch/arm/plat-omap/usb.c b/arch/arm/plat-omap/usb.c
index d3bf17c..e9c6452 100644
--- a/arch/arm/plat-omap/usb.c
+++ b/arch/arm/plat-omap/usb.c
@@ -745,7 +745,7 @@ static inline void omap_1510_usb_init(struct
		omap_usb_config *config) {}

void __init omap_usb_init(struct omap_usb_config *pdata)
{
-       if (cpu_is_omap7xx() || cpu_is_omap16xx() || cpu_is_omap24xx())
+       if (cpu_is_omap7xx() || cpu_is_omap16xx() || cpu_is_omap242x())
 		omap_otg_init(pdata);
 	else if (cpu_is_omap15xx())
 		omap_1510_usb_init(pdata);
-- 
balbi

RE: USB on omap2430

[Gadiyar, Anand]

Felipe Balbi wrote:
> On Mon, Apr 05, 2010 at 07:32:06PM +0530, Viral Mehta wrote:
> > >> After adding the above code, isp1301's probe is called but that fails
> > >> before it does otg_set_transceiver()
> > >> And I am debugging further on that path.
> > 
> > >ok, cool. When you get that done, please send a cleaned up
> > >diff with your signed-off-by line so it can be integrated.
> > 
> > I continued debugging further. It fails during USB initialisation.
> > More specifically, in omap_otg_init() function in arch/arm/plat-omap/usb.c
> > It gives a crash dump on the first line itself
> > syscon = omap_readl(OTG_SYSCON_1) & 0xffff;
> 
> without the crash itself, it's pretty difficult to help. It could even
> be just a missing clk_enable(). Although I believe that code shouldn't
> be running for 2430, only for 2420.
> 
> Can you try the patch below:
> 
> > Apart from that, can I submit the 3 patches that we discussed earlier ?
> > 
> (http://www.mail-archive.com/linux-omap@vger.kernel.org/msg25932.html)
> > These will not make FS USB functional on OMAP2430 but these changes are anyway necessary.
> 
> clean those patches first. And I'd like someone else with the 2430sdp
> board to test it before I add my SOB.

I dug up a 2430 board (VG5.0.1 - a later version than Viral's) , but
these patches don't work for me.

I also found the board schematics. Looks like there are different
versions of the 2430 SDP, each with different layouts and components
for the USBtransceivers. I believe there's no one-size fits all.

I think the best bet is to go with Viral's patch series, as long as they
work for him - don't think anyone else is using the 2430SDP these days.

We can fix up as and when required.

- Anand

RE: USB on omap2430

[Viral Mehta]

>On Fri, Mar 26, 2010 at 12:08:11PM +0100, ext Viral Mehta wrote:
>>I enabled "earlyprintk" and I have copy+pasted crashdump at the end of the email.
>>
>>It is not able to get "otg_get_transceiver()" since transceiver was never set.
>>OMAP2430 uses ISP1301 (grepped from SDP manual).
>>It is on I2C1 bus and address 0x2D if I read the manual correctly.

>isp1301 ?? there's a driver for that on drivers/usb/otg/isp1301_omap.c

Again I think I should be clear on that,
On OMAP2430, isp1301 transceiver is used for FS USB (or OHCI) only.
For HS USB (or musb) the transceiver used is Triton T2.

And currently I am debugging FS USB only. Sorry if earlier mail created confusion.
--
Viral

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________