From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance. Date: Tue, 6 Apr 2010 08:00:36 +0300 Message-ID: <20100406050035.GA32537@gandalf> References: <004701caab40$68b576e0$544ff780@am.dhcp.ti.com> <003b01cad0f0$6ea78040$544ff780@am.dhcp.ti.com> <003c01cad1b1$da2cdbf0$544ff780@am.dhcp.ti.com> <20100405164839.GB17388@gandalf> <007c01cad4e4$26c5a700$544ff780@am.dhcp.ti.com> Reply-To: me@felipebalbi.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns1.siteground211.com ([209.62.36.12]:54379 "EHLO serv01.siteground211.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999Ab0DFE77 (ORCPT ); Tue, 6 Apr 2010 00:59:59 -0400 Content-Disposition: inline In-Reply-To: <007c01cad4e4$26c5a700$544ff780@am.dhcp.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Madhusudhan Cc: me@felipebalbi.com, 'kishore kadiyala' , 'Vimal Singh' , tony@atomide.com, svenkatr@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, jarkko.lavinen@nokia.com Hi, On Mon, Apr 05, 2010 at 12:19:29PM -0500, Madhusudhan wrote: > Since the first if command already checks for the 8-bit the second check > like >= 4 is definitely not readable in my opinion. how come ??? > Functionally do you see anything wrong with this patch?? functionally no, but (hypothetical situation) and if on omap4/5/6/whatever, omap controller supports a bigger bus width then you'll have to add a line like: + if (mmc_slot(host).wires == 16) + mmc->caps |= (MMC_CAP_16_BIT_DATA | MMC_CAP_8_BIT_DATA | + MMC_CAP_4_BIT_DATA); - if (mmc_slot(host).wires == 8) + else if (mmc_slot(host).wires == 8) do you see the problem ?? In my opinion it doesn't scale well. -- balbi