From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"Arce, Abraham" <x0066660@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: OMAP4 keypad driver
Date: Thu, 8 Apr 2010 08:50:19 +0300 [thread overview]
Message-ID: <20100408055019.GA23541@nokia.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02C4D0F36C@dbde02.ent.ti.com>
On Thu, Apr 08, 2010 at 07:43:44AM +0200, ext Shilimkar, Santosh wrote:
>> -----Original Message-----
>> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Felipe
>> Balbi
>> Sent: Thursday, April 08, 2010 10:12 AM
>> To: Arce, Abraham
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: OMAP4 keypad driver
>>
>> On Thu, Apr 08, 2010 at 03:16:08AM +0200, ext Arce, Abraham wrote:
>> >Hi,
>> >
>> >I need some help to figure out the best way to incorporate omap4 keypad in linux omap.
>> >
>> >First approach, I have a patch that creates a new file, omap4-keypad.c with the following
>> implementations:
>> >
>> > - Based on matrix keypac logic
>> > - Using hwmod framework
>> > - Using threaded irq
>> >
>> >Second approach, to change existing omap-keypad.c to matrix keypad
>> >
>> >Not clear on the path to follow... Thanks for your comments.
>>
>> isn't that part of the twl6030 pmic ? If so you need a better name for
>> it, something like twl6030-keypad.c
>>
>It's not. OMAP4 has it's own keyboard controller embedded.
then why do you use threaded_irq ? If omap4 has its own keypad
controller, then sure it's memory-mapped, no ? Well, please send the
driver and we can comment further :-p
--
balbi
next prev parent reply other threads:[~2010-04-08 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 1:16 OMAP4 keypad driver Arce, Abraham
2010-04-08 4:42 ` Felipe Balbi
2010-04-08 5:43 ` Shilimkar, Santosh
2010-04-08 5:50 ` Felipe Balbi [this message]
2010-04-08 5:56 ` Shilimkar, Santosh
2010-04-08 15:21 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100408055019.GA23541@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox