[PATCH] omap: Add I2C bus 1 initialisation

[PATCH] omap: Add I2C bus 1 initialisation

[viral.mehta]

From: Viral Mehta <viral.mehta@lntinfotech.com>

Initialize isp1301 FS USB transceiver and
add I2C bus1 initialization code for OMAP2430 SDP

Signed-off-by: Viral Mehta <viral.mehta@lntinfotech.com>
---
 arch/arm/mach-omap2/board-2430sdp.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/board-2430sdp.c b/arch/arm/mach-omap2/board-2430sdp.c
index 01d113f..346e1d2 100644
--- a/arch/arm/mach-omap2/board-2430sdp.c
+++ b/arch/arm/mach-omap2/board-2430sdp.c
@@ -174,9 +174,17 @@ static struct i2c_board_info __initdata sdp2430_i2c_boardinfo[] = {
        },
 };

+static struct i2c_board_info __initdata sdp2430_i2c1_boardinfo[] = {
+       {
+               I2C_BOARD_INFO("isp1301_omap", 0x2D),
+               .flags = I2C_CLIENT_WAKE,
+               .irq = OMAP_GPIO_IRQ(78),
+       },
+}
 static int __init omap2430_i2c_init(void)
 {
-       omap_register_i2c_bus(1, 400, NULL, 0);
+       omap_register_i2c_bus(1, 100, sdp2430_i2c1_boardinfo,
+                       ARRAY_SIZE(sdp2430_i2c1_boardinfo));
        omap_register_i2c_bus(2, 2600, sdp2430_i2c_boardinfo,
                        ARRAY_SIZE(sdp2430_i2c_boardinfo));
        return 0;
--
1.6.6


This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________

Re: [PATCH] omap: Add I2C bus 1 initialisation

[Felipe Balbi]

On Mon, Apr 12, 2010 at 06:31:44AM +0200, ext viral.mehta@lntinfotech.com wrote:
> static int __init omap2430_i2c_init(void)
> {
>-       omap_register_i2c_bus(1, 400, NULL, 0);
>+       omap_register_i2c_bus(1, 100, sdp2430_i2c1_boardinfo,
>+                       ARRAY_SIZE(sdp2430_i2c1_boardinfo));

why do you decrease bus frequency ?

-- 
balbi

RE: [PATCH] omap: Add I2C bus 1 initialisation

[Maulik]

> +static struct i2c_board_info __initdata sdp2430_i2c1_boardinfo[] = {
> +       {
> +               I2C_BOARD_INFO("isp1301_omap", 0x2D),
> +               .flags = I2C_CLIENT_WAKE,
> +               .irq = OMAP_GPIO_IRQ(78),
> +       },
> +}

Use tabs instead of spaces. 

>  static int __init omap2430_i2c_init(void)
>  {
> -       omap_register_i2c_bus(1, 400, NULL, 0);
> +       omap_register_i2c_bus(1, 100, sdp2430_i2c1_boardinfo,
> +                       ARRAY_SIZE(sdp2430_i2c1_boardinfo));

Same here.

Maulik

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] omap: Add I2C bus 1 initialisation

[Viral Mehta]

>On Mon, Apr 12, 2010 at 06:31:44AM +0200, ext viral.mehta@lntinfotech.com wrote:
>> static int __init omap2430_i2c_init(void)
>> {
>>-       omap_register_i2c_bus(1, 400, NULL, 0);
>>+       omap_register_i2c_bus(1, 100, sdp2430_i2c1_boardinfo,
>>+                       ARRAY_SIZE(sdp2430_i2c1_boardinfo));

>why do you decrease bus frequency ?

1. This works for me.
2. I took refernce from http://linux.omap.com/pub/kernel/2430sdp/source/linux-2.6.14-omap2-v3.tgz
It uses same clock rate, this kernel is again fully working on OMAP2430 sdp board.
3. setting bus0 speed to 100 is Standard Mode and 400 is Fast Mode, may be working on fast mode is requiring some another changes which I am not aware of.
4. Sorry, dont have access to all HW manuals so that I can clearly point out about clk rate/bus speed data and settings.

--
Viral

______________________________________________________________________

This Email may contain confidential or privileged information for the intended recipient (s) If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

______________________________________________________________________