From: Tony Lindgren <tony@atomide.com>
To: "Kanigeri, Hari" <h-kanigeri2@ti.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Subject: Re: [PATCH 1/3][v2] OMAP:iommu support for OMAP4
Date: Wed, 21 Apr 2010 15:00:05 -0700 [thread overview]
Message-ID: <20100421220004.GO18272@atomide.com> (raw)
In-Reply-To: <8F7AF80515AF0D4D93307E594F3CB40E4B3BF8B8@dlee03.ent.ti.com>
* Kanigeri, Hari <h-kanigeri2@ti.com> [100420 15:03]:
> Felipe,
>
> > -----Original Message-----
> > From: Felipe Contreras [mailto:felipe.contreras@gmail.com]
> > Sent: Tuesday, April 20, 2010 4:49 PM
> > To: Kanigeri, Hari
> > Cc: linux-omap@vger.kernel.org; Shilimkar, Santosh; Hiroshi DOYU;
> > tony@atomide.com
> > Subject: Re: [PATCH 1/3][v2] OMAP:iommu support for OMAP4
> >
> > On Wed, Apr 21, 2010 at 12:31 AM, Kanigeri, Hari <h-kanigeri2@ti.com>
> > wrote:
> > > From 9a6f91b0c108fd010afdb6bddcae92579c87fcbd Mon Sep 17 00:00:00 2001
> > > From: Hari Kanigeri <h-kanigeri2@ti.com>
> > > Date: Tue, 20 Apr 2010 12:03:03 -0500
> > > Subject: [PATCH 1/3] OMAP:iommu support for OMAP4
> > >
> > > This patch provides the iommu support for OMAP4 co-processors.
> > > This includes changes to omap3-iommu.c file to make it generic
> > > for all OMAPs. Renamed omap3-iommu.c to omap-iommu.c
> >
> > This smells like two patches: one that moves omap3-iommu to
> > omap-iommu, and another one that adds omap4 support.
> >
> > But unfortunately this would break multi-omap support. I think both
> > omap3 and omap4 devices should be there, and selected at run-time.
> >
>
> -- I am not sure as why this would break multi-omap support. We would select either OMAP3 or OMAP4 specific structures at compile time based on the platform selected, and rest of the code is same for both OMAP3/4.
We can compile and boot omap2 + omap3 + omap4 with the same
kernel, see omap3_defconfig.
Tony
next prev parent reply other threads:[~2010-04-21 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 21:31 [PATCH 1/3][v2] OMAP:iommu support for OMAP4 Kanigeri, Hari
2010-04-20 21:48 ` Felipe Contreras
2010-04-20 22:07 ` Kanigeri, Hari
2010-04-21 22:00 ` Tony Lindgren [this message]
2010-04-20 22:23 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100421220004.GO18272@atomide.com \
--to=tony@atomide.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=felipe.contreras@gmail.com \
--cc=h-kanigeri2@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox