Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Kanigeri, Hari" <h-kanigeri2@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Subject: Re: [PATCH 2/4][v3] OMAP:iommu support for OMAP4
Date: Wed, 21 Apr 2010 15:04:49 -0700	[thread overview]
Message-ID: <20100421220449.GP18272@atomide.com> (raw)
In-Reply-To: <8F7AF80515AF0D4D93307E594F3CB40E4B3BF951@dlee03.ent.ti.com>

* Kanigeri, Hari <h-kanigeri2@ti.com> [100420 15:52]:
> From 9a2bcae7a2de6890884c23c45563eece1e6838de Mon Sep 17 00:00:00 2001
> From: Hari Kanigeri <h-kanigeri2@ti.com>
> Date: Tue, 20 Apr 2010 17:39:18 -0500
> Subject: [PATCH 2/4] OMAP:iommu support for OMAP4
> 
> This patch provides the iommu support for OMAP4 co-processors.
> 
> Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
> ---
>  arch/arm/mach-omap2/omap-iommu.c           |   26 ++++++++++++++++++++++++++
>  arch/arm/plat-omap/include/plat/omap44xx.h |    3 +++
>  2 files changed, 29 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/omap-iommu.c b/arch/arm/mach-omap2/omap-iommu.c
> index 416a65d..f569371 100644
> --- a/arch/arm/mach-omap2/omap-iommu.c
> +++ b/arch/arm/mach-omap2/omap-iommu.c
> @@ -13,6 +13,7 @@
>  #include <linux/platform_device.h>
>  
>  #include <plat/iommu.h>
> +#include <plat/irqs.h>
>  
>  struct iommu_device {
>  	resource_size_t base;
> @@ -46,6 +47,31 @@ static struct iommu_device devices[] = {
>  };
>  #endif
>  
> +#ifdef CONFIG_ARCH_OMAP4
> +static struct iommu_device devices[] = {
> +	{
> +		.base = OMAP4_MMU1_BASE,
> +		.irq = INT_44XX_DUCATI_MMU_IRQ,
> +		.pdata = {
> +			.name = "ducati",
> +			.nr_tlb_entries = 32,
> +			.clk_name = "ducati_ick",
> +		},
> +	},
> +#if defined(CONFIG_MPU_TESLA_IOMMU)
> +	{
> +		.base = OMAP4_MMU2_BASE,
> +		.irq = INT_44XX_DSP_MMU,
> +		.pdata = {
> +			.name = "tesla",
> +			.nr_tlb_entries = 32,
> +			.clk_name = "tesla_ick",
> +		},
> +	},
> +#endif
> +};
> +#endif

This should use:

static struct iommu_device *devices;

#ifdef CONFIG_ARCH_OMAP3
static struct iommu_device omap3_devices[] = {
...
#else
#define omap3_devices	NULL
#endif

#ifdef CONFIG_ARCH_OMAP4
static struct iommu_device omap4_devices[] = {
...
#else
#define omap4_devices	NULL
#endif

Then in init, just set devices based on the omap type.

Tony


  reply	other threads:[~2010-04-21 22:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 22:56 [PATCH 2/4][v3] OMAP:iommu support for OMAP4 Kanigeri, Hari
2010-04-21 22:04 ` Tony Lindgren [this message]
2010-04-21 22:18   ` Kanigeri, Hari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100421220449.GP18272@atomide.com \
    --to=tony@atomide.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=felipe.contreras@gmail.com \
    --cc=h-kanigeri2@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox