Re: [PATCH v3 4/5(7)] input: serio: add support for Amstrad Delta serial keyboard port

Janusz Krzysztofik
2010-04-15T18:16:07Z

Thursday 15 April 2010 18:14:51 Dmitry Torokhov napisał(a):
> Hi Janusz,

Hi Dmitry,

> On Thu, Apr 15, 2010 at 04:31:03AM +0200, Janusz Krzysztofik wrote:
> > +
> > +config SERIO_AMS_DELTA
> > + tristate "Amstrad Delta (E3) mailboard support"
> > + depends on MACH_AMS_DELTA
> > + default y
> > + select AMS_DELTA_FIQ
> > + select KEYBOARD_ATKBD
>
> I'd rather not select atkbd here since it is not required for this
> driver to work but simply adjust your defconfig.

I was just trying to address possible future support questions, as you can
already find them in the e3-hacking 2006 archives :).

OK, I'll drop it then and move the config back inside the "if SERIO"..."endif"
block.

> > +
> > + if (!(machine_is_ams_delta()))
> > + return -ENODEV;
>
> Extra parens.

Yes, it looks like I'm too much wary. I'll drop them.

> Otherwise:
>
> Acked-by: Dmitry Torokhov <dtor@mail.ru>

Thanks.

> I assume it is going to be merged with the rest of your patches through
> a tree other than linux-input.

Probably yes, since it depends on most of them. Let's see first what Tony
says.

Regards,
Janusz
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html