From: Felipe Balbi <me@felipebalbi.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: me@felipebalbi.com, linux-omap@vger.kernel.org,
Tony Lindgren <tony@atomide.com>,
Hiroshi DOYU <hiroshi.doyu@gmail.com>
Subject: Re: mailbox_mach dependency problem
Date: Sun, 2 May 2010 10:13:55 +0300 [thread overview]
Message-ID: <20100502071354.GA2360@gandalf> (raw)
In-Reply-To: <w2y94a0d4531005011608kda24768ep87897ec46b39641e@mail.gmail.com>
On Sun, May 02, 2010 at 02:08:58AM +0300, Felipe Contreras wrote:
> On Sat, May 1, 2010 at 8:33 PM, Felipe Balbi <me@felipebalbi.com> wrote:
> > On Sat, May 01, 2010 at 05:47:57PM +0300, Felipe Contreras wrote:
> >> The easiest solution would be to make mailbox_mach built-in when
> >> mailbox is configured, however, mailbox_mach needs mailbox to be
> >> loaded.
> >
> > generally platform_device instantiation isn't compiled as a module. The
> > patch below should probably help but I didn't test it.
>
> Yeah, but as I said above... that doesn't work:
>
> arch/arm/mach-omap2/built-in.o: In function `omap2_mbox_probe':
> /data/public/dev/omap/linux-omap/arch/arm/mach-omap2/mailbox.c:389:
> undefined reference to `omap_mbox_register'
> arch/arm/mach-omap2/built-in.o: In function `omap2_mbox_remove':
> /data/public/dev/omap/linux-omap/arch/arm/mach-omap2/mailbox.c:439:
> undefined reference to `omap_mbox_unregister'
now I see the problem. You shouldn't put that kind of stuff on the
driver. The driver can be built as a module but the device will probably
be built-in. You'll need a more intrusive change to fix that, I guess.
--
balbi
next prev parent reply other threads:[~2010-05-02 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-01 14:47 mailbox_mach dependency problem Felipe Contreras
2010-05-01 17:33 ` Felipe Balbi
2010-05-01 23:08 ` Felipe Contreras
2010-05-02 7:13 ` Felipe Balbi [this message]
2010-05-02 12:57 ` Felipe Contreras
2010-05-02 15:59 ` Felipe Balbi
2010-05-03 0:16 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100502071354.GA2360@gandalf \
--to=me@felipebalbi.com \
--cc=felipe.contreras@gmail.com \
--cc=hiroshi.doyu@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox