Re: [PATCH v2 3/3] omap: gpmc-nand: add ability to keep timings defined by the bootloader

[Tony Lindgren <tony@atomide.com>]

* Mike Rapoport <mike@compulab.co.il> [100429 01:44]:
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>

Please add a proper description to all the patches.

> --- a/arch/arm/mach-omap2/gpmc-nand.c
> +++ b/arch/arm/mach-omap2/gpmc-nand.c
> @@ -116,6 +124,11 @@ int __init gpmc_nand_init(struct omap_nand_platform_data *_nand_data)
>  		return err;
>  	}
>  
> +	if (gpmc_nand_data->keep_timings) {
> +		gpmc_cs_get_timings(gpmc_nand_data->cs, &gpmc_default_timings);
> +		gpmc_nand_data->gpmc_t = &gpmc_default_timings;
> +	}
> +
>  	err = gpmc_nand_setup();
>  	if (err < 0) {
>  		dev_err(dev, "NAND platform setup failed: %d\n", err);

Hmm, so you're setting the timings based on the bootloader values?

I' think the problem with that is that chances are that it still won't
work for other L3 frequencies because of rounding errors.

With gpmc_cs_get_timings() you're already using tick rounded timings,
so you won't get the required accuracy out of those for the other
L3 frequencies.

So maybe just not do anything, and print a warning on gpmc L3 changes
if the timings are not set?

Regards,

Tony