From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v4 4/5(7)] input: serio: add support for Amstrad Delta serial keyboard port Date: Tue, 4 May 2010 13:58:00 -0700 Message-ID: <20100504205800.GD29428@core.coreip.homeip.net> References: <201004280252.58420.jkrzyszt@tis.icnet.pl> <201004280310.52678.jkrzyszt@tis.icnet.pl> <20100504204041.GL29604@atomide.com> <20100504204836.GJ30601@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:38451 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756938Ab0EDU6O (ORCPT ); Tue, 4 May 2010 16:58:14 -0400 Received: by wye20 with SMTP id 20so2737467wye.19 for ; Tue, 04 May 2010 13:58:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20100504204836.GJ30601@n2100.arm.linux.org.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Russell King - ARM Linux Cc: Tony Lindgren , Janusz Krzysztofik , e3-hacking@earth.li, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Tue, May 04, 2010 at 09:48:36PM +0100, Russell King - ARM Linux wrote: > On Tue, May 04, 2010 at 01:40:41PM -0700, Tony Lindgren wrote: > > * Janusz Krzysztofik [100427 18:09]: > > > The patch introduces a serio driver that supports a keyboard serial port found > > > on the Amstrad Delta videophone board. > > > > > > After initializing the hardware, the driver reads its input data from a buffer > > > filled in by the board FIQ (Fast Interrupt Request) handler. > > > > > > Standard AT keyboard driver (atkbd) will be used on top of the serio layer for > > > handling the E3 keyboard (called mailboard) connected to the port. Since the > > > device generated scancodes differ from what the atkbd expects, a custom key > > > code to scan code table must be loaded from userspace for the keyboard to be > > > useable. > > What's the rationale for this approach? There's no requirement for the > atkbd driver to be used for all keyboards. It seems very obscure (and > backward) way to do things. > > Why not implement the serio driver for the IO level, and a separate > keyboard driver which can handle the protocol and interpret the > scancodes? Because it is AT-like keyboard with messed up scancodes, it responds to our probes as a regular keyboard so we can't auto-select proper keymap. If you were to connect a standard PS/2 keyboard to E3 port it would work without any special keymap. -- Dmitry