From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org
Cc: linux-mtd@lists.infradead.org, Sukumar Ghorai <s-ghorai@ti.com>,
Vimal Singh <vimal.newwork@gmail.com>,
Steve Sakoman <sakoman@gmail.com>,
Mike Rapoport <mike@compulab.co.il>,
Artem Bityutski <Artem.Bityutskiy@nokia.com>
Subject: Upcoming merge window and omap NAND patches
Date: Tue, 4 May 2010 15:08:03 -0700 [thread overview]
Message-ID: <20100504220803.GN29604@atomide.com> (raw)
Hi all,
There are several omap NAND patches pending, but some basic things
should be fixed first.
1. The NAND driver needs to stop tinkering with the GPMC registers
The omap General Purpose Memory Controller (GPMC) registers are omap
specific, and not driver specific. Tinkering with these registers
can cause issues with the other devices on the GPMC.
To find out what needs to disappear fomr the NAND driver, just do:
$ grep baseaddr drivers/mtd/nand/omap2.c
Any GPMC register tinkering needs to happen in arch/arm/mach-omap2/gpmc.c.
If there are not currently GPMC functions to do something in gpmc.c, then
let's add the necessary support there.
2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files
Passing hardcoded GPMC virtual addressess is sure way to mess up
things. This should all become unnecessary once the NAND drivers
stops messing with the GPMC registers directly.
So, as a result, I'm not planning on pushing any omap NAND related
patches until these basic issues are fixed. I'll mark these patches
as "Changes requested" in patchwork.kernel.org even if these patches
don't have anything else wrong with them.
Let's fix the basic things for good, and put the other patches on
hold for a while. Sorry if this causes problems!
Cheers,
Tony
next reply other threads:[~2010-05-04 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 22:08 Tony Lindgren [this message]
2010-05-05 4:49 ` Upcoming merge window and omap NAND patches Artem Bityutskiy
2010-05-05 6:11 ` Vimal Singh
2010-05-05 12:33 ` Ghorai, Sukumar
2010-05-05 12:55 ` Mike Rapoport
2010-05-05 15:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504220803.GN29604@atomide.com \
--to=tony@atomide.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=s-ghorai@ti.com \
--cc=sakoman@gmail.com \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).