* Upcoming merge window and omap NAND patches @ 2010-05-04 22:08 Tony Lindgren 2010-05-05 4:49 ` Artem Bityutskiy 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2010-05-04 22:08 UTC (permalink / raw) To: linux-omap Cc: linux-mtd, Sukumar Ghorai, Vimal Singh, Steve Sakoman, Mike Rapoport, Artem Bityutski Hi all, There are several omap NAND patches pending, but some basic things should be fixed first. 1. The NAND driver needs to stop tinkering with the GPMC registers The omap General Purpose Memory Controller (GPMC) registers are omap specific, and not driver specific. Tinkering with these registers can cause issues with the other devices on the GPMC. To find out what needs to disappear fomr the NAND driver, just do: $ grep baseaddr drivers/mtd/nand/omap2.c Any GPMC register tinkering needs to happen in arch/arm/mach-omap2/gpmc.c. If there are not currently GPMC functions to do something in gpmc.c, then let's add the necessary support there. 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files Passing hardcoded GPMC virtual addressess is sure way to mess up things. This should all become unnecessary once the NAND drivers stops messing with the GPMC registers directly. So, as a result, I'm not planning on pushing any omap NAND related patches until these basic issues are fixed. I'll mark these patches as "Changes requested" in patchwork.kernel.org even if these patches don't have anything else wrong with them. Let's fix the basic things for good, and put the other patches on hold for a while. Sorry if this causes problems! Cheers, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Upcoming merge window and omap NAND patches 2010-05-04 22:08 Upcoming merge window and omap NAND patches Tony Lindgren @ 2010-05-05 4:49 ` Artem Bityutskiy 2010-05-05 6:11 ` Vimal Singh 0 siblings, 1 reply; 6+ messages in thread From: Artem Bityutskiy @ 2010-05-05 4:49 UTC (permalink / raw) To: Tony Lindgren Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, Sukumar Ghorai, Vimal Singh, Steve Sakoman, Mike Rapoport On Wed, 2010-05-05 at 00:08 +0200, ext Tony Lindgren wrote: > Hi all, > > There are several omap NAND patches pending, but some basic things > should be fixed first. > > 1. The NAND driver needs to stop tinkering with the GPMC registers > > The omap General Purpose Memory Controller (GPMC) registers are omap > specific, and not driver specific. Tinkering with these registers > can cause issues with the other devices on the GPMC. > > To find out what needs to disappear fomr the NAND driver, just do: > > $ grep baseaddr drivers/mtd/nand/omap2.c > > Any GPMC register tinkering needs to happen in arch/arm/mach-omap2/gpmc.c. > If there are not currently GPMC functions to do something in gpmc.c, then > let's add the necessary support there. > > 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files > > Passing hardcoded GPMC virtual addressess is sure way to mess up > things. This should all become unnecessary once the NAND drivers > stops messing with the GPMC registers directly. > > So, as a result, I'm not planning on pushing any omap NAND related > patches until these basic issues are fixed. I'll mark these patches > as "Changes requested" in patchwork.kernel.org even if these patches > don't have anything else wrong with them. > > Let's fix the basic things for good, and put the other patches on > hold for a while. Sorry if this causes problems! Hi, fair enough. I guess Vimal should address this, as he seems to be the TI mr. NAND, right? :-) -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Upcoming merge window and omap NAND patches 2010-05-05 4:49 ` Artem Bityutskiy @ 2010-05-05 6:11 ` Vimal Singh 2010-05-05 12:33 ` Ghorai, Sukumar 0 siblings, 1 reply; 6+ messages in thread From: Vimal Singh @ 2010-05-05 6:11 UTC (permalink / raw) To: Artem.Bityutskiy Cc: Tony Lindgren, Sukumar Ghorai, Steve Sakoman, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org On Wed, May 5, 2010 at 10:19 AM, Artem Bityutskiy <Artem.Bityutskiy@nokia.com> wrote: > On Wed, 2010-05-05 at 00:08 +0200, ext Tony Lindgren wrote: >> Hi all, >> >> There are several omap NAND patches pending, but some basic things >> should be fixed first. >> >> 1. The NAND driver needs to stop tinkering with the GPMC registers >> >> The omap General Purpose Memory Controller (GPMC) registers are omap >> specific, and not driver specific. Tinkering with these registers >> can cause issues with the other devices on the GPMC. >> >> To find out what needs to disappear fomr the NAND driver, just do: >> >> $ grep baseaddr drivers/mtd/nand/omap2.c >> >> Any GPMC register tinkering needs to happen in arch/arm/mach-omap2/gpmc.c. >> If there are not currently GPMC functions to do something in gpmc.c, then >> let's add the necessary support there. >> >> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files >> >> Passing hardcoded GPMC virtual addressess is sure way to mess up >> things. This should all become unnecessary once the NAND drivers >> stops messing with the GPMC registers directly. >> >> So, as a result, I'm not planning on pushing any omap NAND related >> patches until these basic issues are fixed. I'll mark these patches >> as "Changes requested" in patchwork.kernel.org even if these patches >> don't have anything else wrong with them. >> >> Let's fix the basic things for good, and put the other patches on >> hold for a while. Sorry if this causes problems! > > Hi, > > fair enough. I guess Vimal should address this, as he seems to be the TI > mr. NAND, right? :-) Hi All, Sorry again. I am no more with TI and I don't have any board with me too. So, I'm unable to fix these. :( I hope someone else from TI can take care of it. -- Regards, Vimal Singh ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: Upcoming merge window and omap NAND patches 2010-05-05 6:11 ` Vimal Singh @ 2010-05-05 12:33 ` Ghorai, Sukumar 2010-05-05 12:55 ` Mike Rapoport 0 siblings, 1 reply; 6+ messages in thread From: Ghorai, Sukumar @ 2010-05-05 12:33 UTC (permalink / raw) To: Vimal Singh, Artem.Bityutskiy@nokia.com, Tony Lindgren Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, Steve Sakoman, Mike Rapoport Tony, I understand your comment/input. And I will work on it. All existing omap3 boards are using same old fashion. So let me see how many board I can test before post the patch. I will update this next week. Regards, Ghorai > -----Original Message----- > From: Vimal Singh [mailto:vimal.newwork@gmail.com] > Sent: 2010-05-05 11:42 > To: Artem.Bityutskiy@nokia.com > Cc: Tony Lindgren; linux-omap@vger.kernel.org; linux- > mtd@lists.infradead.org; Ghorai, Sukumar; Steve Sakoman; Mike Rapoport > Subject: Re: Upcoming merge window and omap NAND patches > > On Wed, May 5, 2010 at 10:19 AM, Artem Bityutskiy > <Artem.Bityutskiy@nokia.com> wrote: > > On Wed, 2010-05-05 at 00:08 +0200, ext Tony Lindgren wrote: > >> Hi all, > >> > >> There are several omap NAND patches pending, but some basic things > >> should be fixed first. > >> > >> 1. The NAND driver needs to stop tinkering with the GPMC registers > >> > >> The omap General Purpose Memory Controller (GPMC) registers are omap > >> specific, and not driver specific. Tinkering with these registers > >> can cause issues with the other devices on the GPMC. > >> > >> To find out what needs to disappear fomr the NAND driver, just do: > >> > >> $ grep baseaddr drivers/mtd/nand/omap2.c > >> > >> Any GPMC register tinkering needs to happen in arch/arm/mach- > omap2/gpmc.c. > >> If there are not currently GPMC functions to do something in gpmc.c, > then > >> let's add the necessary support there. > >> > >> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files > >> > >> Passing hardcoded GPMC virtual addressess is sure way to mess up > >> things. This should all become unnecessary once the NAND drivers > >> stops messing with the GPMC registers directly. > >> > >> So, as a result, I'm not planning on pushing any omap NAND related > >> patches until these basic issues are fixed. I'll mark these patches > >> as "Changes requested" in patchwork.kernel.org even if these patches > >> don't have anything else wrong with them. > >> > >> Let's fix the basic things for good, and put the other patches on > >> hold for a while. Sorry if this causes problems! > > > > Hi, > > > > fair enough. I guess Vimal should address this, as he seems to be the TI > > mr. NAND, right? :-) > > Hi All, > > Sorry again. I am no more with TI and I don't have any board with me > too. So, I'm unable to fix these. :( > I hope someone else from TI can take care of it. > > -- > Regards, > Vimal Singh ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Upcoming merge window and omap NAND patches 2010-05-05 12:33 ` Ghorai, Sukumar @ 2010-05-05 12:55 ` Mike Rapoport 2010-05-05 15:11 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Mike Rapoport @ 2010-05-05 12:55 UTC (permalink / raw) To: Ghorai, Sukumar Cc: Artem.Bityutskiy@nokia.com, Tony Lindgren, Steve Sakoman, Vimal Singh, linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org Ghorai, Ghorai, Sukumar wrote: > Tony, > I understand your comment/input. And I will work on it. > > All existing omap3 boards are using same old fashion. So let me see how many board I can test before post the patch. I will update this next week. I'd be glad to test the patches on CM-T35 if you'd like to. > Regards, > Ghorai > >> -----Original Message----- >> From: Vimal Singh [mailto:vimal.newwork@gmail.com] >> Sent: 2010-05-05 11:42 >> To: Artem.Bityutskiy@nokia.com >> Cc: Tony Lindgren; linux-omap@vger.kernel.org; linux- >> mtd@lists.infradead.org; Ghorai, Sukumar; Steve Sakoman; Mike Rapoport >> Subject: Re: Upcoming merge window and omap NAND patches >> >> On Wed, May 5, 2010 at 10:19 AM, Artem Bityutskiy >> <Artem.Bityutskiy@nokia.com> wrote: >>> On Wed, 2010-05-05 at 00:08 +0200, ext Tony Lindgren wrote: >>>> Hi all, >>>> >>>> There are several omap NAND patches pending, but some basic things >>>> should be fixed first. >>>> >>>> 1. The NAND driver needs to stop tinkering with the GPMC registers >>>> >>>> The omap General Purpose Memory Controller (GPMC) registers are omap >>>> specific, and not driver specific. Tinkering with these registers >>>> can cause issues with the other devices on the GPMC. >>>> >>>> To find out what needs to disappear fomr the NAND driver, just do: >>>> >>>> $ grep baseaddr drivers/mtd/nand/omap2.c >>>> >>>> Any GPMC register tinkering needs to happen in arch/arm/mach- >> omap2/gpmc.c. >>>> If there are not currently GPMC functions to do something in gpmc.c, >> then >>>> let's add the necessary support there. >>>> >>>> 2. Passing hardcoded GPMC_CS0_BASE needs to go from the board files >>>> >>>> Passing hardcoded GPMC virtual addressess is sure way to mess up >>>> things. This should all become unnecessary once the NAND drivers >>>> stops messing with the GPMC registers directly. >>>> >>>> So, as a result, I'm not planning on pushing any omap NAND related >>>> patches until these basic issues are fixed. I'll mark these patches >>>> as "Changes requested" in patchwork.kernel.org even if these patches >>>> don't have anything else wrong with them. >>>> >>>> Let's fix the basic things for good, and put the other patches on >>>> hold for a while. Sorry if this causes problems! >>> Hi, >>> >>> fair enough. I guess Vimal should address this, as he seems to be the TI >>> mr. NAND, right? :-) >> Hi All, >> >> Sorry again. I am no more with TI and I don't have any board with me >> too. So, I'm unable to fix these. :( >> I hope someone else from TI can take care of it. >> >> -- >> Regards, >> Vimal Singh -- Sincerely yours, Mike. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Upcoming merge window and omap NAND patches 2010-05-05 12:55 ` Mike Rapoport @ 2010-05-05 15:11 ` Tony Lindgren 0 siblings, 0 replies; 6+ messages in thread From: Tony Lindgren @ 2010-05-05 15:11 UTC (permalink / raw) To: Mike Rapoport Cc: Ghorai, Sukumar, Vimal Singh, Artem.Bityutskiy@nokia.com, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, Steve Sakoman * Mike Rapoport <mike@compulab.co.il> [100505 05:51]: > Ghorai, > > Ghorai, Sukumar wrote: > >Tony, > >I understand your comment/input. And I will work on it. Great, good to hear. > >All existing omap3 boards are using same old fashion. So let me see how many board I can test before post the patch. I will update this next week. > > I'd be glad to test the patches on CM-T35 if you'd like to. For this merge window how about just getting rid of OMAP34XX_GPMC_VIRT in the board-*.c files and move that to gpmc-nand.c? This may allow adding more board-*.c NAND files without having to patch all of them later on again. However, if there are more changes needed to all the board-*.c files for the NAND platform data, then let's just fix the existing ones first before adding new ones. After that, looks like most of the work is to move some of the GPMC functions from omap2.c to gpmc.c. Or should they rather be in gpmc-nand.c if they are only used with NAND connected to GPMC? Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-05-05 15:11 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-05-04 22:08 Upcoming merge window and omap NAND patches Tony Lindgren 2010-05-05 4:49 ` Artem Bityutskiy 2010-05-05 6:11 ` Vimal Singh 2010-05-05 12:33 ` Ghorai, Sukumar 2010-05-05 12:55 ` Mike Rapoport 2010-05-05 15:11 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).