From: Tony Lindgren <tony@atomide.com>
To: "Arce, Abraham" <x0066660@ti.com>
Cc: "G, Manjunath Kondaiah" <manjugk@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"spi-devel-general@lists.sourceforge.net"
<spi-devel-general@lists.sourceforge.net>
Subject: Re: [PATCH v1 2/3] OMAP4: Ethernet: KS8851 Board Support
Date: Wed, 5 May 2010 10:19:39 -0700 [thread overview]
Message-ID: <20100505171938.GX29604@atomide.com> (raw)
In-Reply-To: <27F9C60D11D683428E133F85D2BB4A53043DEEB8D1@dlee03.ent.ti.com>
* Arce, Abraham <x0066660@ti.com> [100505 01:06]:
> Manjunath,
>
> > > +
> > > +static void omap_ethernet_init(void)
> > > +{
> > > + gpio_request(ETHERNET_KS8851_POWER_ENABLE, "ethernet");
> > > + gpio_direction_output(ETHERNET_KS8851_POWER_ENABLE, 1);
> > > + gpio_request(ETHERNET_KS8851_QUART, "quart");
> > > + gpio_direction_output(ETHERNET_KS8851_QUART, 1);
> > > + gpio_request(ETHERNET_KS8851_IRQ, "ks8851");
> >
> > Any reason for not checking return value of gpio_request()?
> >
>
> Thought initially about them as dedicated lines for ethernet avoiding
> both reasons to check for a gpio's request:
>
> 1. invalid gpio
> 2. already claimed gpio
You still need to check for the result.
Tony
next prev parent reply other threads:[~2010-05-05 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 7:10 [PATCH v1 2/3] OMAP4: Ethernet: KS8851 Board Support Arce, Abraham
[not found] ` <27F9C60D11D683428E133F85D2BB4A53043DEEB8C1-lTKHBJngVwKIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-05 7:34 ` G, Manjunath Kondaiah
[not found] ` <E0D41E29EB0DAC4E9F3FF173962E9E94026F8C7096-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-05 8:11 ` Arce, Abraham
2010-05-05 17:19 ` Tony Lindgren [this message]
2010-05-06 0:47 ` Arce, Abraham
2010-05-06 3:14 ` G, Manjunath Kondaiah
2010-05-06 3:41 ` G, Manjunath Kondaiah
[not found] ` <E0D41E29EB0DAC4E9F3FF173962E9E94026F8C74DE-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-05-06 4:18 ` Arce, Abraham
2010-05-06 9:03 ` G, Manjunath Kondaiah
2010-05-06 9:43 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505171938.GX29604@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox