From: Felipe Balbi <me@felipebalbi.com>
To: Ajay Kumar Gupta <ajay.gupta@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
felipe.balbi@nokia.com
Subject: Re: [PATCH 2/2] usb: ehci-omap: fix Si version related programming
Date: Wed, 5 May 2010 21:31:02 +0300 [thread overview]
Message-ID: <20100505183102.GA2274@gandalf> (raw)
In-Reply-To: <1272959123-31362-2-git-send-email-ajay.gupta@ti.com>
On Tue, May 04, 2010 at 01:15:23PM +0530, Ajay Kumar Gupta wrote:
> @@ -352,8 +352,8 @@ static int omap_start_ehc(struct ehci_hcd_omap *omap, struct usb_hcd *hcd)
> reg &= ~OMAP_UHH_HOSTCONFIG_P3_CONNECT_STATUS;
>
> /* Bypass the TLL module for PHY mode operation */
> - if (omap_rev() <= OMAP3430_REV_ES2_1) {
> - dev_dbg(omap->dev, "OMAP3 ES version <= ES2.1 \n");
> + if (cpu_is_omap3430() && (omap_rev() <= OMAP3430_REV_ES2_1)) {
> + dev_dbg(omap->dev, "OMAP3 ES version <= ES2.1\n");
this shouldn't be here. please pass down a flag through platform_data
for such checks.
--
balbi
next prev parent reply other threads:[~2010-05-05 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 7:45 [PATCH 1/2] usb: ehci-omap: fix compilation warning Ajay Kumar Gupta
2010-05-04 7:45 ` [PATCH 2/2] usb: ehci-omap: fix Si version related programming Ajay Kumar Gupta
2010-05-05 18:31 ` Felipe Balbi [this message]
[not found] ` <1272959123-31362-1-git-send-email-ajay.gupta-l0cyMroinI0@public.gmane.org>
2010-05-04 14:23 ` [PATCH 1/2] usb: ehci-omap: fix compilation warning Gupta, Ajay Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505183102.GA2274@gandalf \
--to=me@felipebalbi.com \
--cc=ajay.gupta@ti.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).