linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com>
To: ext Lesly Arackal Manuel <leslyam@ti.com>
Cc: "Valentin Eduardo (Nokia-D/Helsinki)"
	<eduardo.valentin@nokia.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	'Lesly A M' <x0080970@ti.com>, 'Nishanth Menon' <nm@ti.com>,
	'David Derrick' <dderrick@ti.com>,
	'Samuel Ortiz' <sameo@linux.intel.com>
Subject: Re: [PATCH v5 1/5] omap3: pm: fix for twl4030 script load
Date: Tue, 11 May 2010 15:46:52 +0300	[thread overview]
Message-ID: <20100511124652.GA4749@codecarver.research.nokia.com> (raw)
In-Reply-To: <007201caeb5c$9ca7ed50$518918ac@apr.dhcp.ti.com>

Hi,

> 
> Hi Eduardo,
> 
> The load_twl4030_script() is called from twl4030_power_init() which is again
> called from twl_probe(), and this is getting called before
> omap3_idle_init().
> 
> So the scripts are loaded before the cpuidle is initialized.
> Then I don't think the system will hit sys_off before loading the scripts.
> 
> Regards,
> Lesly
> 

Hi,

I agree that in our usecase the problem can probably never happen. But
what if NSLEEP2 would be controlled by some external component (Ie. not
OMAP) ? I don't think we can be sure that the sleep script will not be
executed while the wakeup script is not yet loaded (assuming they would
be loaded in the wrong order). Note that loading the script also sets
the address in the corresponding TWL4030 register. So I think this
safeguard is still useful.

Thanks,

Peter.

  parent reply	other threads:[~2010-05-11 12:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19 11:43 [PATCH v5 1/5] omap3: pm: fix for twl4030 script load Lesly A M
2010-05-04  6:27 ` Eduardo Valentin
2010-05-04  7:37   ` Lesly Arackal Manuel
2010-05-04  8:47     ` Eduardo Valentin
2010-05-11 12:46     ` Peter 'p2' De Schrijver [this message]
2010-05-13  9:43       ` Lesly Arackal Manuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100511124652.GA4749@codecarver.research.nokia.com \
    --to=peter.de-schrijver@nokia.com \
    --cc=dderrick@ti.com \
    --cc=eduardo.valentin@nokia.com \
    --cc=leslyam@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=sameo@linux.intel.com \
    --cc=x0080970@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).