From: Tony Lindgren <tony@atomide.com>
To: Madhvapathi Sriram <sriram.m@ti.com>
Cc: linux-omap@vger.kernel.org, madhu.cr@ti.com
Subject: Re: [PATCH 1/1] omap-hsmmc.c: re-organize dma line population
Date: Tue, 11 May 2010 12:56:48 -0700 [thread overview]
Message-ID: <20100511195648.GF13931@atomide.com> (raw)
In-Reply-To: <1273566733-22572-1-git-send-email-sriram.m@ti.com>
* Madhvapathi Sriram <sriram.m@ti.com> [100511 02:26]:
> @@ -255,6 +256,52 @@ int __init omap_mmc_add(const char *name, int id, unsigned long base,
> res[0].flags = IORESOURCE_MEM;
> res[1].start = res[1].end = irq;
> res[1].flags = IORESOURCE_IRQ;
> + /* Populate DMA lines based on the instance used. Rx first,Tx next*/
> + switch (id) {
> + case 0:
> + res[2].start = OMAP24XX_DMA_MMC1_RX;
> + res[2].end = OMAP24XX_DMA_MMC1_RX;
> + res[2].flags = IORESOURCE_DMA;
> + res[3].start = OMAP24XX_DMA_MMC1_TX;
> + res[3].end = OMAP24XX_DMA_MMC1_TX;
> + res[3].flags = IORESOURCE_DMA;
> + break;
> + case 1:
> + res[2].start = OMAP24XX_DMA_MMC2_RX;
> + res[2].end = OMAP24XX_DMA_MMC2_RX;
> + res[2].flags = IORESOURCE_DMA;
> + res[3].start = OMAP24XX_DMA_MMC2_TX;
> + res[3].end = OMAP24XX_DMA_MMC2_TX;
> + res[3].flags = IORESOURCE_DMA;
> + break;
> + case 2:
> + res[2].start = OMAP34XX_DMA_MMC3_RX;
> + res[2].end = OMAP34XX_DMA_MMC3_RX;
> + res[2].flags = IORESOURCE_DMA;
> + res[3].start = OMAP34XX_DMA_MMC3_TX;
> + res[3].end = OMAP34XX_DMA_MMC3_TX;
> + res[3].flags = IORESOURCE_DMA;
> + break;
> + case 3:
> + res[2].start = OMAP44XX_DMA_MMC4_RX;
> + res[2].end = OMAP44XX_DMA_MMC4_RX;
> + res[2].flags = IORESOURCE_DMA;
> + res[3].start = OMAP44XX_DMA_MMC4_TX;
> + res[3].end = OMAP44XX_DMA_MMC4_TX;
> + res[3].flags = IORESOURCE_DMA;
> + break;
> + case 4:
> + res[2].start = OMAP44XX_DMA_MMC5_RX;
> + res[2].end = OMAP44XX_DMA_MMC5_RX;
> + res[2].flags = IORESOURCE_DMA;
> + res[3].start = OMAP44XX_DMA_MMC5_TX;
> + res[3].end = OMAP44XX_DMA_MMC5_TX;
> + res[3].flags = IORESOURCE_DMA;
> + break;
> + default:
> + ret = -ENODEV;
> + goto fail;
> + }
To me it seems like this should go into mach-omap2/hsmmc.c instead
of plat-omap/devices.c.
Tony
prev parent reply other threads:[~2010-05-11 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 8:32 [PATCH 1/1] omap-hsmmc.c: re-organize dma line population Madhvapathi Sriram
2010-05-11 10:52 ` Grazvydas Ignotas
2010-05-11 11:19 ` Venkatraman S
2010-05-11 19:56 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511195648.GF13931@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=sriram.m@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).