From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers Date: Thu, 13 May 2010 12:49:22 -0700 Message-ID: <20100513194922.GD3428@atomide.com> References: <1267984078-6036-1-git-send-email-darkstar6262@gmail.com> <20100513192934.GB3428@atomide.com> <20100513124121.753689ce.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100513124121.753689ce.akpm@linux-foundation.org> Sender: linux-mmc-owner@vger.kernel.org To: Andrew Morton Cc: linux-mmc@vger.kernel.org, Cory Maccarrone , Ladislav Michl , linux-omap@vger.kernel.org, Marek Belisko List-Id: linux-omap@vger.kernel.org * Andrew Morton [100513 12:36]: > On Thu, 13 May 2010 12:29:35 -0700 > Tony Lindgren wrote: > > > * Cory Maccarrone [100307 09:44]: > > > From: Marek Belisko > > > > > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > > > a modification of the register addresses in the mmc-omap driver. To resolve > > > this, a bit shift is performed on base register addresses, either by 1 or 2 > > > bits depending on the CPU in use. This yields the correct registers for > > > each CPU. > > > > > > Signed-off-by: Marek Belisko > > > Signed-off-by: Cory Maccarrone > > > Signed-off-by: Tony Lindgren > > > > Can you please queue this patch too? Ben's comments in this thread > > were for the i2c-omap, not for this MMC patch. We've had this patch > > in the omap tree for testing for quite a while now. > > > > The patch is also available in at: > > > > https://patchwork.kernel.org/patch/83971/ > > > > with the direct link to the mbox being: > > > > https://patchwork.kernel.org/patch/83971/mbox/ > > I already have that, as mmc-omap-add-support-for-16-bit-and-32-bit-registers.patch OK, thanks. I should have checked your queue first. Tony