Re: [PATCH 2/4] OMAP: mcbsp - add smart idle configuration API

[Eduardo Valentin <eduardo.valentin@nokia.com>]

On Wed, May 19, 2010 at 01:21:26PM +0200, Liam Girdwood wrote:
> On Wed, 2010-05-19 at 13:46 +0300, Eduardo Valentin wrote:
> > Hello Lian,
> > 
> > On Tue, May 18, 2010 at 10:13:12PM +0200, Liam Girdwood wrote:
> > > Add a small API to configure McBSP smart idle modes
> > > to conserve power.
> > 
> > I'm sorry but I didn't get the point of this patch, as you didn't add any wider
> > description why you need to export this feature. 
> 
> Sorry, I thought this would obvious from the patch and description.
> 
> > Why do you think mcbsp clients
> > should be aware of these bit? Would it make sense to mask it behind other feature?
> > like the threshold size for instance..
> 
> Why do you think it should be masked behind threshold ? 

Well, that was just an example. It could be masked there because, if client doesn't set the
threshold level, you could assume you don't need to set the smart idle.

Or maybe it could be bound to dma op mode. if element mode, then no need to smart idle.
I guess that was the way it was, at some point.

> 
> Liam
> -- 
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>