linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
@ 2010-05-19 16:38 Santosh Shilimkar
  2010-05-19 20:01 ` Nishanth Menon
  2010-05-19 23:10 ` Paul Walmsley
  0 siblings, 2 replies; 16+ messages in thread
From: Santosh Shilimkar @ 2010-05-19 16:38 UTC (permalink / raw)
  To: linux-omap; +Cc: Santosh Shilimkar, Paul Walmsley

This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
to avoid the emif clk getting cut as part of reset un-used clock
routine which prevents boot.

Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
which increases the usecount on all ENABLE_ON_INIT clocks, it
prevents "omap2_clk_disable_unused()" from disabling the clock.

The real fix is to have driver for EMIF and do clock get/enable
as part of it. The EMIF driver is planned to be done HWMOD way
so till that available to keep omap3_defconfig booting on OMAP4430,
this patch is necessary.
(Will updated the auto-gen script for 44xx accordingly)

The fix was suggested by Paul Walmsley

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
---
With this patch and Tony's below sram fix, omap3_defconfig
boots on OMAP4430 as it is. Boot tested with 2.6.34 maniline kernel
on OMAP4430, OMAP3430 with omap3_defconfig and regular defconfig

http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27363.html

 arch/arm/mach-omap2/clock44xx_data.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
index a5c0c9c..a1b4cae 100644
--- a/arch/arm/mach-omap2/clock44xx_data.c
+++ b/arch/arm/mach-omap2/clock44xx_data.c
@@ -1369,6 +1369,7 @@ static struct clk emif1_ick = {
 	.ops		= &clkops_omap2_dflt,
 	.enable_reg	= OMAP4430_CM_MEMIF_EMIF_1_CLKCTRL,
 	.enable_bit	= OMAP4430_MODULEMODE_HWCTRL,
+	.flags		= ENABLE_ON_INIT,
 	.clkdm_name	= "l3_emif_clkdm",
 	.parent		= &ddrphy_ck,
 	.recalc		= &followparent_recalc,
@@ -1379,6 +1380,7 @@ static struct clk emif2_ick = {
 	.ops		= &clkops_omap2_dflt,
 	.enable_reg	= OMAP4430_CM_MEMIF_EMIF_2_CLKCTRL,
 	.enable_bit	= OMAP4430_MODULEMODE_HWCTRL,
+	.flags		= ENABLE_ON_INIT,
 	.clkdm_name	= "l3_emif_clkdm",
 	.parent		= &ddrphy_ck,
 	.recalc		= &followparent_recalc,
-- 
1.6.0.4


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-19 16:38 [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks Santosh Shilimkar
@ 2010-05-19 20:01 ` Nishanth Menon
  2010-05-20  1:00   ` Tony Lindgren
  2010-05-19 23:10 ` Paul Walmsley
  1 sibling, 1 reply; 16+ messages in thread
From: Nishanth Menon @ 2010-05-19 20:01 UTC (permalink / raw)
  To: Shilimkar, Santosh; +Cc: linux-omap@vger.kernel.org, Paul Walmsley

Shilimkar, Santosh had written, on 05/19/2010 11:38 AM, the following:
> This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> to avoid the emif clk getting cut as part of reset un-used clock
> routine which prevents boot.
> 
> Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> which increases the usecount on all ENABLE_ON_INIT clocks, it
> prevents "omap2_clk_disable_unused()" from disabling the clock.
> 
> The real fix is to have driver for EMIF and do clock get/enable
> as part of it. The EMIF driver is planned to be done HWMOD way
> so till that available to keep omap3_defconfig booting on OMAP4430,
> this patch is necessary.
> (Will updated the auto-gen script for 44xx accordingly)
> 
> The fix was suggested by Paul Walmsley
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> ---
> With this patch and Tony's below sram fix, omap3_defconfig
> boots on OMAP4430 as it is. Boot tested with 2.6.34 maniline kernel
> on OMAP4430, OMAP3430 with omap3_defconfig and regular defconfig
> 
> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27363.html
> 
>  arch/arm/mach-omap2/clock44xx_data.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
> index a5c0c9c..a1b4cae 100644
> --- a/arch/arm/mach-omap2/clock44xx_data.c
> +++ b/arch/arm/mach-omap2/clock44xx_data.c
> @@ -1369,6 +1369,7 @@ static struct clk emif1_ick = {
>  	.ops		= &clkops_omap2_dflt,
>  	.enable_reg	= OMAP4430_CM_MEMIF_EMIF_1_CLKCTRL,
>  	.enable_bit	= OMAP4430_MODULEMODE_HWCTRL,
> +	.flags		= ENABLE_ON_INIT,
>  	.clkdm_name	= "l3_emif_clkdm",
>  	.parent		= &ddrphy_ck,
>  	.recalc		= &followparent_recalc,
> @@ -1379,6 +1380,7 @@ static struct clk emif2_ick = {
>  	.ops		= &clkops_omap2_dflt,
>  	.enable_reg	= OMAP4430_CM_MEMIF_EMIF_2_CLKCTRL,
>  	.enable_bit	= OMAP4430_MODULEMODE_HWCTRL,
> +	.flags		= ENABLE_ON_INIT,
>  	.clkdm_name	= "l3_emif_clkdm",
>  	.parent		= &ddrphy_ck,
>  	.recalc		= &followparent_recalc,
Tested-by: Nishanth Menon <nm@ti.com>

tested on SDP4430 -> NOTE: it wont get through beyond
[    5.953491] Bluetooth: L2CAP socket layer initialized
[    5.958648] Bluetooth: SCO (Voice Link) ver 0.6
[    5.963256] Bluetooth: SCO socket layer initialized
[    5.968475] Bluetooth: RFCOMM TTY layer initialized
[    5.973449] Bluetooth: RFCOMM socket layer initialized
[    5.978698] Bluetooth: RFCOMM ver 1.11
[    5.982482] Bluetooth: BNEP (Ethernet Emulation) ver 1.3
[    5.987884] Bluetooth: BNEP filters: protocol multicast
[    5.993164] Bluetooth: HIDP (Human Interface Emulation) ver 1.2
[    6.000457] lib80211: common routines for IEEE802.11 drivers
[    6.006286] ThumbEE CPU extension supported.
[    6.045471] VFP support v0.3: implementor 41 architecture 3 part 30 
variant 9 rev 0
[    6.057250] drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
[   18.688720] Looking up port of RPC 100003/2 on 128.247.75.5
[   48.694244] rpcbind: server 128.247.75.1 not responding, timed out
[   48.700958] Root-NFS: Unable to get nfsd port number from server, 
using default
[   48.708374] Looking up port of RPC 100005/1 on 128.247.75.5
[   78.710479] rpcbind: server 128.247.75.1 not responding, timed out
[   78.716827] Root-NFS: Unable to get mountd port number from server, 
using default
looks like network is still not functional on SDP4430. different issue

Pass to NFS boot on: SDP3630, SDP3430.

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-19 16:38 [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks Santosh Shilimkar
  2010-05-19 20:01 ` Nishanth Menon
@ 2010-05-19 23:10 ` Paul Walmsley
  2010-05-20  4:58   ` Shilimkar, Santosh
  2010-05-31 12:48   ` Tony Lindgren
  1 sibling, 2 replies; 16+ messages in thread
From: Paul Walmsley @ 2010-05-19 23:10 UTC (permalink / raw)
  To: Santosh Shilimkar, Nishanth Menon; +Cc: linux-omap

Hi,

On Wed, 19 May 2010, Santosh Shilimkar wrote:

> This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> to avoid the emif clk getting cut as part of reset un-used clock
> routine which prevents boot.
> 
> Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> which increases the usecount on all ENABLE_ON_INIT clocks, it
> prevents "omap2_clk_disable_unused()" from disabling the clock.
> 
> The real fix is to have driver for EMIF and do clock get/enable
> as part of it. The EMIF driver is planned to be done HWMOD way
> so till that available to keep omap3_defconfig booting on OMAP4430,
> this patch is necessary.
> (Will updated the auto-gen script for 44xx accordingly)
> 
> The fix was suggested by Paul Walmsley
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>

Thanks, I've added Nishanth's Tested-by: and fixed the patch changelog; 
the following patch is now queued for 2.6.35-rc, unless there are any 
further comments.


- Paul

>From 3f3de7c0419784153564c63b4a2d3c3c95808e3e Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Wed, 19 May 2010 22:08:07 +0530
Subject: [PATCH] OMAP4: clock: Fix multi-omap boot with reset un-used clocks

This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
to avoid the emif clk getting cut as part of reset un-used clock
routine which prevents boot.

Since "omap4xxx_clk_init()" calls "clk_enable_init_clocks()"
which increases the usecount on all ENABLE_ON_INIT clocks, it
prevents "omap2_clk_disable_unused()" from disabling the clock.

The real fix is to have driver for EMIF and do clock get/enable
as part of it. The EMIF driver is planned to be done HWMOD way
so till that available to keep omap3_defconfig booting on OMAP4430,
this patch is necessary.
(Will updated the auto-gen script for 44xx accordingly)

The fix was suggested by Paul Walmsley

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Tested-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
 arch/arm/mach-omap2/clock44xx_data.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c
index a5c0c9c..a1b4cae 100644
--- a/arch/arm/mach-omap2/clock44xx_data.c
+++ b/arch/arm/mach-omap2/clock44xx_data.c
@@ -1369,6 +1369,7 @@ static struct clk emif1_ick = {
 	.ops		= &clkops_omap2_dflt,
 	.enable_reg	= OMAP4430_CM_MEMIF_EMIF_1_CLKCTRL,
 	.enable_bit	= OMAP4430_MODULEMODE_HWCTRL,
+	.flags		= ENABLE_ON_INIT,
 	.clkdm_name	= "l3_emif_clkdm",
 	.parent		= &ddrphy_ck,
 	.recalc		= &followparent_recalc,
@@ -1379,6 +1380,7 @@ static struct clk emif2_ick = {
 	.ops		= &clkops_omap2_dflt,
 	.enable_reg	= OMAP4430_CM_MEMIF_EMIF_2_CLKCTRL,
 	.enable_bit	= OMAP4430_MODULEMODE_HWCTRL,
+	.flags		= ENABLE_ON_INIT,
 	.clkdm_name	= "l3_emif_clkdm",
 	.parent		= &ddrphy_ck,
 	.recalc		= &followparent_recalc,
-- 
1.7.1.rc2


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-19 20:01 ` Nishanth Menon
@ 2010-05-20  1:00   ` Tony Lindgren
  2010-05-20  1:03     ` Nishanth Menon
  0 siblings, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2010-05-20  1:00 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Paul Walmsley

* Nishanth Menon <nm@ti.com> [100519 12:56]:
>
> looks like network is still not functional on SDP4430. different issue

Oh so Ethernet does not work either? What's wrong with that?

Regards,

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:00   ` Tony Lindgren
@ 2010-05-20  1:03     ` Nishanth Menon
  2010-05-20  1:06       ` Tony Lindgren
  0 siblings, 1 reply; 16+ messages in thread
From: Nishanth Menon @ 2010-05-20  1:03 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Paul Walmsley

Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
> * Nishanth Menon <nm@ti.com> [100519 12:56]:
>> looks like network is still not functional on SDP4430. different issue
> 
> Oh so Ethernet does not work either? What's wrong with that?
I was told offline that the driver is somewhere in the net ML on the way 
I believe in parallel.. I dont have collaborative links though :(

Santosh,
Can you point out the status?

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:03     ` Nishanth Menon
@ 2010-05-20  1:06       ` Tony Lindgren
  2010-05-20  1:09         ` Nishanth Menon
  0 siblings, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2010-05-20  1:06 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Paul Walmsley

* Nishanth Menon <nm@ti.com> [100519 17:58]:
> Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
> >* Nishanth Menon <nm@ti.com> [100519 12:56]:
> >>looks like network is still not functional on SDP4430. different issue
> >
> >Oh so Ethernet does not work either? What's wrong with that?
> I was told offline that the driver is somewhere in the net ML on the
> way I believe in parallel.. I dont have collaborative links though
> :(
> 
> Santosh,
> Can you point out the status?

I thought I have those in omap-testing and merged into the master
branch in linux-omap:

ks8851: Add caching of CCR register
ks8851: Low level functions for read/write to companion eeprom
ks8851: companion eeprom access through ethtool

Regards,

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:06       ` Tony Lindgren
@ 2010-05-20  1:09         ` Nishanth Menon
  2010-05-20  1:24           ` Tony Lindgren
  0 siblings, 1 reply; 16+ messages in thread
From: Nishanth Menon @ 2010-05-20  1:09 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Paul Walmsley

Tony Lindgren had written, on 05/19/2010 08:06 PM, the following:
> * Nishanth Menon <nm@ti.com> [100519 17:58]:
>> Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
>>> * Nishanth Menon <nm@ti.com> [100519 12:56]:
>>>> looks like network is still not functional on SDP4430. different issue
>>> Oh so Ethernet does not work either? What's wrong with that?
>> I was told offline that the driver is somewhere in the net ML on the
>> way I believe in parallel.. I dont have collaborative links though
>> :(
>>
>> Santosh,
>> Can you point out the status?
> 
> I thought I have those in omap-testing and merged into the master
> branch in linux-omap:
> 
> ks8851: Add caching of CCR register
> ks8851: Low level functions for read/write to companion eeprom
> ks8851: companion eeprom access through ethtool
Okay then it makes this an operator error - I have been playing with 
vanilla linus 2.6.34 tree and adding just the basic patches I need.. I 
can give the omap-testing a whirl..

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:09         ` Nishanth Menon
@ 2010-05-20  1:24           ` Tony Lindgren
  2010-05-20  1:49             ` Nishanth Menon
  0 siblings, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2010-05-20  1:24 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Paul Walmsley

* Nishanth Menon <nm@ti.com> [100519 18:03]:
> Tony Lindgren had written, on 05/19/2010 08:06 PM, the following:
> >* Nishanth Menon <nm@ti.com> [100519 17:58]:
> >>Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
> >>>* Nishanth Menon <nm@ti.com> [100519 12:56]:
> >>>>looks like network is still not functional on SDP4430. different issue
> >>>Oh so Ethernet does not work either? What's wrong with that?
> >>I was told offline that the driver is somewhere in the net ML on the
> >>way I believe in parallel.. I dont have collaborative links though
> >>:(
> >>
> >>Santosh,
> >>Can you point out the status?
> >
> >I thought I have those in omap-testing and merged into the master
> >branch in linux-omap:
> >
> >ks8851: Add caching of CCR register
> >ks8851: Low level functions for read/write to companion eeprom
> >ks8851: companion eeprom access through ethtool
> Okay then it makes this an operator error - I have been playing with
> vanilla linus 2.6.34 tree and adding just the basic patches I need..
> I can give the omap-testing a whirl..

OK, cool.

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:24           ` Tony Lindgren
@ 2010-05-20  1:49             ` Nishanth Menon
  2010-05-20  4:57               ` Shilimkar, Santosh
  2010-05-20 10:28               ` Shilimkar, Santosh
  0 siblings, 2 replies; 16+ messages in thread
From: Nishanth Menon @ 2010-05-20  1:49 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Paul Walmsley

Tony Lindgren had written, on 05/19/2010 08:24 PM, the following:
> * Nishanth Menon <nm@ti.com> [100519 18:03]:
>> Tony Lindgren had written, on 05/19/2010 08:06 PM, the following:
>>> * Nishanth Menon <nm@ti.com> [100519 17:58]:
>>>> Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
>>>>> * Nishanth Menon <nm@ti.com> [100519 12:56]:
>>>>>> looks like network is still not functional on SDP4430. different issue
>>>>> Oh so Ethernet does not work either? What's wrong with that?
>>>> I was told offline that the driver is somewhere in the net ML on the
>>>> way I believe in parallel.. I dont have collaborative links though
>>>> :(
>>>>
>>>> Santosh,
>>>> Can you point out the status?
>>> I thought I have those in omap-testing and merged into the master
>>> branch in linux-omap:
>>>
>>> ks8851: Add caching of CCR register
>>> ks8851: Low level functions for read/write to companion eeprom
>>> ks8851: companion eeprom access through ethtool
>> Okay then it makes this an operator error - I have been playing with
>> vanilla linus 2.6.34 tree and adding just the basic patches I need..
>> I can give the omap-testing a whirl..
> 
> OK, cool.
tried with omap_testing i pulled a few mins back, omap3_defconfig with 
CONFIG_EARLY_PRINTK enabled
Good news:
need as pointed out by Santosh -
a) http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27363.html
b) this patch for NFS even to try.

Bad news: Same results I got as in linus tree - NAK for NFS booting :(
full log: http://pastebin.mozilla.org/725960
from the log, I dont see the driver probe even starting up or any 
reports as you posted above (which I guess is from Blaze)..

-- 
Regards,
Nishanth Menon

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:49             ` Nishanth Menon
@ 2010-05-20  4:57               ` Shilimkar, Santosh
  2010-05-20 10:30                 ` Arce, Abraham
  2010-05-20 10:28               ` Shilimkar, Santosh
  1 sibling, 1 reply; 16+ messages in thread
From: Shilimkar, Santosh @ 2010-05-20  4:57 UTC (permalink / raw)
  To: Menon, Nishanth, Tony Lindgren; +Cc: linux-omap@vger.kernel.org, Paul Walmsley

> -----Original Message-----
> From: Menon, Nishanth
> Sent: Thursday, May 20, 2010 7:19 AM
> To: Tony Lindgren
> Cc: Shilimkar, Santosh; linux-omap@vger.kernel.org; Paul Walmsley
> Subject: Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
> 
> Tony Lindgren had written, on 05/19/2010 08:24 PM, the following:
> > * Nishanth Menon <nm@ti.com> [100519 18:03]:
> >> Tony Lindgren had written, on 05/19/2010 08:06 PM, the following:
> >>> * Nishanth Menon <nm@ti.com> [100519 17:58]:
> >>>> Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
> >>>>> * Nishanth Menon <nm@ti.com> [100519 12:56]:
> >>>>>> looks like network is still not functional on SDP4430. different issue
> >>>>> Oh so Ethernet does not work either? What's wrong with that?
> >>>> I was told offline that the driver is somewhere in the net ML on the
> >>>> way I believe in parallel.. I dont have collaborative links though
> >>>> :(
> >>>>
> >>>> Santosh,
> >>>> Can you point out the status?
> >>> I thought I have those in omap-testing and merged into the master
> >>> branch in linux-omap:
> >>>
> >>> ks8851: Add caching of CCR register
> >>> ks8851: Low level functions for read/write to companion eeprom
> >>> ks8851: companion eeprom access through ethtool
> >> Okay then it makes this an operator error - I have been playing with
> >> vanilla linus 2.6.34 tree and adding just the basic patches I need..
> >> I can give the omap-testing a whirl..
> >
> > OK, cool.
> tried with omap_testing i pulled a few mins back, omap3_defconfig with
> CONFIG_EARLY_PRINTK enabled
> Good news:
> need as pointed out by Santosh -
> a) http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27363.html
> b) this patch for NFS even to try.
> 
> Bad news: Same results I got as in linus tree - NAK for NFS booting :(
> full log: http://pastebin.mozilla.org/725960
> from the log, I dont see the driver probe even starting up or any
> reports as you posted above (which I guess is from Blaze)..
> 
As Tony pointed out, those patches are enough to get ethernet working.

Regards,
Santosh

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-19 23:10 ` Paul Walmsley
@ 2010-05-20  4:58   ` Shilimkar, Santosh
  2010-05-31 12:48   ` Tony Lindgren
  1 sibling, 0 replies; 16+ messages in thread
From: Shilimkar, Santosh @ 2010-05-20  4:58 UTC (permalink / raw)
  To: Paul Walmsley, Menon, Nishanth; +Cc: linux-omap@vger.kernel.org

> -----Original Message-----
> From: Paul Walmsley [mailto:paul@pwsan.com]
> Sent: Thursday, May 20, 2010 4:41 AM
> To: Shilimkar, Santosh; Menon, Nishanth
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
> 
> Hi,
> 
> On Wed, 19 May 2010, Santosh Shilimkar wrote:
> 
> > This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> > to avoid the emif clk getting cut as part of reset un-used clock
> > routine which prevents boot.
> >
> > Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> > which increases the usecount on all ENABLE_ON_INIT clocks, it
> > prevents "omap2_clk_disable_unused()" from disabling the clock.
> >
> > The real fix is to have driver for EMIF and do clock get/enable
> > as part of it. The EMIF driver is planned to be done HWMOD way
> > so till that available to keep omap3_defconfig booting on OMAP4430,
> > this patch is necessary.
> > (Will updated the auto-gen script for 44xx accordingly)
> >
> > The fix was suggested by Paul Walmsley
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> 
> Thanks, I've added Nishanth's Tested-by: and fixed the patch changelog;
> the following patch is now queued for 2.6.35-rc, unless there are any
> further comments.
> 
Thanks Paul.

Regards,
Santosh

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  1:49             ` Nishanth Menon
  2010-05-20  4:57               ` Shilimkar, Santosh
@ 2010-05-20 10:28               ` Shilimkar, Santosh
  1 sibling, 0 replies; 16+ messages in thread
From: Shilimkar, Santosh @ 2010-05-20 10:28 UTC (permalink / raw)
  To: Menon, Nishanth, Tony Lindgren; +Cc: linux-omap@vger.kernel.org, Paul Walmsley

 -----Original Message-----
> From: Menon, Nishanth
> Sent: Thursday, May 20, 2010 7:19 AM
> To: Tony Lindgren
> Cc: Shilimkar, Santosh; linux-omap@vger.kernel.org; Paul Walmsley
> Subject: Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
> 
> Tony Lindgren had written, on 05/19/2010 08:24 PM, the following:
> > * Nishanth Menon <nm@ti.com> [100519 18:03]:
> >> Tony Lindgren had written, on 05/19/2010 08:06 PM, the following:
> >>> * Nishanth Menon <nm@ti.com> [100519 17:58]:
> >>>> Tony Lindgren had written, on 05/19/2010 08:00 PM, the following:
> >>>>> * Nishanth Menon <nm@ti.com> [100519 12:56]:
> >>>>>> looks like network is still not functional on SDP4430. different issue
> >>>>> Oh so Ethernet does not work either? What's wrong with that?
> >>>> I was told offline that the driver is somewhere in the net ML on the
> >>>> way I believe in parallel.. I dont have collaborative links though
> >>>> :(
> >>>>
> >>>> Santosh,
> >>>> Can you point out the status?
> >>> I thought I have those in omap-testing and merged into the master
> >>> branch in linux-omap:
> >>>
> >>> ks8851: Add caching of CCR register
> >>> ks8851: Low level functions for read/write to companion eeprom
> >>> ks8851: companion eeprom access through ethtool
> >> Okay then it makes this an operator error - I have been playing with
> >> vanilla linus 2.6.34 tree and adding just the basic patches I need..
> >> I can give the omap-testing a whirl..
> >
> > OK, cool.
> tried with omap_testing i pulled a few mins back, omap3_defconfig with
> CONFIG_EARLY_PRINTK enabled
> Good news:
> need as pointed out by Santosh -
> a) http://www.mail-archive.com/linux-omap@vger.kernel.org/msg27363.html
> b) this patch for NFS even to try.
> 
> Bad news: Same results I got as in linus tree - NAK for NFS booting :(
> full log: http://pastebin.mozilla.org/725960
> from the log, I dont see the driver probe even starting up or any
> reports as you posted above (which I guess is from Blaze)..
> 
Tried LO master and networks works great.

******************************************************
Texas Instruments X-Loader 1.41 (Jan 17 2010 - 23:12:44)
Starting OS Bootloader from EMMC ...


U-Boot 1.1.4-g0aa2aebd-dirty (Feb  6 2010 - 17:10:35)

Load address: 0x80e80000
DRAM:  512 MB
Flash:  0 kB
*** Warning - bad CRC, using default environment

In:    serial
Out:   serial
Err:   serial
Net:   Micrel KS8851SNL
OMAP44XX SDP # t;bootm

ks8851snl ethernet initialized
ethaddr rom: 00:08:01:28:43:4D
port status information = 0x8400
BOOTP broadcast 1
Using Micrel KS8851SN device
TFTP from server 172.24.190.46; our IP address is 172.24.190.176
Filename 'santosh/uImage'.
Load address: 0x90300000
Loading: T #################################################################
         #################################################################
         #################################################################
         #################################################################
         #################################################################
         ######
done
Bytes transferred = 1690656 (19cc20 hex)
## Booting image at 90300000 ...
   Image Name:   Linux-2.6.34-08151-g1674c0c
   Image Type:   ARM Linux Kernel Image (uncompressed)
   Data Size:    1690592 Bytes =  1.6 MB
   Load Address: 80008000
   Entry Point:  80008000
   Verifying Checksum ... OK
OK

Starting kernel ...

Uncompressing Linux... done, booting the kernel.
Linux version 2.6.34-08151-g1674c0c (a0393909@a0393909-desktop) (gcc version 4.3.3 (Sourcery G++ Lite 2009q1-203) ) #1 SMP PREEMPT Thu May 20 15:50:53 IST 2010
CPU: ARMv7 Processor [410fc091] revision 1 (ARMv7), cr=10c53c7f
CPU: VIPT nonaliasing data cache, VIPT nonaliasing instruction cache
Machine: OMAP4430 4430SDP board
Memory policy: ECC disabled, Data cache writealloc
OMAP4430 ES1.0
SRAM: Mapped pa 0x40300000 to va 0xfe400000 size: 0x100000
FIXME: omap44xx_sram_init not implemented
PERCPU: Embedded 6 pages/cpu @c0715000 s3584 r8192 d12800 u65536
pcpu-alloc: s3584 r8192 d12800 u65536 alloc=16*4096
pcpu-alloc: [0] 0 [0] 1
Built 1 zonelists in Zone order, mobility grouping on.  Total pages: 117602
Kernel command line: mem=463M console=ttyS2,115200n8 noinitrd rootdelay=1 root=/dev/nfs rw nfsroot=172.24.190.46:/ubuntu/nfs-share/omap4_next ,nolock,tcp,rsize=1024,wsize=1024 ip=dhcp
PID hash table entries: 2048 (order: 1, 8192 bytes)
Dentry cache hash table entries: 65536 (order: 6, 262144 bytes)
Inode-cache hash table entries: 32768 (order: 5, 131072 bytes)
Memory: 463MB = 463MB total
Memory: 466420k/466420k available, 7692k reserved, 0K highmem
Virtual kernel memory layout:
    vector  : 0xffff0000 - 0xffff1000   (   4 kB)
    fixmap  : 0xfff00000 - 0xfffe0000   ( 896 kB)
    DMA     : 0xffc00000 - 0xffe00000   (   2 MB)
    vmalloc : 0xdd000000 - 0xf8000000   ( 432 MB)
    lowmem  : 0xc0000000 - 0xdcf00000   ( 463 MB)
    modules : 0xbf000000 - 0xc0000000   (  16 MB)
      .init : 0xc0008000 - 0xc002a000   ( 136 kB)
      .text : 0xc002a000 - 0xc0326000   (3056 kB)
      .data : 0xc0326000 - 0xc0357200   ( 197 kB)
SLUB: Genslabs=11, HWalign=32, Order=0-3, MinObjects=0, CPUs=2, Nodes=1
Hierarchical RCU implementation.
NR_IRQS:388
GPMC revision 6.0
OMAP GPIO hardware version 0.1
OMAP clockevent source: GPTIMER1 at 32768 Hz
Console: colour dummy device 80x30
Calibrating delay loop... 1195.29 BogoMIPS (lpj=4669440)
Mount-cache hash table entries: 512
CPU: Testing write buffer coherency: ok
L2X0 cache controller enabled
CPU1: Booted secondary processor
Brought up 2 CPUs
SMP: Total of 2 processors activated (2395.78 BogoMIPS).
regulator: core version 0.5
NET: Registered protocol family 16
OMAP DMA hardware revision 0.0
bio: create slab <bio-0> at 0
i2c_omap i2c_omap.1: bus 1 rev4.0 at 400 kHz
Skipping twl internal clock init and using bootloader value (unknown osc rate)
twl6030: PIH (irq 39) chaining IRQs 368..387
regulator: VMMC: 1200 <--> 3000 mV at 1800 mV normal standby
regulator: VPP: 1800 <--> 2500 mV at 1900 mV normal standby
regulator: VUSIM: 1200 <--> 2900 mV at 1800 mV normal standby
regulator: VANA: 2100 mV normal standby
regulator: VCXIO: 1800 mV normal standby
regulator: VDAC: 1800 mV normal standby
regulator: VUSB: 3300 mV normal standby
regulator: VAUX1_6030: 1000 <--> 3000 mV at 2800 mV normal standby
regulator: VAUX2_6030: 1200 <--> 2800 mV at 1800 mV normal standby
regulator: VAUX3_6030: 1000 <--> 3000 mV at 1200 mV normal standby
i2c_omap i2c_omap.2: bus 2 rev4.0 at 400 kHz
i2c_omap i2c_omap.3: bus 3 rev4.0 at 400 kHz
i2c_omap i2c_omap.4: bus 4 rev4.0 at 400 kHz
Switching to clocksource 32k_counter
NET: Registered protocol family 2
IP route cache hash table entries: 4096 (order: 2, 16384 bytes)
TCP established hash table entries: 16384 (order: 5, 131072 bytes)
TCP bind hash table entries: 16384 (order: 5, 196608 bytes)
TCP: Hash tables configured (established 16384 bind 16384)
TCP reno registered
UDP hash table entries: 256 (order: 1, 8192 bytes)
UDP-Lite hash table entries: 256 (order: 1, 8192 bytes)
RPC: Registered udp transport module.
RPC: Registered tcp transport module.
RPC: Registered tcp NFSv4.1 backchannel transport module.
VFS: Disk quotas dquot_6.5.2
Dquot-cache hash table entries: 1024 (order 0, 4096 bytes)
msgmni has been set to 910
alg: No test for stdrng (krng)
io scheduler noop registered
io scheduler deadline registered
io scheduler cfq registered (default)
Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled
serial8250.0: ttyS0 at MMIO 0x4806a000 (irq = 104) is a ST16654
serial8250.1: ttyS1 at MMIO 0x4806c000 (irq = 105) is a ST16654
serial8250.2: ttyS2 at MMIO 0x48020000 (irq = 106) is a ST16654
console [ttyS2] enabled
brd: module loaded
loop: module loaded
ks8851 spi1.0: message enable is 0
ks8851 spi1.0: revision 0, MAC ca:91:27:37:f5:4e, IRQ 194
twl_rtc twl_rtc: rtc core: registered twl_rtc as rtc0
twl_rtc twl_rtc: Power up reset detected.
twl_rtc twl_rtc: Enabling TWL-RTC.
i2c /dev entries driver
OMAP Watchdog Timer Rev 0x00: initial timeout 60 sec
TCP cubic registered
NET: Registered protocol family 17
VFP support v0.3: implementor 41 architecture 3 part 30 variant 9 rev 0
regulator_init_complete: incomplete constraints, leaving VAUX3_6030 on
regulator_init_complete: incomplete constraints, leaving VAUX2_6030 on
regulator_init_complete: incomplete constraints, leaving VAUX1_6030 on
regulator_init_complete: incomplete constraints, leaving VUSB on
regulator_init_complete: incomplete constraints, leaving VDAC on
regulator_init_complete: incomplete constraints, leaving VCXIO on
regulator_init_complete: incomplete constraints, leaving VANA on
regulator_init_complete: incomplete constraints, leaving VUSIM on
regulator_init_complete: incomplete constraints, leaving VPP on
twl_rtc twl_rtc: hctosys: invalid date/time
mmc1: new high speed MMC card at address 0001
mmcblk0: mmc1:0001 MMC32G 29.8 GiB
 mmcblk0: p1
Sending DHCP requests .., OK
IP-Config: Got DHCP answer from 0.0.0.0, my address is 172.24.191.10
IP-Config: Complete:
     device=eth0, addr=172.24.191.10, mask=255.255.252.0, gw=172.24.188.1,
     host=172.24.191.10, domain=india.ti.com, nis-domain=(none),
     bootserver=0.0.0.0, rootserver=172.24.190.46, rootpath=
Waiting 1sec before mounting root device...
Looking up port of RPC 100003/2 on 172.24.190.46
Looking up port of RPC 100005/1 on 172.24.190.46
VFS: Mounted root (nfs filesystem) on device 0:10.
Freeing init memory: 136K
Mounting proc : OK
Mounting sysfs : OK
Mounting /dev : OK
Creating local mdev devices
umount: can't umount /mnt/mmc: Invalid argument

******************************************
Starting System Init for 4430SDP-4430
******************************************
Saving kernel ring buffer : OK
Mounting devpts : OK
Setting up networking
Configuring lo : OK
Configuring eth0 : OK - 172.24.191.10
Starting telnetd : OK
Starting syslogd : OK
Starting klogd : OK
Mounting filesystems : OK

Please press Enter to activate this console.
#
******************************************************

^ permalink raw reply	[flat|nested] 16+ messages in thread

* RE: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-20  4:57               ` Shilimkar, Santosh
@ 2010-05-20 10:30                 ` Arce, Abraham
  0 siblings, 0 replies; 16+ messages in thread
From: Arce, Abraham @ 2010-05-20 10:30 UTC (permalink / raw)
  To: Shilimkar, Santosh, Menon, Nishanth, Tony Lindgren
  Cc: linux-omap@vger.kernel.org, Paul Walmsley

Hi,

> > Bad news: Same results I got as in linus tree - NAK for NFS booting :(
> > full log: http://pastebin.mozilla.org/725960
> > from the log, I dont see the driver probe even starting up or any
> > reports as you posted above (which I guess is from Blaze)..
> >
> As Tony pointed out, those patches are enough to get ethernet working.
> 

>From my side... this is the latest commit...

  commit 7b93a0d31f28bd6e531bae7f59716a04d943fe8d
  Author: Tony Lindgren <tony@atomide.com>
  Date:   Wed May 19 17:41:36 2010 -0700
      Linux-omap rebuilt: Updated with final patches queued into for-next

One extra macro for my old filesystem
  CONFIG_SYSFS_DEPRECATED_V2

My bootargs

  setenv bootargs mem=255M console=ttyS2,115200n8 noinitrd root=/dev/nfs rw nfsroot=10.87.231.229:/data/EVM_filesystems/x0066660/filesystem/target.clean,nolock,tcp,rsize=8192,wsize=8192 ip=dhcp

Let us know if this works...

Best Regards
Abraham

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-19 23:10 ` Paul Walmsley
  2010-05-20  4:58   ` Shilimkar, Santosh
@ 2010-05-31 12:48   ` Tony Lindgren
  2010-06-16  9:22     ` Paul Walmsley
  1 sibling, 1 reply; 16+ messages in thread
From: Tony Lindgren @ 2010-05-31 12:48 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: Santosh Shilimkar, Nishanth Menon, linux-omap

* Paul Walmsley <paul@pwsan.com> [100520 02:05]:
> Hi,
> 
> On Wed, 19 May 2010, Santosh Shilimkar wrote:
> 
> > This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> > to avoid the emif clk getting cut as part of reset un-used clock
> > routine which prevents boot.
> > 
> > Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> > which increases the usecount on all ENABLE_ON_INIT clocks, it
> > prevents "omap2_clk_disable_unused()" from disabling the clock.
> > 
> > The real fix is to have driver for EMIF and do clock get/enable
> > as part of it. The EMIF driver is planned to be done HWMOD way
> > so till that available to keep omap3_defconfig booting on OMAP4430,
> > this patch is necessary.
> > (Will updated the auto-gen script for 44xx accordingly)
> > 
> > The fix was suggested by Paul Walmsley
> > 
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> 
> Thanks, I've added Nishanth's Tested-by: and fixed the patch changelog; 
> the following patch is now queued for 2.6.35-rc, unless there are any 
> further comments.

FYI, I'll also added this into omap-testing branch while we're waiting
for your clock fixes branch to be available.

Regards,

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-05-31 12:48   ` Tony Lindgren
@ 2010-06-16  9:22     ` Paul Walmsley
  2010-06-16 16:09       ` Tony Lindgren
  0 siblings, 1 reply; 16+ messages in thread
From: Paul Walmsley @ 2010-06-16  9:22 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: Santosh Shilimkar, Nishanth Menon, linux-omap

On Mon, 31 May 2010, Tony Lindgren wrote:

> * Paul Walmsley <paul@pwsan.com> [100520 02:05]:
> > Hi,
> > 
> > On Wed, 19 May 2010, Santosh Shilimkar wrote:
> > 
> > > This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> > > to avoid the emif clk getting cut as part of reset un-used clock
> > > routine which prevents boot.
> > > 
> > > Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> > > which increases the usecount on all ENABLE_ON_INIT clocks, it
> > > prevents "omap2_clk_disable_unused()" from disabling the clock.
> > > 
> > > The real fix is to have driver for EMIF and do clock get/enable
> > > as part of it. The EMIF driver is planned to be done HWMOD way
> > > so till that available to keep omap3_defconfig booting on OMAP4430,
> > > this patch is necessary.
> > > (Will updated the auto-gen script for 44xx accordingly)
> > > 
> > > The fix was suggested by Paul Walmsley
> > > 
> > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > > Cc: Paul Walmsley <paul@pwsan.com>
> > 
> > Thanks, I've added Nishanth's Tested-by: and fixed the patch changelog; 
> > the following patch is now queued for 2.6.35-rc, unless there are any 
> > further comments.
> 
> FYI, I'll also added this into omap-testing branch while we're waiting
> for your clock fixes branch to be available.

Acked-by: Paul Walmsley <paul@pwsan.com>

Feel free to send this one upstream separately if you like, until the 
clock -rc series is ready.


- Paul

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
  2010-06-16  9:22     ` Paul Walmsley
@ 2010-06-16 16:09       ` Tony Lindgren
  0 siblings, 0 replies; 16+ messages in thread
From: Tony Lindgren @ 2010-06-16 16:09 UTC (permalink / raw)
  To: Paul Walmsley; +Cc: Santosh Shilimkar, Nishanth Menon, linux-omap

* Paul Walmsley <paul@pwsan.com> [100616 12:16]:
> On Mon, 31 May 2010, Tony Lindgren wrote:
> 
> > * Paul Walmsley <paul@pwsan.com> [100520 02:05]:
> > > Hi,
> > > 
> > > On Wed, 19 May 2010, Santosh Shilimkar wrote:
> > > 
> > > > This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> > > > to avoid the emif clk getting cut as part of reset un-used clock
> > > > routine which prevents boot.
> > > > 
> > > > Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> > > > which increases the usecount on all ENABLE_ON_INIT clocks, it
> > > > prevents "omap2_clk_disable_unused()" from disabling the clock.
> > > > 
> > > > The real fix is to have driver for EMIF and do clock get/enable
> > > > as part of it. The EMIF driver is planned to be done HWMOD way
> > > > so till that available to keep omap3_defconfig booting on OMAP4430,
> > > > this patch is necessary.
> > > > (Will updated the auto-gen script for 44xx accordingly)
> > > > 
> > > > The fix was suggested by Paul Walmsley
> > > > 
> > > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > > > Cc: Paul Walmsley <paul@pwsan.com>
> > > 
> > > Thanks, I've added Nishanth's Tested-by: and fixed the patch changelog; 
> > > the following patch is now queued for 2.6.35-rc, unless there are any 
> > > further comments.
> > 
> > FYI, I'll also added this into omap-testing branch while we're waiting
> > for your clock fixes branch to be available.
> 
> Acked-by: Paul Walmsley <paul@pwsan.com>
> 
> Feel free to send this one upstream separately if you like, until the 
> clock -rc series is ready.

OK, thanks, will add into omap-fixes-for-linus.

Regards,

Tony

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2010-06-16 16:09 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-19 16:38 [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks Santosh Shilimkar
2010-05-19 20:01 ` Nishanth Menon
2010-05-20  1:00   ` Tony Lindgren
2010-05-20  1:03     ` Nishanth Menon
2010-05-20  1:06       ` Tony Lindgren
2010-05-20  1:09         ` Nishanth Menon
2010-05-20  1:24           ` Tony Lindgren
2010-05-20  1:49             ` Nishanth Menon
2010-05-20  4:57               ` Shilimkar, Santosh
2010-05-20 10:30                 ` Arce, Abraham
2010-05-20 10:28               ` Shilimkar, Santosh
2010-05-19 23:10 ` Paul Walmsley
2010-05-20  4:58   ` Shilimkar, Santosh
2010-05-31 12:48   ` Tony Lindgren
2010-06-16  9:22     ` Paul Walmsley
2010-06-16 16:09       ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).