From: Eduardo Valentin <eduardo.valentin@nokia.com>
To: ext Jarkko Nikula <jhnikula@gmail.com>
Cc: "Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] omap: rx51: Add supplies and data for the tpa6130a2 headphone amplifier
Date: Thu, 20 May 2010 11:07:44 +0300 [thread overview]
Message-ID: <20100520080743.GA12568@besouro.research.nokia.com> (raw)
In-Reply-To: <20100518205109.19e8ca86.jhnikula@gmail.com>
On Tue, May 18, 2010 at 07:51:09PM +0200, Jarkko Nikula wrote:
> On Tue, 18 May 2010 15:48:48 +0300
> Eduardo Valentin <eduardo.valentin@nokia.com> wrote:
>
> > > @@ -285,6 +287,9 @@ static struct regulator_consumer_supply rx51_vmmc2_supplies[] = {
> > > /* tlv320aic3x analog supplies */
> > > REGULATOR_SUPPLY("AVDD", "2-0018"),
> > > REGULATOR_SUPPLY("DRVDD", "2-0018"),
> > > + /* tpa6130a2 */
> > > + REGULATOR_SUPPLY("CPVSS", "2-0060"),
> >
> > Isn't CPVSS grounded? Well that wouldn't hurt to put it here, but it doesnt belong to vmmc2 though.
> >
> Thanks Eduardo! For me it looks this CPVSS supply is miss-added to the
> tpa6130a2 as spec says for this pin:
>
> "Negative supply generated by the charge pump. Decouple to pin 19 on
> the QFN or a CPVSS B2 15, 16 P GND plane. Use a 1 μF capacitor."
right.
>
> I'll send a fix first to the tpa6130a2 and repost this one after that.
OK. good.
>
>
> --
> Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-05-20 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 11:06 [PATCH 1/2] omap: rx51: Use REGULATOR_SUPPLY macro when initializing regulator consumers Jarkko Nikula
2010-05-18 11:06 ` [PATCH 2/2] omap: rx51: Add supplies and data for the tpa6130a2 headphone amplifier Jarkko Nikula
2010-05-18 12:48 ` Eduardo Valentin
2010-05-18 17:51 ` Jarkko Nikula
2010-05-20 8:07 ` Eduardo Valentin [this message]
2010-05-18 12:09 ` [PATCH 1/2] omap: rx51: Use REGULATOR_SUPPLY macro when initializing regulator consumers Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520080743.GA12568@besouro.research.nokia.com \
--to=eduardo.valentin@nokia.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).