From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [PATCH 2/2] omap: rx51: Add supplies and data for the tpa6130a2 headphone amplifier Date: Thu, 20 May 2010 11:07:44 +0300 Message-ID: <20100520080743.GA12568@besouro.research.nokia.com> References: <1274180761-14221-1-git-send-email-jhnikula@gmail.com> <1274180761-14221-2-git-send-email-jhnikula@gmail.com> <20100518124848.GA4265@besouro.research.nokia.com> <20100518205109.19e8ca86.jhnikula@gmail.com> Reply-To: eduardo.valentin@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.nokia.com ([192.100.122.230]:55053 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751780Ab0ETICY (ORCPT ); Thu, 20 May 2010 04:02:24 -0400 Content-Disposition: inline In-Reply-To: <20100518205109.19e8ca86.jhnikula@gmail.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Jarkko Nikula Cc: "Valentin Eduardo (Nokia-D/Helsinki)" , "linux-omap@vger.kernel.org" , Tony Lindgren On Tue, May 18, 2010 at 07:51:09PM +0200, Jarkko Nikula wrote: > On Tue, 18 May 2010 15:48:48 +0300 > Eduardo Valentin wrote: >=20 > > > @@ -285,6 +287,9 @@ static struct regulator_consumer_supply rx51_= vmmc2_supplies[] =3D { > > > /* tlv320aic3x analog supplies */ > > > REGULATOR_SUPPLY("AVDD", "2-0018"), > > > REGULATOR_SUPPLY("DRVDD", "2-0018"), > > > + /* tpa6130a2 */ > > > + REGULATOR_SUPPLY("CPVSS", "2-0060"), > >=20 > > Isn't CPVSS grounded? Well that wouldn't hurt to put it here, but i= t doesnt belong to vmmc2 though. > >=20 > Thanks Eduardo! For me it looks this CPVSS supply is miss-added to th= e > tpa6130a2 as spec says for this pin: >=20 > "Negative supply generated by the charge pump. Decouple to pin 19 on > the QFN or a CPVSS B2 15, 16 P GND plane. Use a 1 =CE=BCF capacitor." right. >=20 > I'll send a fix first to the tpa6130a2 and repost this one after that= =2E OK. good. >=20 >=20 > --=20 > Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html