From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 6) Date: Thu, 20 May 2010 21:50:57 +0300 Message-ID: <20100520185057.GA25089@gandalf> References: <4BF51C9D.8050406@nt.tu-darmstadt.de> <15003.23611.qm@web180316.mail.gq1.yahoo.com> Reply-To: me@felipebalbi.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <15003.23611.qm@web180316.mail.gq1.yahoo.com> Sender: linux-kernel-owner@vger.kernel.org To: David Brownell Cc: felipe.balbi@nokia.com, Vladimir Pantelic , Matthew Garrett , "me@felipebalbi.com" , Theodore Ts'o , Brian Swetland , Mark Brown , Geoff Smith , Kernel development list , Linus Torvalds , Oleg Nesterov , Tejun Heo , Linux-pm mailing list , "linux-omap@vger.kernel.org" , Liam Girdwood , Andrew Morton , Arjan van de Ven List-Id: linux-omap@vger.kernel.org On Thu, May 20, 2010 at 10:40:17AM -0700, David Brownell wrote: > Some apps do abuse kernel mechanisms, and whether the bug is in the > app or that kernel mechanism can be a judgement call. I'd expect to hey come on, there's no judgement call for an app polling every second to check battery status or some other status that doesn't change that frequently. > I may have overlooked it, in one of the 100K messsages in my mailbox > about versions of suspend block/etc patches ... > > But surely NOBODY is actually contending that broken aps NOT get > fixed?? > > It's clear to me that tools are needed to identify power hogs; > powertop can't be the extent of such tools. (ISTR it doesn't monitor > display power usage, for one thing; maybe newer versions do so.) Once > such hogs get identified they will need to get fixed. Any other > proposal seems broken to me... that's my feeling too. I don't see any needs for suspend blockers in any real system. I acknowledge we need tools probing power consumption to be shipped to production device, that's a good idea, but forcing apps to modify just to have that UI fill up some treeview, I think it's a bit too much. -- balbi