From mboxrd@z Thu Jan  1 00:00:00 1970
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3 10/14] omap: mailbox: reorganize registering
Date: Mon, 24 May 2010 19:32:49 +0100
Message-ID: <20100524183249.GF21117@n2100.arm.linux.org.uk>
References: <1274548465-20208-1-git-send-email-felipe.contreras@gmail.com> <1274548465-20208-11-git-send-email-felipe.contreras@gmail.com> <20100524.182407.67910029.Hiroshi.DOYU@nokia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-omap-owner@vger.kernel.org>
Received: from caramon.arm.linux.org.uk ([78.32.30.218]:60967 "EHLO
	caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757681Ab0EXSdL (ORCPT
	<rfc822;linux-omap@vger.kernel.org>); Mon, 24 May 2010 14:33:11 -0400
Content-Disposition: inline
In-Reply-To: <20100524.182407.67910029.Hiroshi.DOYU@nokia.com>
Sender: linux-omap-owner@vger.kernel.org
List-Id: linux-omap@vger.kernel.org
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: felipe.contreras@gmail.com, tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org

On Mon, May 24, 2010 at 06:24:07PM +0300, Hiroshi DOYU wrote:
> From: ext Felipe Contreras <felipe.contreras@gmail.com>
> Subject: [PATCH v3 10/14] omap: mailbox: reorganize registering
> Date: Sat, 22 May 2010 19:14:21 +0200
> 
> > platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	if (unlikely(!res)) {
> > -		dev_err(&pdev->dev, "invalid mem resource\n");
> > -		return -ENODEV;
> > -	}
> > +	res = pdev->resource;
> 
> why not?
> 
> 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

I agree - always use the accessors provided rather than going beneath
the covers and fiddling directly with stuff inside objects.