From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8) Date: Thu, 27 May 2010 19:14:33 +0100 Message-ID: <20100527181433.GG3543@srcf.ucam.org> References: <1274982779.27810.5708.camel@twins> <20100527175719.GD3543@srcf.ucam.org> <1274983333.27810.5744.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:41659 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754644Ab0E0SOp (ORCPT ); Thu, 27 May 2010 14:14:45 -0400 Content-Disposition: inline In-Reply-To: <1274983333.27810.5744.camel@twins> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Peter Zijlstra Cc: Alan Stern , Thomas Gleixner , Paul@smtp1.linux-foundation.org, LKML , Florian Mickler , felipe.balbi@nokia.com, Linux OMAP Mailing List , Linux PM , Alan Cox On Thu, May 27, 2010 at 08:02:13PM +0200, Peter Zijlstra wrote: > On Thu, 2010-05-27 at 18:57 +0100, Matthew Garrett wrote: > > If you want to support forced suspend for laptops and you want to avoid > > the risk of losing wakeups then you need in-kernel suspend blockers. > > That's entirely orthogonal to Android's runtime power management. > > The simple fact of life is, on PC style hardware suspend is mostly about > missing events. I really _really_ want to miss mouse movement of my > bluetooth mouse when the gear is stowed in my backpack. That's fine - those shouldn't be configured as wakeup events. > Its perfectly OK to miss events on _forced_ suspend. No, it's not. Forced suspend may be in response to hitting a key, but it may also be in response to a 30 minute timeout expiring. If I get a WoL packet in the 0.5 of a second between userspace deciding to suspend and actually doing so, the system shouldn't suspend. -- Matthew Garrett | mjg59@srcf.ucam.org