From: Tony Lindgren <tony@atomide.com>
To: Thara Gopinath <thara@ti.com>
Cc: linux-omap@vger.kernel.org, khilman@deeprootsystems.com, sawant@ti.com
Subject: Re: [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS
Date: Tue, 1 Jun 2010 12:37:48 +0300 [thread overview]
Message-ID: <20100601093748.GI841@atomide.com> (raw)
In-Reply-To: <1275143831-7629-1-git-send-email-thara@ti.com>
* Thara Gopinath <thara@ti.com> [100529 17:31]:
> This patch series converts the OMAP Dual Mode Timer into a
> platform driver. This involves using of hwmod structures and
> omap_device layer for OMAP2/3/4 dmtimers and generic
> linux platform device layer for OMAP1.
>
> As a result of this patch series the dmtimer platform driver
> resides in arch/arm/plat-omap directory and arch specific
> implementations and device registerations reside in
> arch/arm/mach-omap1 and arch/arm/mach-omap2 for OMAP1
> and OMAP2 PLUS respectively.
>
> This patch series has been compile tested for OMAP1 using
> omap_1610_h2_defconfig, compile tested for OMAP2 using
> omap3_defconfig and boot and sanity tested for OMAP3/OMAP4
> again using omap3_defconfig. Boot testing has been done
> on OMAP3430 SDP and OMAP4430 SDP boards. All testing has
> been done on origin/origin/pm-wip/hwmods-omap4 branch off
> Kevin Hilman's tree as these patches have dependencies on
> runtime pm API's and OMAP4 autogenerated hwmod data base.
>
> It would be great if somebody could test these patches on OMAP1
> and OMAP2 platforms.
Looks good, but the problem I see with this series is that
it's not an incremental set of patches where each patch can
be verified to compile and work for all the omaps.
Please restructure your series so each patch keeps working
and we end up with the actual timer code under plat-omap
you should be able to add all the hwmod and platform data,
then add a patch that changes the timer code to use the
platform data as the last patch.
Regards,
Tony
prev parent reply other threads:[~2010-06-01 9:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 14:37 [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS Thara Gopinath
2010-05-29 14:37 ` [PATCH 1/9] OMAP: Convert dual mode timer into a platform driver Thara Gopinath
2010-05-29 14:37 ` [PATCH 2/9] OMAP1: Dual mode timer device registration Thara Gopinath
2010-05-29 14:37 ` [PATCH 3/9] OMAP2/3/4 : " Thara Gopinath
2010-05-29 14:37 ` [PATCH 4/9] OMAP2: Support for early " Thara Gopinath
2010-05-29 14:37 ` [PATCH 5/9] OMAP2/3/4: Adding device names to dmtimer fclk nodes Thara Gopinath
2010-05-29 14:37 ` [PATCH 6/9] OMAP3: Add hwmod data for OMAP3 dual mode timers Thara Gopinath
2010-05-29 14:37 ` [PATCH 7/9] OMAP2: Add hwmod data for OMAP2420 " Thara Gopinath
2010-05-29 14:37 ` [PATCH 8/9] OMAP2: Add hwmod data for OMAP2430 " Thara Gopinath
2010-05-29 14:37 ` [PATCH 9/9] OMAP4: Changing dmtimer1 fclk name Thara Gopinath
2010-06-03 23:19 ` [PATCH 4/9] OMAP2: Support for early device registration Kevin Hilman
2010-05-30 23:02 ` [PATCH 3/9] OMAP2/3/4 : Dual mode timer " Benoit Cousson
2010-06-01 9:20 ` Tony Lindgren
2010-06-03 9:30 ` Gopinath, Thara
2010-06-03 23:18 ` Kevin Hilman
2010-06-03 23:24 ` Kevin Hilman
2010-06-03 19:47 ` [PATCH 1/9] OMAP: Convert dual mode timer into a platform driver Kevin Hilman
2010-05-30 22:11 ` [PATCH 0/9] OMAP: DMTIMER: Convert platform driver so as to make use of hwmod + omap device framework for OMAP2 PLUS Benoit Cousson
2010-06-03 22:20 ` Kevin Hilman
2010-06-03 22:29 ` Benoit
2010-06-03 23:46 ` Kevin Hilman
2010-06-01 9:37 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601093748.GI841@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=sawant@ti.com \
--cc=thara@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).