From: Andrew Morton <akpm@linux-foundation.org>
To: Hemanth V <hemanthv@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
Daniel Mack <daniel@caiaq.de>, Jonathan Cameron <jic23@cam.ac.uk>,
Wolfram Sang <w.sang@pengutronix.de>
Subject: Re: [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver
Date: Tue, 1 Jun 2010 13:12:44 -0700 [thread overview]
Message-ID: <20100601131244.7164b43c.akpm@linux-foundation.org> (raw)
In-Reply-To: <39216.10.24.255.17.1274699065.squirrel@dbdmail.itg.ti.com>
I re-added your reviewers to the cc...
On Mon, 24 May 2010 16:34:25 +0530 (IST)
"Hemanth V" <hemanthv@ti.com> wrote:
> This patch adds support for ROHM BH1780GLI Ambient light sensor.
>
> BH1780 supports I2C interface. Driver supports read/update of power state and
> read of lux value (through SYSFS). Writing value 3 to power_state enables the
> sensor and current lux value could be read.
There are at least two other ambient light sensor drivers:
drivers/misc/isl29003.c and drivers/misc/tsl2550.c.
Is there any standardisation of the ABIs whcih these drivers offer? If
so, does this new driver comply with that?
It would be most useful if the changelog were to fully describe the
proposed kernel<->userspace interface. That's the most important part
of the driver, because it's the only part we can never change.
There is a desultory effort to maintain sysfs API descriptions under
Documentation/ABI/. I'd have thought that it would be appropriate to
document this driver's ABI in there.
next prev parent reply other threads:[~2010-06-01 20:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 11:04 [PATCH V2] misc : ROHM BH1780GLI Ambient light sensor Driver Hemanth V
2010-06-01 20:12 ` Andrew Morton [this message]
2010-06-01 20:27 ` Daniel Mack
2010-06-01 20:38 ` Andrew Morton
2010-06-01 20:45 ` Jonathan Cameron
2010-06-01 20:39 ` Jonathan Cameron
2010-06-01 20:54 ` Andrew Morton
2010-06-01 21:39 ` Jonathan Cameron
2010-06-02 8:59 ` Hemanth V
2010-06-02 13:05 ` Alan Cox
[not found] <39216.10.24.255.17.1274699066.squirrel@dbdmail.itg.ti.com>
2010-05-26 8:30 ` Hemanth V
2010-05-26 9:39 ` Jonathan Cameron
2010-05-26 11:12 ` Hemanth V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601131244.7164b43c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daniel@caiaq.de \
--cc=hemanthv@ti.com \
--cc=jic23@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).