From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: "ext Arce, Abraham" <x0066660@ti.com>,
Tony Lindgren <tony@atomide.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration
Date: Tue, 1 Jun 2010 13:13:14 -0700 [thread overview]
Message-ID: <20100601201314.GA17468@core.coreip.homeip.net> (raw)
In-Reply-To: <20100601185358.GE23818@nokia.com>
On Tue, Jun 01, 2010 at 09:53:58PM +0300, Felipe Balbi wrote:
> On Tue, Jun 01, 2010 at 05:14:09PM +0200, ext Arce, Abraham wrote:
> >I am using #ifdef CONFIG_ARCH_OMAP4 for this portion of code, what
> >you are suggesting is to check at runtime?
>
> you need to add both checks. If you build omap3-only or omap2-only
> you don't want that code to be compiled, but if you build
> omap1-2-3-4 kernel, you want it to work correctly on all cases.
>
It sould be nice if cpu_is_xxx were stubbed out for "wrong" arches
withing the same group (like omap, etc) so we could reduce the #ifdef
clutter.
--
Dmitry
next prev parent reply other threads:[~2010-06-01 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 21:44 [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration Arce, Abraham
2010-06-01 4:47 ` Felipe Balbi
2010-06-01 4:49 ` Felipe Balbi
2010-06-01 17:48 ` Kevin Hilman
2010-06-01 9:43 ` Tony Lindgren
2010-06-01 15:14 ` Arce, Abraham
2010-06-01 18:53 ` Felipe Balbi
2010-06-01 20:13 ` Dmitry Torokhov [this message]
2010-06-11 7:31 ` Tony Lindgren
2010-06-02 8:28 ` Thomas Petazzoni
2010-06-02 12:45 ` Arce, Abraham
2010-06-02 13:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601201314.GA17468@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).