linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [MMC] omap: Remove BUG_ON for disabled interrupts
@ 2010-05-30  2:27 Cory Maccarrone
  2010-05-31 13:37 ` Tony Lindgren
  2010-06-02 21:05 ` Andrew Morton
  0 siblings, 2 replies; 6+ messages in thread
From: Cory Maccarrone @ 2010-05-30  2:27 UTC (permalink / raw)
  To: linux-mmc, linux-omap; +Cc: akpm, Cory Maccarrone

This change removes a BUG_ON for when interrupts are disabled
during an MMC request.  During boot, interrupts can be disabled
when a request is made, causing this bug to be triggered.  In reality,
there's no reason this should halt the kernel, as the driver has proved
reliable in spite of disabled interrupts, and additionally, there's
nothing in this code that would require interrupts to be enabled.

Signed-off-by: Cory Maccarrone <darkstar6262@gmail.com>
---
 drivers/mmc/host/omap.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c
index 2b28168..d98ddcf 100644
--- a/drivers/mmc/host/omap.c
+++ b/drivers/mmc/host/omap.c
@@ -1157,7 +1157,6 @@ static void mmc_omap_start_request(struct mmc_omap_host *host,
 	mmc_omap_start_command(host, req->cmd);
 	if (host->dma_in_use)
 		omap_start_dma(host->dma_ch);
-	BUG_ON(irqs_disabled());
 }
 
 static void mmc_omap_request(struct mmc_host *mmc, struct mmc_request *req)
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-06-03  0:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-30  2:27 [PATCH] [MMC] omap: Remove BUG_ON for disabled interrupts Cory Maccarrone
2010-05-31 13:37 ` Tony Lindgren
2010-06-02 21:05 ` Andrew Morton
2010-06-02 22:26   ` Cory Maccarrone
2010-06-02 23:30     ` Andrew Morton
2010-06-03  0:05       ` Cory Maccarrone

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).