From: "Luke-Jr" <luke@dashjr.org>
To: tomi.valkeinen@nokia.com, slapin@ossfans.org
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org
Subject: OMAP video compile error; regression from 2.6.33-rc4 onward (including current master)
Date: Sun, 6 Jun 2010 16:52:25 -0500 [thread overview]
Message-ID: <201006061652.39248.luke@dashjr.org> (raw)
This doesn't even build, so I don't know how it was tested... Reverting the
offending commit (simple, but does require conflict resolution) at least lets
it compile, but I haven't tested whether it alone is enough to work in
practise yet... hoping Tomi might provide a real fix. Maybe even in time for
2.6.35 final? :)
https://bugzilla.kernel.org/show_bug.cgi?id=16144
CC drivers/video/omap/rfbi.o
drivers/video/omap/rfbi.c: In function 'rfbi_get_clocks':
drivers/video/omap/rfbi.c:86: error: 'dispc' undeclared (first use in this
function)
drivers/video/omap/rfbi.c:86: error: (Each undeclared identifier is reported
only once
drivers/video/omap/rfbi.c:86: error: for each function it appears in.)
make[1]: *** [drivers/video/omap/rfbi.o] Error 1
make: *** [drivers/video/omap/rfbi.o] Error 2
The 'dispc' referred to herein is and has always been defined in
drivers/video/omap/dispc.c as an anonymous struct.
Broken in...
commit f778a12dd33200513596a0d4d3ba4d5f09e79c09
Author: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Date: Wed Dec 16 13:18:07 2009 +0200
OMAP: OMAPFB: fix clk_get for RFBI
omapfb platform device was still used to get clocks inside rfbi.c
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Tested-by: Sergey Lapin <slapin@ossfans.org>
next reply other threads:[~2010-06-06 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 21:52 Luke-Jr [this message]
2010-06-07 7:39 ` OMAP video compile error; regression from 2.6.33-rc4 onward (including current master) Tomi Valkeinen
2010-06-07 7:47 ` Tomi Valkeinen
2010-06-07 16:17 ` Luke-Jr
2010-06-08 8:36 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006061652.39248.luke@dashjr.org \
--to=luke@dashjr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=slapin@ossfans.org \
--cc=tomi.valkeinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox