From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH V3 2/2]OMAP: Disable internal I2C pull-ups in OMAP3630 Date: Thu, 10 Jun 2010 08:56:43 +0300 Message-ID: <20100610055643.GL32208@atomide.com> References: <1267211687-23551-1-git-send-email-m-sonasath@ti.com> <20100608100437.GP15515@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:61503 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469Ab0FJF4n (ORCPT ); Thu, 10 Jun 2010 01:56:43 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Leon Woestenberg Cc: "Sonasath, Moiz" , "linux-omap@vger.kernel.org" , "Pais, Allen" , "Pandita, Vikram" * Leon Woestenberg [100609 22:20]: > Hello Tony, > > On Tue, Jun 8, 2010 at 12:04 PM, Tony Lindgren wrote: > > Because of this, 3630 boards should have the mux register pull-ups disabled, > > and only use the dedicated I2C pull-ups. In theory external pull-ups should > > not be needed. The value configured for the dedicated I2C pull-ups depends > > on the connected I2C device, and the number of devices. > > > If the internal pull-ups are disabled, why are external pull-ups not needed? There are two omap internal pull-ups available: The iopad mux pull-ups and the I2C specific pull-ups. Only the I2C specific ones should be used. Regards, Tony