[PATCH] omap_hsmmc: Remove unused state variable

[PATCH] omap_hsmmc: Remove unused state variable

[Sergio Aguirre]

This fixes the following warning:

drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state'

Introduced by commit ID:

  commit 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e
  Author: Matt Fleming <matt@console-pimps.org>
  Date:   Wed May 26 14:42:08 2010 -0700

      mmc: remove the "state" argument to mmc_suspend_host()

The unique usage of this var was removed there, and missed
removing the respective declaration aswell.

Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
---
 drivers/mmc/host/omap_hsmmc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index b032828..d50e917 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev)
 	int ret = 0;
 	struct platform_device *pdev = to_platform_device(dev);
 	struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
-	pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
 
 	if (host && host->suspended)
 		return 0;
-- 
1.6.3.3

Re: [PATCH] omap_hsmmc: Remove unused state variable

[Matt Fleming]

On Tue,  8 Jun 2010 15:41:40 -0500, Sergio Aguirre <saaguirre@ti.com> wrote:
> This fixes the following warning:
> 
> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
> drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state'
> 
> Introduced by commit ID:
> 
>   commit 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e
>   Author: Matt Fleming <matt@console-pimps.org>
>   Date:   Wed May 26 14:42:08 2010 -0700
> 
>       mmc: remove the "state" argument to mmc_suspend_host()
> 
> The unique usage of this var was removed there, and missed
> removing the respective declaration aswell.
> 
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> ---
>  drivers/mmc/host/omap_hsmmc.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index b032828..d50e917 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev)
>  	int ret = 0;
>  	struct platform_device *pdev = to_platform_device(dev);
>  	struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
> -	pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
>  
>  	if (host && host->suspended)
>  		return 0;
> -- 
> 1.6.3.3
> 

Oops. Thanks for catching that.

Acked-by: Matt Fleming <matt@console-pimps.org>

Re: [PATCH] omap_hsmmc: Remove unused state variable

[Tony Lindgren]

* Sergio Aguirre <saaguirre@ti.com> [100608 23:35]:
> This fixes the following warning:
> 
> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
> drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state'
> 
> Introduced by commit ID:
> 
>   commit 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e
>   Author: Matt Fleming <matt@console-pimps.org>
>   Date:   Wed May 26 14:42:08 2010 -0700
> 
>       mmc: remove the "state" argument to mmc_suspend_host()
> 
> The unique usage of this var was removed there, and missed
> removing the respective declaration aswell.

This should be sent to linux-mmc list.

Tony

 
> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> ---
>  drivers/mmc/host/omap_hsmmc.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index b032828..d50e917 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev)
>  	int ret = 0;
>  	struct platform_device *pdev = to_platform_device(dev);
>  	struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
> -	pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
>  
>  	if (host && host->suspended)
>  		return 0;
> -- 
> 1.6.3.3
> 

RE: [PATCH] omap_hsmmc: Remove unused state variable

[Aguirre, Sergio]

> -----Original Message-----
> From: Tony Lindgren [mailto:tony@atomide.com]
> Sent: Thursday, June 10, 2010 1:49 AM
> To: Aguirre, Sergio
> Cc: linux-omap@vger.kernel.org; Matt Fleming
> Subject: Re: [PATCH] omap_hsmmc: Remove unused state variable
> 
> * Sergio Aguirre <saaguirre@ti.com> [100608 23:35]:
> > This fixes the following warning:
> >
> > drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_suspend':
> > drivers/mmc/host/omap_hsmmc.c:2275: warning: unused variable 'state'
> >
> > Introduced by commit ID:
> >
> >   commit 1a13f8fa76c880be41d6b1e6a2b44404bcbfdf9e
> >   Author: Matt Fleming <matt@console-pimps.org>
> >   Date:   Wed May 26 14:42:08 2010 -0700
> >
> >       mmc: remove the "state" argument to mmc_suspend_host()
> >
> > The unique usage of this var was removed there, and missed
> > removing the respective declaration aswell.
> 
> This should be sent to linux-mmc list.

Ok, No problem. I will do that now.

Thanks and Regards,
Sergio

> 
> Tony
> 
> 
> > Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
> > ---
> >  drivers/mmc/host/omap_hsmmc.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mmc/host/omap_hsmmc.c
> b/drivers/mmc/host/omap_hsmmc.c
> > index b032828..d50e917 100644
> > --- a/drivers/mmc/host/omap_hsmmc.c
> > +++ b/drivers/mmc/host/omap_hsmmc.c
> > @@ -2272,7 +2272,6 @@ static int omap_hsmmc_suspend(struct device *dev)
> >  	int ret = 0;
> >  	struct platform_device *pdev = to_platform_device(dev);
> >  	struct omap_hsmmc_host *host = platform_get_drvdata(pdev);
> > -	pm_message_t state = PMSG_SUSPEND; /* unused by MMC core */
> >
> >  	if (host && host->suspended)
> >  		return 0;
> > --
> > 1.6.3.3
> >