From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
Nishanth Menon <nm@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks
Date: Wed, 16 Jun 2010 19:09:26 +0300 [thread overview]
Message-ID: <20100616160926.GE12255@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1006160322060.17630@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [100616 12:16]:
> On Mon, 31 May 2010, Tony Lindgren wrote:
>
> > * Paul Walmsley <paul@pwsan.com> [100520 02:05]:
> > > Hi,
> > >
> > > On Wed, 19 May 2010, Santosh Shilimkar wrote:
> > >
> > > > This patch uses "ENABLE_ON_INIT" flag on the emif clock nodes
> > > > to avoid the emif clk getting cut as part of reset un-used clock
> > > > routine which prevents boot.
> > > >
> > > > Since omap4 "omap2_clk_init()" calls "clk_enable_init_clocks()"
> > > > which increases the usecount on all ENABLE_ON_INIT clocks, it
> > > > prevents "omap2_clk_disable_unused()" from disabling the clock.
> > > >
> > > > The real fix is to have driver for EMIF and do clock get/enable
> > > > as part of it. The EMIF driver is planned to be done HWMOD way
> > > > so till that available to keep omap3_defconfig booting on OMAP4430,
> > > > this patch is necessary.
> > > > (Will updated the auto-gen script for 44xx accordingly)
> > > >
> > > > The fix was suggested by Paul Walmsley
> > > >
> > > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > > > Cc: Paul Walmsley <paul@pwsan.com>
> > >
> > > Thanks, I've added Nishanth's Tested-by: and fixed the patch changelog;
> > > the following patch is now queued for 2.6.35-rc, unless there are any
> > > further comments.
> >
> > FYI, I'll also added this into omap-testing branch while we're waiting
> > for your clock fixes branch to be available.
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
> Feel free to send this one upstream separately if you like, until the
> clock -rc series is ready.
OK, thanks, will add into omap-fixes-for-linus.
Regards,
Tony
prev parent reply other threads:[~2010-06-16 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 16:38 [PATCH v2] omap4: Fix multi-omap boot with reset un-used clocks Santosh Shilimkar
2010-05-19 20:01 ` Nishanth Menon
2010-05-20 1:00 ` Tony Lindgren
2010-05-20 1:03 ` Nishanth Menon
2010-05-20 1:06 ` Tony Lindgren
2010-05-20 1:09 ` Nishanth Menon
2010-05-20 1:24 ` Tony Lindgren
2010-05-20 1:49 ` Nishanth Menon
2010-05-20 4:57 ` Shilimkar, Santosh
2010-05-20 10:30 ` Arce, Abraham
2010-05-20 10:28 ` Shilimkar, Santosh
2010-05-19 23:10 ` Paul Walmsley
2010-05-20 4:58 ` Shilimkar, Santosh
2010-05-31 12:48 ` Tony Lindgren
2010-06-16 9:22 ` Paul Walmsley
2010-06-16 16:09 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100616160926.GE12255@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).