Re: [PATCH 4/8] USB: musb: suppress warning about unused flags

[Felipe Balbi <felipe.balbi@nokia.com>]

On Thu, Jun 17, 2010 at 12:40:37PM +0200, ext Ajay Kumar Gupta wrote:
>From: Jon Povey <jon.povey@racelogic.co.uk>
>
>Wrap flags with uninitialized_var() to suppress this:
>
>drivers/usb/musb/cppi_dma.c:1158: warning: 'flags' may be used uninitialized
>in this function
>
>Signed-off-by: Jon Povey <jon.povey@racelogic.co.uk>
>Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>---
> drivers/usb/musb/cppi_dma.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/usb/musb/cppi_dma.c b/drivers/usb/musb/cppi_dma.c
>index 59dc3d3..e3753ba 100644
>--- a/drivers/usb/musb/cppi_dma.c
>+++ b/drivers/usb/musb/cppi_dma.c
>@@ -1155,7 +1155,7 @@ irqreturn_t cppi_interrupt(int irq, void *dev_id)
> 	struct musb_hw_ep	*hw_ep = NULL;
> 	u32			rx, tx;
> 	int			i, index;
>-	unsigned long		flags;
>+	unsigned long		uninitialized_var(flags);

I think the problem here is different. First of all, an IRQ of number 0 
is valid and your locking would be broken in that case. Is there really 
any board that doesn't have the irq line routed ? To me it just looks 
that branching if (irq) is completely bogus.

-- 
balbi

DefectiveByDesign.org