OMAP3 display patches

OMAP3 display patches

[Nagarajan, Rajkumar]

Tomi,

Would you please check if there are no further comments and can you please pull the following patches in?

https://patchwork.kernel.org/patch/106498/
https://patchwork.kernel.org/patch/106670/
https://patchwork.kernel.org/patch/107547/

Regards,
Rajkumar N.

Re: OMAP3 display patches

[Ville Syrjälä]

On Tue, Jun 29, 2010 at 02:20:36PM +0200, ext Nagarajan, Rajkumar wrote:
> 
> Tomi,
> 
> Would you please check if there are no further comments and can you please pull the following patches in?
>
> https://patchwork.kernel.org/patch/106498/

This one seems to have two separate changes in the same patch. Needs
splitting.

> https://patchwork.kernel.org/patch/106670/

I think this one needs a (cpu_is_omap3630() && id == OMAP_DSS_VIDEO2)
check in store() so that the user gets a proper error if he tries to
write an unsupported value.

> https://patchwork.kernel.org/patch/107547/

You never addressed any of my comments so asking Tomi to pull this
seems rather premature.

-- 
Ville Syrjälä
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: OMAP3 display patches

[Tomi Valkeinen]

On Tue, 2010-06-29 at 14:20 +0200, ext Nagarajan, Rajkumar wrote:
> Tomi,
> 
> Would you please check if there are no further comments and can you please pull the following patches in?
> 
> https://patchwork.kernel.org/patch/106498/

What exactly is the purpose of this patch? The patch description doesn't
really tell me anything. The input size is supposed to come from omapfb
(or V4L2).

It also seems to add a module parameter, without even mentioning it in
the description.

There's also a typo in the description (sysfx).

> https://patchwork.kernel.org/patch/106670/

See Ville's comment about this.

I'd also like to have the sysfs files to be created only when they are
actually applicable, ie. pre_multiplication_alpha would be created only
for 3630, and for overlays that support it.

However, no other DSS sysfs file support this currently, and I'm not
sure what it would mean to support this.

> https://patchwork.kernel.org/patch/107547/

See Ville's and Koen's comments about this.

 Tomi