From: Tony Lindgren <tony@atomide.com>
To: kishore kadiyala <kishorek.kadiyala@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kishore kadiyala <kishore.kadiyala@ti.com>,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
madhu.cr@ti.com
Subject: Re: [PATCH v5 1/2] OMAP HSMMC: Adding a Flag to determine the type of Card detect
Date: Thu, 1 Jul 2010 15:32:16 +0300 [thread overview]
Message-ID: <20100701123216.GP2822@atomide.com> (raw)
In-Reply-To: <AANLkTikInbivUfkulAf7RZyaIjRo9GuxvQjRHHE1duCY@mail.gmail.com>
* kishore kadiyala <kishorek.kadiyala@gmail.com> [100621 09:49]:
> On Fri, Jun 18, 2010 at 1:49 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 17 Jun 2010 20:56:58 +0530 (IST)
> > "kishore kadiyala" <kishore.kadiyala@ti.com> wrote:
> >
> >> --- a/arch/arm/plat-omap/include/plat/mmc.h
> >> +++ b/arch/arm/plat-omap/include/plat/mmc.h
> >> @@ -43,6 +43,9 @@
> >>
> >> #define OMAP_MMC_MAX_SLOTS 2
> >>
> >> +#define NON_GPIO 0
> >> +#define GPIO 1
> >
> > I'm counting about seven different definitions of "GPIO" in the kernel
> > already.
> >
> > drivers/hwmon/it87.c:
> > #define GPIO 0x07
> >
> > drivers/media/dvb/dvb-usb/ec168.h:
> > GPIO = 0x04,
> >
> > drivers/net/hamachi.c:
> > GPIO=0x6E
> >
> > drivers/staging/rtl8187se/r8180_hw.h:
> > #define GPIO 0x91
> >
> > etcetera. It's a crazy identifier to use in a header file, and
> > the chances of a miscompile-causing collision are increasing.
> >
> >
> > enum cd_type {
> > CD_TYPE_NON_GPIO = 0,
> > CD_TYPE_GPIO = 1,
> > };
>
> OK , Will repost with above changes
Please also do it the other way around where you pass CD_TYPE_NON_GPIO
in the flags in the platform data. Then there's no need to patch
all the existing boards.
Tony
prev parent reply other threads:[~2010-07-01 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-17 15:26 [PATCH v5 1/2] OMAP HSMMC: Adding a Flag to determine the type of Card detect kishore kadiyala
2010-06-17 20:19 ` Andrew Morton
2010-06-21 6:55 ` kishore kadiyala
2010-07-01 12:32 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701123216.GP2822@atomide.com \
--to=tony@atomide.com \
--cc=akpm@linux-foundation.org \
--cc=kishore.kadiyala@ti.com \
--cc=kishorek.kadiyala@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=madhu.cr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).