From: Tony Lindgren <tony@atomide.com>
To: Christoph Egger <siccegge@cs.fau.de>
Cc: Russell King <linux@arm.linux.org.uk>,
Ladislav Michl <ladis@linux-mips.org>,
Kalle Valo <kalle.valo@iki.fi>,
Kevin Hilman <khilman@deeprootsystems.com>,
Paul Walmsley <paul@pwsan.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
vamos@i4.informatik.uni-erlangen.de
Subject: Re: [PATCH 05/33] Removing dead OMAP_IR
Date: Mon, 5 Jul 2010 11:14:55 +0300 [thread overview]
Message-ID: <20100705081453.GD15951@atomide.com> (raw)
In-Reply-To: <b7209c2cb666c73a3affbb44c2637a4f2086af08.1277911346.git.siccegge@cs.fau.de>
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
* Christoph Egger <siccegge@cs.fau.de> [100630 18:49]:
> OMAP_IR doesn't exist in Kconfig, therefore removing all references
> for it from the source code.
Thanks I've updated this for the new mux code for board-h4.c and applied it.
Updated patch below.
Regards,
Tony
[-- Attachment #2: irda.patch --]
[-- Type: text/x-diff, Size: 2370 bytes --]
>From e2bed14099b0d15514d3e542742fa9310d9bf52c Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@cs.fau.de>
Date: Wed, 30 Jun 2010 15:55:22 +0000
Subject: [PATCH] Removing dead OMAP_IR
OMAP_IR doesn't exist in Kconfig, therefore removing all references
for it from the source code.
Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
[tony@atomide.com: updated for new mux code]
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
index ee46974..2efa427 100644
--- a/arch/arm/mach-omap1/board-h2.c
+++ b/arch/arm/mach-omap1/board-h2.c
@@ -292,15 +292,6 @@ static struct platform_device h2_kp_device = {
#define H2_IRDA_FIRSEL_GPIO_PIN 17
-#if defined(CONFIG_OMAP_IR) || defined(CONFIG_OMAP_IR_MODULE)
-static int h2_transceiver_mode(struct device *dev, int state)
-{
- /* SIR when low, else MIR/FIR when HIGH */
- gpio_set_value(H2_IRDA_FIRSEL_GPIO_PIN, !(state & IR_SIRMODE));
- return 0;
-}
-#endif
-
static struct omap_irda_config h2_irda_data = {
.transceiver_cap = IR_SIRMODE | IR_MIRMODE | IR_FIRMODE,
.rx_channel = OMAP_DMA_UART3_RX,
@@ -450,15 +441,6 @@ static void __init h2_init(void)
omap_cfg_reg(E19_1610_KBR4);
omap_cfg_reg(N19_1610_KBR5);
- /* Irda */
-#if defined(CONFIG_OMAP_IR) || defined(CONFIG_OMAP_IR_MODULE)
- omap_writel(omap_readl(FUNC_MUX_CTRL_A) | 7, FUNC_MUX_CTRL_A);
- if (gpio_request(H2_IRDA_FIRSEL_GPIO_PIN, "IRDA mode") < 0)
- BUG();
- gpio_direction_output(H2_IRDA_FIRSEL_GPIO_PIN, 0);
- h2_irda_data.transceiver_mode = h2_transceiver_mode;
-#endif
-
platform_add_devices(h2_devices, ARRAY_SIZE(h2_devices));
omap_board_config = h2_config;
omap_board_config_size = ARRAY_SIZE(h2_config);
diff --git a/arch/arm/mach-omap2/board-h4.c b/arch/arm/mach-omap2/board-h4.c
index 2d9ff0f..9044dcf 100644
--- a/arch/arm/mach-omap2/board-h4.c
+++ b/arch/arm/mach-omap2/board-h4.c
@@ -356,10 +356,6 @@ static void __init omap_h4_init(void)
* You have to mux them off in device drivers later on
* if not needed.
*/
-#if defined(CONFIG_OMAP_IR) || defined(CONFIG_OMAP_IR_MODULE)
- omap_mux_init_signal("uart3_tx_irtx.uart3_tx_irtx", 0);
- omap_mux_init_signal("uart3_rx_irrx.uart3_rx_irrx", 0);
-#endif
#if defined(CONFIG_KEYBOARD_OMAP) || defined(CONFIG_KEYBOARD_OMAP_MODULE)
omap_mux_init_gpio(88, OMAP_PULL_ENA | OMAP_PULL_UP);
next prev parent reply other threads:[~2010-07-05 8:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1277911345.git.siccegge@cs.fau.de>
2010-06-30 15:54 ` [PATCH 03/33] Removing dead OMAP_MUX_ERRORS Christoph Egger
2010-06-30 15:55 ` [PATCH 05/33] Removing dead OMAP_IR Christoph Egger
2010-06-30 15:57 ` [PATCH 11/33] Removing dead OMAP_DSP Christoph Egger
2010-06-30 15:57 ` [PATCH 12/33] Removing dead OMAP_STI Christoph Egger
2010-06-30 15:58 ` [PATCH 13/33] Replacing LEDS_OMAP_DEBUG with OMAP_DEBUG_LEDS Christoph Egger
2010-07-05 8:28 ` Tony Lindgren
2010-06-30 15:59 ` [PATCH 16/33] Removing dead APM Christoph Egger
2010-06-30 15:59 ` [PATCH 17/33] Removing dead SX1_OLD_FLASH Christoph Egger
2010-06-30 18:24 ` Marek Vasut
2010-07-05 8:33 ` Tony Lindgren
2010-07-05 10:31 ` Marek Vasut
2010-06-30 15:59 ` [PATCH 18/33] Removing dead OMAP_ARM_96MHZ Christoph Egger
2010-06-30 18:25 ` Marek Vasut
2010-07-05 8:44 ` Tony Lindgren
2010-06-30 16:00 ` [PATCH 21/33] Removing dead OMAP2_VENC_OUT_TYPE_SVIDEO, OMAP2_VENC_OUT_TYPE_COMPOSITE Christoph Egger
2010-07-05 8:56 ` Tony Lindgren
2010-08-03 12:12 ` Tomi Valkeinen
2010-07-06 5:56 ` Hiremath, Vaibhav
2010-06-30 16:01 ` [PATCH 22/33] Removing dead MPU_{BRIDGE,TESLA}_IOMMU Christoph Egger
2010-06-30 18:23 ` Hiroshi DOYU
2010-06-30 18:44 ` Kanigeri, Hari
[not found] ` <51c095a4c49baacbfdd6ed332d1375ab64209753.1277911346.git.siccegge@cs.fau.de>
2010-06-30 18:23 ` [PATCH 16/33] Removing dead APM Marek Vasut
2010-07-05 8:31 ` Tony Lindgren
[not found] ` <b6ca168f9459162f2c96aa8ef999047a3c4f6f9c.1277911346.git.siccegge@cs.fau.de>
2010-06-30 19:54 ` [PATCH 03/33] Removing dead OMAP_MUX_ERRORS Kirill A. Shutemov
2010-07-01 13:22 ` Christoph Egger
2010-07-01 15:27 ` Kirill A. Shutemov
2010-07-05 8:07 ` Tony Lindgren
[not found] ` <24b01f2edebd09e37306c35f14401819d8219549.1277911346.git.siccegge@cs.fau.de>
2010-07-01 7:35 ` [PATCH 20/33] Removing dead MACH_OMAP2_H4_USB1 Felipe Balbi
2010-07-05 8:55 ` Tony Lindgren
[not found] ` <b7209c2cb666c73a3affbb44c2637a4f2086af08.1277911346.git.siccegge@cs.fau.de>
2010-07-05 8:14 ` Tony Lindgren [this message]
[not found] ` <fc9feac62dc4eb90e8c3b7039729fa102ad0ac98.1277911346.git.siccegge@cs.fau.de>
2010-07-05 8:20 ` [PATCH 11/33] Removing dead OMAP_DSP Tony Lindgren
[not found] ` <35d3c6a25b5cc05a5eee3037075ccede85b1917f.1277911346.git.siccegge@cs.fau.de>
2010-07-05 8:24 ` [PATCH 12/33] Removing dead OMAP_STI Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100705081453.GD15951@atomide.com \
--to=tony@atomide.com \
--cc=kalle.valo@iki.fi \
--cc=khilman@deeprootsystems.com \
--cc=ladis@linux-mips.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=santosh.shilimkar@ti.com \
--cc=siccegge@cs.fau.de \
--cc=vamos@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).