linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Ajay Kumar Gupta <ajay.gupta@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	felipe.balbi@nokia.com
Subject: Re: [PATCH resend 1/3] AM35x: Add musb support
Date: Mon, 5 Jul 2010 12:50:19 +0300	[thread overview]
Message-ID: <20100705095015.GP15951@atomide.com> (raw)
In-Reply-To: <1278053879-6850-1-git-send-email-ajay.gupta@ti.com>

* Ajay Kumar Gupta <ajay.gupta@ti.com> [100702 09:52]:
> AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine.
> It has USB phy built inside the IP itself.
> 
> Also added ARCH_AM35x which is required to differentiate musb ips
> between OMAP3x and AM35x. This config would be used for below purposes,
>         - Select am35x.c instead of omap2430.c for compilation
>           at drivers/usb/musb directory. Please note there are
>           significant differneces in these two files as musb ip
>           in quite different on AM35x.
>         - Select workaround codes applicable for AM35x musb issues.
>           one such workaround is for bytewise read issue on AM35x.
> 

<snip>

> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index b31b6f1..52a6752 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -84,6 +84,7 @@ config MACH_OMAP3517EVM
>  	bool "OMAP3517/ AM3517 EVM board"
>  	depends on ARCH_OMAP3
>  	select OMAP_PACKAGE_CBB
> +	select ARCH_AM35x
>  
>  config MACH_OMAP3_PANDORA
>  	bool "OMAP3 Pandora"

No thanks..

> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -5,6 +5,14 @@ menu "TI OMAP Implementations"
>  config ARCH_OMAP_OTG
>  	bool
>  
> +config ARCH_AM35x
> +	bool
> +	help
> +	  Select this option if your platform is based on AM35x. As
> +	  AM35x has an updated MUSB with CPPI4.1 DMA so this config
> +	  is introduced to differentiate musb ip between OMAP3x and
> +	  AM35x platforms.
> +
>  choice
>  	prompt "OMAP System Type"
>  	default ARCH_OMAP2PLUS

..this should not be needed.

Regards,

Tony

  parent reply	other threads:[~2010-07-05  9:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02  6:57 [PATCH resend 1/3] AM35x: Add musb support Ajay Kumar Gupta
2010-07-02  6:57 ` [PATCH resend 2/3] musb: add musb support for AM35x Ajay Kumar Gupta
2010-07-02  6:57   ` [PATCH resend 3/3] musb: AM35x: Workaround for fifo read issue Ajay Kumar Gupta
2010-07-02 12:21   ` [PATCH resend 2/3] musb: add musb support for AM35x Sergei Shtylyov
2010-07-03  3:24     ` Gupta, Ajay Kumar
     [not found]       ` <19F8576C6E063C45BE387C64729E7394044EAAD82A-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-07-03 13:04         ` Sergei Shtylyov
2010-07-05 11:46           ` Gupta, Ajay Kumar
2010-07-05  9:50 ` Tony Lindgren [this message]
2010-07-05 10:02   ` [PATCH resend 1/3] AM35x: Add musb support Sergei Shtylyov
     [not found]     ` <4C31ADCA.40607-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-07-05 10:23       ` Tony Lindgren
     [not found]         ` <20100705102322.GR15951-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-07-05 10:34           ` Sergei Shtylyov
     [not found]             ` <4C31B54F.6040109-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-07-05 10:48               ` Tony Lindgren
2010-07-05 11:54                 ` Gupta, Ajay Kumar
     [not found]                   ` <19F8576C6E063C45BE387C64729E7394044EAAD8F6-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-07-05 13:45                     ` Tony Lindgren
     [not found]                       ` <20100705134552.GD15951-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-07-05 14:50                         ` Sergei Shtylyov
2010-07-06  7:23                           ` Gupta, Ajay Kumar
2010-07-06  7:57                             ` Tony Lindgren
     [not found]                               ` <20100706075707.GC3192-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-07-06  8:46                                 ` Felipe Balbi
     [not found]                                   ` <20100706084603.GA3035-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-07-06  9:51                                     ` Tony Lindgren
2010-07-06 22:46                                   ` Gadiyar, Anand
2010-07-07  7:53                                     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100705095015.GP15951@atomide.com \
    --to=tony@atomide.com \
    --cc=ajay.gupta@ti.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).