linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Gupta, Ajay Kumar" <ajay.gupta@ti.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"felipe.balbi@nokia.com" <felipe.balbi@nokia.com>
Subject: Re: [PATCH resend 1/3] AM35x: Add musb support
Date: Tue, 6 Jul 2010 10:57:09 +0300	[thread overview]
Message-ID: <20100706075707.GC3192@atomide.com> (raw)
In-Reply-To: <19F8576C6E063C45BE387C64729E7394044EAADA64@dbde02.ent.ti.com>

* Gupta, Ajay Kumar <ajay.gupta@ti.com> [100706 10:17]:
>
> As musb controllers are quite different between OMAPs and AM35x so it
> would be difficult in terms of software maintenance with such approach.

Hmm, this is all pretty standard stuff..
 
> Some of the major changes in AM35x are,
> 	- Has builtin USB PHY

Register the PHY from platform data.

> 	- It doesn't use Mentor DMA but uses CPPI4.1 DMA

Register DMA functions from platform data.

> 	- Has set of wrapper register which are not present on OMAPs.

Yeah tusb6010 has the same problem, but that's already dealt with
I believe.

> 	- Doesn't have SYSCONFIG registers which are present on OMAPs.
> 	- Has bytewise read limitation which is not applicable to OMAPs.

Sounds like this has been mostly dealt with already with tusb6010.
 
> Musb on AM35x is actually quite similar to musb on DA8xx family of
> Devices.
> 
> I can update the patches to use USB_MUSB_AM35X config within 
> drivers/usb/musb/ but that would still not be able to compile in
> Both omapx and am35x stuff in single binary.

Sounds like we should first fix thing before adding new code
that will make fixing the basic issues harder.

Tony

  reply	other threads:[~2010-07-06  7:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02  6:57 [PATCH resend 1/3] AM35x: Add musb support Ajay Kumar Gupta
2010-07-02  6:57 ` [PATCH resend 2/3] musb: add musb support for AM35x Ajay Kumar Gupta
2010-07-02  6:57   ` [PATCH resend 3/3] musb: AM35x: Workaround for fifo read issue Ajay Kumar Gupta
2010-07-02 12:21   ` [PATCH resend 2/3] musb: add musb support for AM35x Sergei Shtylyov
2010-07-03  3:24     ` Gupta, Ajay Kumar
     [not found]       ` <19F8576C6E063C45BE387C64729E7394044EAAD82A-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-07-03 13:04         ` Sergei Shtylyov
2010-07-05 11:46           ` Gupta, Ajay Kumar
2010-07-05  9:50 ` [PATCH resend 1/3] AM35x: Add musb support Tony Lindgren
2010-07-05 10:02   ` Sergei Shtylyov
     [not found]     ` <4C31ADCA.40607-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-07-05 10:23       ` Tony Lindgren
     [not found]         ` <20100705102322.GR15951-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-07-05 10:34           ` Sergei Shtylyov
     [not found]             ` <4C31B54F.6040109-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>
2010-07-05 10:48               ` Tony Lindgren
2010-07-05 11:54                 ` Gupta, Ajay Kumar
     [not found]                   ` <19F8576C6E063C45BE387C64729E7394044EAAD8F6-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-07-05 13:45                     ` Tony Lindgren
     [not found]                       ` <20100705134552.GD15951-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-07-05 14:50                         ` Sergei Shtylyov
2010-07-06  7:23                           ` Gupta, Ajay Kumar
2010-07-06  7:57                             ` Tony Lindgren [this message]
     [not found]                               ` <20100706075707.GC3192-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2010-07-06  8:46                                 ` Felipe Balbi
     [not found]                                   ` <20100706084603.GA3035-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org>
2010-07-06  9:51                                     ` Tony Lindgren
2010-07-06 22:46                                   ` Gadiyar, Anand
2010-07-07  7:53                                     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100706075707.GC3192@atomide.com \
    --to=tony@atomide.com \
    --cc=ajay.gupta@ti.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).