From: Tony Lindgren <tony@atomide.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: mux: fix multipath gpio handling
Date: Tue, 6 Jul 2010 16:25:10 +0300 [thread overview]
Message-ID: <20100706132510.GS3192@atomide.com> (raw)
In-Reply-To: <1278360411-25797-1-git-send-email-notasas@gmail.com>
* Grazvydas Ignotas <notasas@gmail.com> [100705 23:00]:
> OMAP3530 CBB package can have GPIO126 muxed on 2 pins: mmc1_dat4 and
> cam_strobe. This causes a problem with current multipath GPIO mux
> handling, which muxes both pins as GPIO126 and makes the GPIO unusable.
>
> Fix this by not muxing any pins if multipath GPIO is detected and
> just print a warning instead. It's up to board files to set correct
> mux using omap_mux_init_signal and pin name.
This looks good to me. Are you OK if we merge it during the upcoming
merge window? Kind of worried that we might break some other boards
that rely on the first GPIO getting muxed..
Tony
next prev parent reply other threads:[~2010-07-06 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 20:06 [PATCH] omap: mux: fix multipath gpio handling Grazvydas Ignotas
2010-07-06 13:25 ` Tony Lindgren [this message]
2010-07-06 13:54 ` Grazvydas Ignotas
2010-07-07 11:00 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100706132510.GS3192@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).